Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B59B8C433EF for ; Sat, 12 Mar 2022 10:01:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F0D3F8390E; Sat, 12 Mar 2022 11:01:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="eVdaFSYA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C1CD783A70; Sat, 12 Mar 2022 11:01:21 +0100 (CET) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 441D48303C for ; Sat, 12 Mar 2022 11:01:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jbx6244@gmail.com Received: by mail-ej1-x62b.google.com with SMTP id bg10so23974071ejb.4 for ; Sat, 12 Mar 2022 02:01:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=CYPUgiEU+2trxwtguuf2ExLTXGssYR8ot5+cutetBIQ=; b=eVdaFSYAJc7DzgKHOK0qGIKUNA1tTDRDGvW7kJScIPseWuNkf1+SHcnZTQ1uvzgKof hvQT7vbBKamq8GRprhO8WGQ1yd/0IRVdnT85DPJHqMIUMroT6SzlPHn/kceTj0WyG5c7 kzFZyBZtBFiCQsvAQ+opDNYS2K+5LwCHDwYdQvO6w4a+4Rjc2TN5vOnPOxSCDJUUjDNC wFtiz6rL15KD6cTevegndkDRvy1BvR/8ldQHVpW4n/XEvtD30AgvmLK1zllo+ZSi0TF2 inJunqvZvIieH6unR2CbY+83W2lV1Gl6p1k7uY8HAqq9VQu5lt0wblL6E+eHaTZB7gu1 hkYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=CYPUgiEU+2trxwtguuf2ExLTXGssYR8ot5+cutetBIQ=; b=6Ejfez56RVLItjzawNQ5dNu6rBUT8VydB8ffRQiMmAsmX/+8A3fpQhnGyGFNv5I/FZ iQWnrcWq+kLDottRh4Oha6ZrcJy37UEl0YfF1pvyP8vNteHZ0YMEe3+weTCUW/TZZMso owoeGNKfyXFtbXoXy2l509ZJS5DBZcOTjIDvWnn/Gx4KYKhlWBEBq9KVsyEw6TBgZRmj myIjzT2j9iu+DWKWv0K2rn4SBNf3iVao5UTkIRnrCYvx54YQbh8FMH7U4H1uahZkZoDm 7LRnlHj/j0vm/iiSKWT9J8JLGhsR806l9zqlqAJ6kACdgLRmSboZpbhZ11Y1gpCAP5BE jd1g== X-Gm-Message-State: AOAM5327lFCxLZmM2FS7VXNuPR7EHOD9NlQFUWBqFdcMQu8vLYzwD9rP aBNrtPCTzaELbTC8DPvNa1Y= X-Google-Smtp-Source: ABdhPJy810/KNW3zY+6kGakG+5Y4lTGMSQE+YmAXLYTv3m6L1QlflmGMA/+0mMaXsV1PaoYCvAzvAA== X-Received: by 2002:a17:906:689:b0:6da:a1f0:a7a7 with SMTP id u9-20020a170906068900b006daa1f0a7a7mr11906843ejb.189.1647079276745; Sat, 12 Mar 2022 02:01:16 -0800 (PST) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id si13-20020a170906cecd00b006cded0c5ee2sm4233654ejb.61.2022.03.12.02.01.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Mar 2022 02:01:16 -0800 (PST) Message-ID: Date: Sat, 12 Mar 2022 11:01:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig Content-Language: en-US To: Jagan Teki Cc: kever.yang@rock-chips.com, sjg@chromium.org, philipp.tomsich@vrull.eu, u-boot@lists.denx.de References: <20211230164825.6489-1-jbx6244@gmail.com> From: Johan Jonker In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/12/22 09:51, Jagan Teki wrote: > On Thu, Dec 30, 2021 at 10:18 PM Johan Jonker wrote: >> >> Move ROCKCHIP_STIMER_BASE to Kconfig. >> >> Signed-off-by: Johan Jonker >> --- >> >> Changed V3: >> add ROCKCHIP_STIMER >> --- >> arch/arm/mach-rockchip/Kconfig | 22 ++++++++++++++++++++++ >> arch/arm/mach-rockchip/px30/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3128/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk322x/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3308/Kconfig | 10 ++++++---- >> arch/arm/mach-rockchip/rk3328/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3368/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3399/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3568/Kconfig | 3 +++ >> include/configs/px30_common.h | 1 - >> include/configs/rk3036_common.h | 1 - >> include/configs/rk3128_common.h | 1 - >> include/configs/rk322x_common.h | 1 - >> include/configs/rk3288_common.h | 1 - >> include/configs/rk3308_common.h | 1 - >> include/configs/rk3328_common.h | 1 - >> include/configs/rk3368_common.h | 1 - >> include/configs/rk3399_common.h | 1 - >> include/configs/rk3568_common.h | 1 - >> 21 files changed, 55 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig >> index da6871eb..7a624c64 100644 >> --- a/arch/arm/mach-rockchip/Kconfig >> +++ b/arch/arm/mach-rockchip/Kconfig >> @@ -343,6 +343,28 @@ config ROCKCHIP_BOOT_MODE_REG >> The Soc will enter to different boot mode(defined in asm/arch-rockchip/boot_mode.h) >> according to the value from this register. >> >> +config ROCKCHIP_STIMER >> + bool "Rockchip STIMER support" >> + default y >> + depends on (ROCKCHIP_PX30|| \ >> + ROCKCHIP_RK3036|| \ >> + ROCKCHIP_RK3128|| \ >> + ROCKCHIP_RK322X|| \ >> + ROCKCHIP_RK3288|| \ >> + ROCKCHIP_RK3308|| \ >> + ROCKCHIP_RK3328|| \ >> + ROCKCHIP_RK3368|| \ >> + ROCKCHIP_RK3399|| \ >> + ROCKCHIP_RK3568) > > What if we select !(SOC-Which-don't-support-stimer). I believe the > condition check here is much simpler. The condition would be simpler that's correct, but this patch is made with rk3066 in mind and there's no ROCKCHIP_RK3066 available yet. The right approach is to only include SoC's that have a specific property/functionality linked to there specific config tag. U-boot should be generic. And we should not have to fix all dependencies all over the place when a SoC doesn't have something. Please advise how to support other SoC's like rk3066. Johan > > Jagan.