From: Jae Hyun Yoo Date: Thu, 17 Dec 2020 11:54:15 -0800 Subject: [PATCH 2/2] media: aspeed: fix clock handling logic In-Reply-To: <160820199393.1580929.9806429719720580479@swboyd.mtv.corp.google.com> References: <20201207164240.15436-1-jae.hyun.yoo@linux.intel.com> <20201207164240.15436-3-jae.hyun.yoo@linux.intel.com> <160820199393.1580929.9806429719720580479@swboyd.mtv.corp.google.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Stephen, On 12/17/2020 2:46 AM, Stephen Boyd wrote: > Quoting Jae Hyun Yoo (2020-12-08 09:16:29) >> Hi Joel, >> >> On 12/7/2020 6:39 PM, Joel Stanley wrote: >>> On Mon, 7 Dec 2020 at 16:33, Jae Hyun Yoo wrote: >>>> >>>> Video engine uses eclk and vclk for its clock sources and its reset >>>> control is coupled with eclk so the current clock enabling sequence works >>>> like below. >>>> >>>> Enable eclk >>>> De-assert Video Engine reset >>>> 10ms delay >>>> Enable vclk >>> >>> This is the case after " clk: ast2600: fix reset settings for eclk and >>> vclk" is applied, correct? Without that patch applied the reset >>> sequence is correct by accident for the 2600, but it will be wrong for >>> the 2500? >> >> Correct. Video Engine reset was coupled with eclk for AST2500 and vclk >> for AST2600 so above sequence was observed only in AST2500. As you said, >> AST2600 didn't make the issue by accident but the clk/reset pair should >> be fixed by this patch series. > > So should the two patches be squashed together and go through the > media tree? > The first patch should go through clk tree, and the second one (this patch) should go through media tree. Both patches should be applied at the same time. Should I squash them in this case?