Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5447EC47082 for ; Mon, 7 Jun 2021 14:41:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D0E5610C7 for ; Mon, 7 Jun 2021 14:41:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbhFGOnR (ORCPT ); Mon, 7 Jun 2021 10:43:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbhFGOnQ (ORCPT ); Mon, 7 Jun 2021 10:43:16 -0400 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EC53C061766 for ; Mon, 7 Jun 2021 07:41:18 -0700 (PDT) Received: by mail-oi1-x22f.google.com with SMTP id d21so18248387oic.11 for ; Mon, 07 Jun 2021 07:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DSnfLz3U0TVzQx9+l9kiDcAFeuAuf4SBuw6nQ1Ks7Oc=; b=fkEfAbNZSGz/Yv3oJgISuFL8293zBM8FmhqsnerxeSgs168O7wb7aPgzzaR9hseqmg b2yzkzr7LW4+4lMz9JWlGAUWpUW+Z4EODuY+Oj5hk6Cvq81JKoatYgLqidyojwg3HRFI 5HYXTqmplHqIiX03Y/rW8JcuEwDdwEu8U04ZrGROAYOEoln3cFLv05wgQ3jlzVGpcE9A wHas5ADct99wNNs2E6LwxbhcjayZi/SfAfKJmLhCTj53SE0WCD5AHbMJEQNeT+73HdEg fH0eqlY2BjlGzUfhjkFgZLKSNPVOtYFL7E3j81F35/+pS9GQ3DEulesxoVFoU2slMRZG PQKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DSnfLz3U0TVzQx9+l9kiDcAFeuAuf4SBuw6nQ1Ks7Oc=; b=aVchlCPxrB9FE0jLWuSY6PzR6nCCORJABy3CVum9kIgtZbtDN2S8qnyWjH9JTjBLlx 8Z+OK/XfQrgiM8dUmbNacZBQU4Sr07os60h7zIJzm6FLejCYJviAFEnViGyU1YINaKJ2 Xl3jFmngP+ay+W+kIxNVK+d55BdMtWOefS3hkwPX9d9DIjVKYPmriU0KzZMPR7p59NRJ JMgUQDSOTgzGoCDB5CiT57bdLcBb799M5sdqsRI4/sQU1cOuPAVPV1z3ZkyCW5zZiCzS Ut7bpnN0ONvo1e0TzKDHlSESxLSXzMy+7FlvPaQBDqKV7fPp30wsEiyXusFsA74gFUed Bdeg== X-Gm-Message-State: AOAM532GK9cC7/FuhwDeVnijNEjTPD10EXoe9ZCpAn/nO+u8GloYJHKF tkG2P9K4nHPMyc2jpnXEY/Q= X-Google-Smtp-Source: ABdhPJyWj6kuPOzvGOpMQp30/CmaLi3ni9029zy/HPmcdzz97HSqU58so2QQC8g82OWYAq6U7fmzdA== X-Received: by 2002:a54:448a:: with SMTP id v10mr11859596oiv.133.1623076877502; Mon, 07 Jun 2021 07:41:17 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.22]) by smtp.googlemail.com with ESMTPSA id c11sm921253oot.25.2021.06.07.07.41.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 07:41:17 -0700 (PDT) Subject: Re: [PATCH RESEND iproute2-next] devlink: Add optional controller user input To: Parav Pandit , "stephen@networkplumber.org" , "netdev@vger.kernel.org" Cc: Jiri Pirko References: <20210603111901.9888-1-parav@nvidia.com> <43ebc191-4b2d-4866-411b-81de63024942@gmail.com> From: David Ahern Message-ID: Date: Mon, 7 Jun 2021 08:41:15 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/7/21 5:43 AM, Parav Pandit wrote: > Hi David, > >> From: David Ahern >> Sent: Monday, June 7, 2021 8:31 AM >> >> On 6/3/21 5:19 AM, Parav Pandit wrote: >>> @@ -3795,7 +3806,7 @@ static void cmd_port_help(void) >>> pr_err(" devlink port param set DEV/PORT_INDEX name >> PARAMETER value VALUE cmode { permanent | driverinit | runtime }\n"); >>> pr_err(" devlink port param show [DEV/PORT_INDEX name >> PARAMETER]\n"); >>> pr_err(" devlink port health show [ DEV/PORT_INDEX reporter >> REPORTER_NAME ]\n"); >>> - pr_err(" devlink port add DEV/PORT_INDEX flavour FLAVOUR >> pfnum PFNUM [ sfnum SFNUM ]\n"); >>> + pr_err(" devlink port add DEV/PORT_INDEX flavour FLAVOUR >> pfnum PFNUM [ sfnum SFNUM ] [ controller CNUM ]\n"); >>> pr_err(" devlink port del DEV/PORT_INDEX\n"); >>> } >>> >>> @@ -4324,7 +4335,7 @@ static int __cmd_health_show(struct dl *dl, bool >>> show_device, bool show_port); >>> >>> static void cmd_port_add_help(void) >>> { >>> - pr_err(" devlink port add { DEV | DEV/PORT_INDEX } flavour >> FLAVOUR pfnum PFNUM [ sfnum SFNUM ]\n"); >>> + pr_err(" devlink port add { DEV | DEV/PORT_INDEX } flavour >> FLAVOUR pfnum PFNUM [ sfnum SFNUM ] [ controller CNUM ]\n"); >> >> This line and the one above need to be wrapped. This addition puts it well >> into the 90s. >> > It’s a print message. > I was following coding style of [1] that says "However, never break user-visible strings such as printk messages because that breaks the ability to grep for them.". > Recent code of dcb_ets.c has similar long string in print. So I didn't wrap it. I missed that when reviewing the dcb command then. > Should we warp it? > > [1] https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings > [1] is referring to messages from kernel code, and I agree with that style. This is help message from iproute2. I tend to keep my terminal widths between 80 and 90 columns, so the long help lines from commands are not very friendly causing me to resize the terminal.