From: =?UTF-8?Q?Nicolai_H=c3=a4hnle?= Subject: Re: [libdrm] amdgpu/: concisely && consistently check null ptrs in canonical form Date: Wed, 19 Apr 2017 08:50:01 +0200 Message-ID: References: <20170418162032.16101-1-funfunctor@folklore1984.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170418162032.16101-1-funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Edward O'Callaghan , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gMTguMDQuMjAxNyAxODoyMCwgRWR3YXJkIE8nQ2FsbGFnaGFuIHdyb3RlOgo+IEJlIGNvbnNp c3RlbnQgYW5kIHVzZSB0aGUgY2Fub25pY2FsIGZvcm0gd2hpbGUgc2FuaXR5IGNoZWNraW5nCj4g bnVsbCBwb2ludGVycywgYWxzbyBjb21iaW5lIGEgZmV3IGJyYW5jaGVzIGZvciBicmV2aXR5Lgo+ Cj4gU2lnbmVkLW9mZi1ieTogRWR3YXJkIE8nQ2FsbGFnaGFuIDxmdW5mdW5jdG9yQGZvbGtsb3Jl MTk4NC5uZXQ+CgpTdXJlLCBpdCdzIGEgZ29vZCBjbGVhbnVwLiBGZWVsIGZyZWUgdG8gYWRkIHRo ZSBjb3JyZXNwb25kaW5nIGNoYW5nZSAKYWxzbyB0byBhbWRncHVfY3Nfd2FpdF9mZW5jZXMgd2hp Y2ggSSd2ZSBhbHJlYWR5IHB1c2hlZC4KClJldmlld2VkLWJ5OiBOaWNvbGFpIEjDpGhubGUgPG5p Y29sYWkuaGFlaG5sZUBhbWQuY29tPgoKCj4gLS0tCj4gIGFtZGdwdS9hbWRncHVfYm8uYyAgICAg ICB8ICAyICstCj4gIGFtZGdwdS9hbWRncHVfY3MuYyAgICAgICB8IDM2ICsrKysrKysrKysrLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBhbWRncHUvYW1kZ3B1X2dwdV9pbmZvLmMgfCAgNSAr KystLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDI4IGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2FtZGdwdS9hbWRncHVfYm8uYyBiL2FtZGdwdS9hbWRncHVfYm8u Ywo+IGluZGV4IDlhZGZmZmEuLjVhYzQ1NmIgMTAwNjQ0Cj4gLS0tIGEvYW1kZ3B1L2FtZGdwdV9i by5jCj4gKysrIGIvYW1kZ3B1L2FtZGdwdV9iby5jCj4gQEAgLTY1Miw3ICs2NTIsNyBAQCBpbnQg YW1kZ3B1X2JvX2xpc3RfdXBkYXRlKGFtZGdwdV9ib19saXN0X2hhbmRsZSBoYW5kbGUsCj4gIAkJ cmV0dXJuIC1FSU5WQUw7Cj4KPiAgCWxpc3QgPSBtYWxsb2MobnVtYmVyX29mX3Jlc291cmNlcyAq IHNpemVvZihzdHJ1Y3QgZHJtX2FtZGdwdV9ib19saXN0X2VudHJ5KSk7Cj4gLQlpZiAobGlzdCA9 PSBOVUxMKQo+ICsJaWYgKCFsaXN0KQo+ICAJCXJldHVybiAtRU5PTUVNOwo+Cj4gIAlhcmdzLmlu Lm9wZXJhdGlvbiA9IEFNREdQVV9CT19MSVNUX09QX1VQREFURTsKPiBkaWZmIC0tZ2l0IGEvYW1k Z3B1L2FtZGdwdV9jcy5jIGIvYW1kZ3B1L2FtZGdwdV9jcy5jCj4gaW5kZXggZmI1YjNhOC4uN2Zi YmE5NiAxMDA2NDQKPiAtLS0gYS9hbWRncHUvYW1kZ3B1X2NzLmMKPiArKysgYi9hbWRncHUvYW1k Z3B1X2NzLmMKPiBAQCAtNTksMTMgKzU5LDExIEBAIGludCBhbWRncHVfY3NfY3R4X2NyZWF0ZShh bWRncHVfZGV2aWNlX2hhbmRsZSBkZXYsCj4gIAlpbnQgaSwgaiwgazsKPiAgCWludCByOwo+Cj4g LQlpZiAoTlVMTCA9PSBkZXYpCj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQlpZiAoTlVMTCA9PSBj b250ZXh0KQo+ICsJaWYgKCFkZXYgfHwgIWNvbnRleHQpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4K PiAgCWdwdV9jb250ZXh0ID0gY2FsbG9jKDEsIHNpemVvZihzdHJ1Y3QgYW1kZ3B1X2NvbnRleHQp KTsKPiAtCWlmIChOVUxMID09IGdwdV9jb250ZXh0KQo+ICsJaWYgKCFncHVfY29udGV4dCkKPiAg CQlyZXR1cm4gLUVOT01FTTsKPgo+ICAJZ3B1X2NvbnRleHQtPmRldiA9IGRldjsKPiBAQCAtMTEw LDcgKzEwOCw3IEBAIGludCBhbWRncHVfY3NfY3R4X2ZyZWUoYW1kZ3B1X2NvbnRleHRfaGFuZGxl IGNvbnRleHQpCj4gIAlpbnQgaSwgaiwgazsKPiAgCWludCByOwo+Cj4gLQlpZiAoTlVMTCA9PSBj b250ZXh0KQo+ICsJaWYgKCFjb250ZXh0KQo+ICAJCXJldHVybiAtRUlOVkFMOwo+Cj4gIAlwdGhy ZWFkX211dGV4X2Rlc3Ryb3koJmNvbnRleHQtPnNlcXVlbmNlX211dGV4KTsKPiBAQCAtMzMwLDkg KzMyOCw3IEBAIGludCBhbWRncHVfY3Nfc3VibWl0KGFtZGdwdV9jb250ZXh0X2hhbmRsZSBjb250 ZXh0LAo+ICAJdWludDMyX3QgaTsKPiAgCWludCByOwo+Cj4gLQlpZiAoTlVMTCA9PSBjb250ZXh0 KQo+IC0JCXJldHVybiAtRUlOVkFMOwo+IC0JaWYgKE5VTEwgPT0gaWJzX3JlcXVlc3QpCj4gKwlp ZiAoIWNvbnRleHQgfHwgIWlic19yZXF1ZXN0KQo+ICAJCXJldHVybiAtRUlOVkFMOwo+Cj4gIAly ID0gMDsKPiBAQCAtNDE2LDExICs0MTIsNyBAQCBpbnQgYW1kZ3B1X2NzX3F1ZXJ5X2ZlbmNlX3N0 YXR1cyhzdHJ1Y3QgYW1kZ3B1X2NzX2ZlbmNlICpmZW5jZSwKPiAgCWJvb2wgYnVzeSA9IHRydWU7 Cj4gIAlpbnQgcjsKPgo+IC0JaWYgKE5VTEwgPT0gZmVuY2UpCj4gLQkJcmV0dXJuIC1FSU5WQUw7 Cj4gLQlpZiAoTlVMTCA9PSBleHBpcmVkKQo+IC0JCXJldHVybiAtRUlOVkFMOwo+IC0JaWYgKE5V TEwgPT0gZmVuY2UtPmNvbnRleHQpCj4gKwlpZiAoIWZlbmNlIHx8ICFleHBpcmVkIHx8ICFmZW5j ZS0+Y29udGV4dCkKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCWlmIChmZW5jZS0+aXBfdHlwZSA+ PSBBTURHUFVfSFdfSVBfTlVNKQo+ICAJCXJldHVybiAtRUlOVkFMOwo+IEBAIC00NDcsMTEgKzQz OSwxMSBAQCBpbnQgYW1kZ3B1X2NzX2NyZWF0ZV9zZW1hcGhvcmUoYW1kZ3B1X3NlbWFwaG9yZV9o YW5kbGUgKnNlbSkKPiAgewo+ICAJc3RydWN0IGFtZGdwdV9zZW1hcGhvcmUgKmdwdV9zZW1hcGhv cmU7Cj4KPiAtCWlmIChOVUxMID09IHNlbSkKPiArCWlmICghc2VtKQo+ICAJCXJldHVybiAtRUlO VkFMOwo+Cj4gIAlncHVfc2VtYXBob3JlID0gY2FsbG9jKDEsIHNpemVvZihzdHJ1Y3QgYW1kZ3B1 X3NlbWFwaG9yZSkpOwo+IC0JaWYgKE5VTEwgPT0gZ3B1X3NlbWFwaG9yZSkKPiArCWlmICghZ3B1 X3NlbWFwaG9yZSkKPiAgCQlyZXR1cm4gLUVOT01FTTsKPgo+ICAJYXRvbWljX3NldCgmZ3B1X3Nl bWFwaG9yZS0+cmVmY291bnQsIDEpOwo+IEBAIC00NjYsMTQgKzQ1OCwxMiBAQCBpbnQgYW1kZ3B1 X2NzX3NpZ25hbF9zZW1hcGhvcmUoYW1kZ3B1X2NvbnRleHRfaGFuZGxlIGN0eCwKPiAgCQkJICAg ICAgIHVpbnQzMl90IHJpbmcsCj4gIAkJCSAgICAgICBhbWRncHVfc2VtYXBob3JlX2hhbmRsZSBz ZW0pCj4gIHsKPiAtCWlmIChOVUxMID09IGN0eCkKPiArCWlmICghY3R4IHx8ICFzZW0pCj4gIAkJ cmV0dXJuIC1FSU5WQUw7Cj4gIAlpZiAoaXBfdHlwZSA+PSBBTURHUFVfSFdfSVBfTlVNKQo+ICAJ CXJldHVybiAtRUlOVkFMOwo+ICAJaWYgKHJpbmcgPj0gQU1ER1BVX0NTX01BWF9SSU5HUykKPiAg CQlyZXR1cm4gLUVJTlZBTDsKPiAtCWlmIChOVUxMID09IHNlbSkKPiAtCQlyZXR1cm4gLUVJTlZB TDsKPiAgCS8qIHNlbSBoYXMgYmVlbiBzaWduYWxlZCAqLwo+ICAJaWYgKHNlbS0+c2lnbmFsX2Zl bmNlLmNvbnRleHQpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gQEAgLTQ5NCwxNCArNDg0LDEyIEBA IGludCBhbWRncHVfY3Nfd2FpdF9zZW1hcGhvcmUoYW1kZ3B1X2NvbnRleHRfaGFuZGxlIGN0eCwK PiAgCQkJICAgICB1aW50MzJfdCByaW5nLAo+ICAJCQkgICAgIGFtZGdwdV9zZW1hcGhvcmVfaGFu ZGxlIHNlbSkKPiAgewo+IC0JaWYgKE5VTEwgPT0gY3R4KQo+ICsJaWYgKCFjdHggfHwgIXNlbSkK PiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCWlmIChpcF90eXBlID49IEFNREdQVV9IV19JUF9OVU0p Cj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAlpZiAocmluZyA+PSBBTURHUFVfQ1NfTUFYX1JJTkdT KQo+ICAJCXJldHVybiAtRUlOVkFMOwo+IC0JaWYgKE5VTEwgPT0gc2VtKQo+IC0JCXJldHVybiAt RUlOVkFMOwo+ICAJLyogbXVzdCBzaWduYWwgZmlyc3QgKi8KPiAgCWlmIChOVUxMID09IHNlbS0+ c2lnbmFsX2ZlbmNlLmNvbnRleHQpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gQEAgLTUxNCw5ICs1 MDIsNyBAQCBpbnQgYW1kZ3B1X2NzX3dhaXRfc2VtYXBob3JlKGFtZGdwdV9jb250ZXh0X2hhbmRs ZSBjdHgsCj4KPiAgc3RhdGljIGludCBhbWRncHVfY3NfcmVzZXRfc2VtKGFtZGdwdV9zZW1hcGhv cmVfaGFuZGxlIHNlbSkKPiAgewo+IC0JaWYgKE5VTEwgPT0gc2VtKQo+IC0JCXJldHVybiAtRUlO VkFMOwo+IC0JaWYgKE5VTEwgPT0gc2VtLT5zaWduYWxfZmVuY2UuY29udGV4dCkKPiArCWlmICgh c2VtIHx8ICFzZW0tPnNpZ25hbF9mZW5jZS5jb250ZXh0KQo+ICAJCXJldHVybiAtRUlOVkFMOwo+ Cj4gIAlzZW0tPnNpZ25hbF9mZW5jZS5jb250ZXh0ID0gTlVMTDs7Cj4gQEAgLTUzMCw3ICs1MTYs NyBAQCBzdGF0aWMgaW50IGFtZGdwdV9jc19yZXNldF9zZW0oYW1kZ3B1X3NlbWFwaG9yZV9oYW5k bGUgc2VtKQo+Cj4gIHN0YXRpYyBpbnQgYW1kZ3B1X2NzX3VucmVmZXJlbmNlX3NlbShhbWRncHVf c2VtYXBob3JlX2hhbmRsZSBzZW0pCj4gIHsKPiAtCWlmIChOVUxMID09IHNlbSkKPiArCWlmICgh c2VtKQo+ICAJCXJldHVybiAtRUlOVkFMOwo+Cj4gIAlpZiAodXBkYXRlX3JlZmVyZW5jZXMoJnNl bS0+cmVmY291bnQsIE5VTEwpKQo+IGRpZmYgLS1naXQgYS9hbWRncHUvYW1kZ3B1X2dwdV9pbmZv LmMgYi9hbWRncHUvYW1kZ3B1X2dwdV9pbmZvLmMKPiBpbmRleCBmNGI5NGM5Li4xZWZmZmM2IDEw MDY0NAo+IC0tLSBhL2FtZGdwdS9hbWRncHVfZ3B1X2luZm8uYwo+ICsrKyBiL2FtZGdwdS9hbWRn cHVfZ3B1X2luZm8uYwo+IEBAIC0yMzQsOCArMjM0LDkgQEAgZHJtX3ByaXZhdGUgaW50IGFtZGdw dV9xdWVyeV9ncHVfaW5mb19pbml0KGFtZGdwdV9kZXZpY2VfaGFuZGxlIGRldikKPiAgaW50IGFt ZGdwdV9xdWVyeV9ncHVfaW5mbyhhbWRncHVfZGV2aWNlX2hhbmRsZSBkZXYsCj4gIAkJCXN0cnVj dCBhbWRncHVfZ3B1X2luZm8gKmluZm8pCj4gIHsKPiAtCWlmICgoZGV2ID09IE5VTEwpIHx8IChp bmZvID09IE5VTEwpKQo+ICsJaWYgKCFkZXYgfHwgIWluZm8pCj4gIAkJcmV0dXJuIC1FSU5WQUw7 Cj4gKwo+ICAJLyogR2V0IEFTSUMgaW5mbyovCj4gIAkqaW5mbyA9IGRldi0+aW5mbzsKPgo+IEBA IC0zMDAsNyArMzAxLDcgQEAgaW50IGFtZGdwdV9xdWVyeV9nZHNfaW5mbyhhbWRncHVfZGV2aWNl X2hhbmRsZSBkZXYsCj4gIAlzdHJ1Y3QgZHJtX2FtZGdwdV9pbmZvX2dkcyBnZHNfY29uZmlnID0g e307Cj4gICAgICAgICAgaW50IHI7Cj4KPiAtCWlmIChnZHNfaW5mbyA9PSBOVUxMKQo+ICsJaWYg KCFnZHNfaW5mbykKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPgo+ICAgICAgICAgIHIgPSBhbWRncHVf cXVlcnlfaW5mbyhkZXYsIEFNREdQVV9JTkZPX0dEU19DT05GSUcsCj4KCgotLSAKTGVybmUsIHdp ZSBkaWUgV2VsdCB3aXJrbGljaCBpc3QsCkFiZXIgdmVyZ2lzcyBuaWVtYWxzLCB3aWUgc2llIHNl aW4gc29sbHRlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK