From: Hannes Reinecke Subject: Re: [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool Date: Wed, 7 Jun 2023 15:02:11 +0200 Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-20-hch@lst.de> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686142931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WCQNYMRmCOzxg+oRXdrptJ2yA9LtToZAr+fXbFj8bIM=; b=VmZO8aFgJKPf9JDTxuq72yyIxH9VFqvpot6siRxHG7Lw6kWNu83cUCK1/94k1f2k372fdq zlrXxiwXe5Qd2hEQ9n8WY1xuD3ouzUnCCY8Hces3jf2HyvlIPQ0w5KgX/1w74UDtch5+b7 kfQuVRcK/Rvwrw4iDvD9fU0ZLs0Ls+E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686142931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WCQNYMRmCOzxg+oRXdrptJ2yA9LtToZAr+fXbFj8bIM=; b=1t/M6wLYtgx7/MEeJDPqJTCtEJfGG+EEWvJb9C73Zrrv6a4GxvctgEzubIQQfLB44ZJFUJ MMEAzKpCydfH6EDw== Content-Language: en-US In-Reply-To: <20230606073950.225178-20-hch-jcswGhMUV9g@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org On 6/6/23 09:39, Christoph Hellwig wrote: > Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass > a bool open_for_write to prepare for callers that won't have the fmode_t. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/scsi_bsg.c | 2 +- > drivers/scsi/scsi_ioctl.c | 8 ++++---- > drivers/scsi/sg.c | 2 +- > include/scsi/scsi_ioctl.h | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes