Content-Type: multipart/mixed; boundary="===============7789005059237726719==" MIME-Version: 1.0 From: Like Xu To: kbuild-all@lists.01.org Subject: Re: [PATCH 6/7] perf: x86/core: Add interface to query perfmon_event_map[] directly Date: Thu, 18 Nov 2021 21:36:39 +0800 Message-ID: In-Reply-To: <97ea49ce-2ec2-3b35-6aac-d30998b837fe@gmail.com> List-Id: --===============7789005059237726719== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 18/11/2021 4:06 pm, Like Xu wrote: > On 18/11/2021 7:21 am, kernel test robot wrote: >> Hi Like, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on kvm/queue] >> [also build test ERROR on tip/perf/core mst-vhost/linux-next linus/maste= r = >> v5.16-rc1 next-20211117] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> > = > ... > = >> vim +500 arch/x86/include/asm/perf_event.h >> >> =C2=A0=C2=A0=C2=A0 492 >> =C2=A0=C2=A0=C2=A0 493=C2=A0=C2=A0=C2=A0 #if defined(CONFIG_PERF_EVENTS)= && defined(CONFIG_CPU_SUP_INTEL) >> =C2=A0=C2=A0=C2=A0 494=C2=A0=C2=A0=C2=A0 extern struct perf_guest_switch= _msr *perf_guest_get_msrs(int *nr); >> =C2=A0=C2=A0=C2=A0 495=C2=A0=C2=A0=C2=A0 extern u64 perf_get_hw_event_co= nfig(int perf_hw_id); >> =C2=A0=C2=A0=C2=A0 496=C2=A0=C2=A0=C2=A0 extern int x86_perf_get_lbr(str= uct x86_pmu_lbr *lbr); >> =C2=A0=C2=A0=C2=A0 497=C2=A0=C2=A0=C2=A0 #else >> =C2=A0=C2=A0=C2=A0 498=C2=A0=C2=A0=C2=A0 struct perf_guest_switch_msr *p= erf_guest_get_msrs(int *nr); >> =C2=A0=C2=A0=C2=A0 499=C2=A0=C2=A0=C2=A0 u64 perf_get_hw_event_config(in= t perf_hw_id); > = > Thanks to the robot, I should have removed the ";" from this line. > = Sorry, my bot is shouting at me again. This part should be: diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_= event.h index 8fc1b5003713..85fd768d49d7 100644 --- a/arch/x86/include/asm/perf_event.h +++ b/arch/x86/include/asm/perf_event.h @@ -492,9 +492,11 @@ static inline void perf_check_microcode(void) { } #if defined(CONFIG_PERF_EVENTS) && defined(CONFIG_CPU_SUP_INTEL) extern struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr); +extern u64 perf_get_hw_event_config(int perf_hw_id); extern int x86_perf_get_lbr(struct x86_pmu_lbr *lbr); #else struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr); +static u64 perf_get_hw_event_config(int perf_hw_id); static inline int x86_perf_get_lbr(struct x86_pmu_lbr *lbr) { return -1; > Awaiting further review comments. > = >> =C2=A0 > 500=C2=A0=C2=A0=C2=A0 { >> =C2=A0=C2=A0=C2=A0 501=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return = 0; >> =C2=A0=C2=A0=C2=A0 502=C2=A0=C2=A0=C2=A0 } >> =C2=A0=C2=A0=C2=A0 503=C2=A0=C2=A0=C2=A0 static inline int x86_perf_get_= lbr(struct x86_pmu_lbr *lbr) >> =C2=A0=C2=A0=C2=A0 504=C2=A0=C2=A0=C2=A0 { >> =C2=A0=C2=A0=C2=A0 505=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return = -1; >> =C2=A0=C2=A0=C2=A0 506=C2=A0=C2=A0=C2=A0 } >> =C2=A0=C2=A0=C2=A0 507=C2=A0=C2=A0=C2=A0 #endif >> =C2=A0=C2=A0=C2=A0 508 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org >> --===============7789005059237726719==--