From: "its_Giaan (Code Review)" Date: Fri, 24 Jan 2025 17:29:21 +0000 In-Reply-To: References: Reply-To: gianmarco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296..., a@...2181... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="bdQn++dvUwM="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: mroute: adapt to new protocol handling and hashing improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , cron2 , flichtenheld Cc: openvpn-devel --bdQn++dvUwM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, ordex, plais= thos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/765?usp=3Demail to look at the new patch set (#17). Change subject: mroute: adapt to new protocol handling and hashing improvem= ents ...................................................................... mroute: adapt to new protocol handling and hashing improvements Repurposing an unused field and renaming it to 'proto' instead of introducing a new field. The hashing now begins at the 'proto' field rather than the 'type' field. Additionally, the changes ensure that the correct protocol is consistently used with virtual addresses ensuring alignment. Change-Id: Ic66eccb5058fe9c0fae64d8e2ca88728068a92ab Signed-off-by: Gianmarco De Gregori --- M src/openvpn/mroute.c M src/openvpn/mroute.h M src/openvpn/mtcp.c M src/openvpn/mudp.c M src/openvpn/multi.c 5 files changed, 21 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/65/765/17 diff --git a/src/openvpn/mroute.c b/src/openvpn/mroute.c index 80e18b7..74923cf 100644 --- a/src/openvpn/mroute.c +++ b/src/openvpn/mroute.c @@ -454,6 +454,7 @@ buf_printf(&out, "UNKNOWN"); break; } + buf_printf(&out, "|%d", maddr.proto); return BSTR(&out); } else diff --git a/src/openvpn/mroute.h b/src/openvpn/mroute.h index 8b457d4..2659695 100644 --- a/src/openvpn/mroute.h +++ b/src/openvpn/mroute.h @@ -74,7 +74,7 @@ struct mroute_addr { uint8_t len; /* length of address */ - uint8_t unused; + uint8_t proto; uint8_t type; /* MR_ADDR/MR_WITH flags */ uint8_t netbits; /* number of bits in network part of address, * valid if MR_WITH_NETBITS is set */ @@ -183,6 +183,15 @@ { unsigned int ret =3D 0; verify_align_4(buf); + + /* + * Since we don't really need the protocol on vaddresses for internal = VPN + * payload packets, make sure we have the same value to avoid hashing = insert + * and search issues. + */ + src->proto =3D 0; + dest->proto =3D src->proto; + if (tunnel_type =3D=3D DEV_TYPE_TUN) { ret =3D mroute_extract_addr_ip(src, dest, buf); @@ -201,6 +210,10 @@ { return false; } + if (a1->proto !=3D a2->proto) + { + return false; + } if (a1->netbits !=3D a2->netbits) { return false; @@ -216,13 +229,13 @@ mroute_addr_hash_ptr(const struct mroute_addr *a) { /* NOTE: depends on ordering of struct mroute_addr */ - return (uint8_t *) &a->type; + return (uint8_t *) &a->proto; } static inline uint32_t mroute_addr_hash_len(const struct mroute_addr *a) { - return (uint32_t) a->len + 2; + return (uint32_t) a->len + 3; } static inline void diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index 6d1d5a0..62ed044 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -56,6 +56,7 @@ mi =3D multi_create_instance(m, NULL, ls); if (mi) { + mi->real.proto =3D ls->info.proto; struct hash_element *he; const uint32_t hv =3D hash_value(hash, &mi->real); struct hash_bucket *bucket =3D hash_bucket(hash, hv); diff --git a/src/openvpn/mudp.c b/src/openvpn/mudp.c index 6137578..4f2bbd7 100644 --- a/src/openvpn/mudp.c +++ b/src/openvpn/mudp.c @@ -192,6 +192,7 @@ struct mroute_addr real =3D {0}; struct multi_instance *mi =3D NULL; struct hash *hash =3D m->hash; + real.proto =3D ls->info.proto; =20 if (mroute_extract_openvpn_sockaddr(&real, &m->top.c2.from.dest, true) && m->top.c2.buf.len > 0) diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 3f55dd7..9c8c014 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -794,6 +794,7 @@ { goto err; } + mi->real.proto =3D ls->info.proto; generate_prefix(mi); } @@ -1243,6 +1244,7 @@ CLEAR(remote_si); remote_si.addr.in4.sin_family =3D AF_INET; remote_si.addr.in4.sin_addr.s_addr =3D htonl(a); + addr.proto =3D 0; ASSERT(mroute_extract_openvpn_sockaddr(&addr, &remote_si, false)); if (netbits >=3D 0) @@ -3548,7 +3550,6 @@ const int dev_type =3D TUNNEL_TYPE(m->top.c1.tuntap); int16_t vid =3D 0; - #ifdef MULTI_DEBUG_EVENT_LOOP printf("TUN -> TCP/UDP [%d]\n", BLEN(&m->top.c2.buf)); #endif -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/765?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic66eccb5058fe9c0fae64d8e2ca88728068a92ab Gerrit-Change-Number: 765 Gerrit-PatchSet: 17 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-MessageType: newpatchset --bdQn++dvUwM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, ordex, p= laisthos.

its_Giaan uploaded patch set #17 to this change.

= View Chan= ge

mroute: adapt to new protocol handling and hashing improvements
<= br>Repurposing an unused field and renaming it to 'proto'
instea= d of introducing a new field. The hashing now
begins at the 'proto&#= 39; field rather than the 'type'
field. Additionally, the change= s ensure that the
correct protocol is consistently used with virtual
= addresses ensuring alignment.

Change-Id: Ic66eccb5058fe9c0fae64d8e2c= a88728068a92ab
Signed-off-by: Gianmarco De Gregori <gianmarco@...2787...= ...>
---
M src/openvpn/mroute.c
M src/openvpn/mroute.h
M src= /openvpn/mtcp.c
M src/openvpn/mudp.c
M src/openvpn/multi.c
5 files= changed, 21 insertions(+), 4 deletions(-)

git pull ssh://gerrit.=
openvpn.net:29418/openvpn refs/changes/65/765/17
diff --git a/src/o=
penvpn/mroute.c b/src/openvpn/mroute.c
index 80e18b7..74923= cf 100644
--- a/src/openvpn/mroute.c
+++ b/= src/openvpn/mroute.c
@@ -454,6 +454,7 @@
= buf_printf(&out, "UNKNOWN");
= break;
}
+ buf_printf(&out, "|%d",= maddr.proto);
return BSTR(&out);
}
else
diff --git a/src/openv= pn/mroute.h b/src/openvpn/mroute.h
index 8b457d4..2659695 1= 00644
--- a/src/openvpn/mroute.h
+++ b/src/= openvpn/mroute.h
@@ -74,7 +74,7 @@
=
struct mroute_addr {
uint8_t len; /* len= gth of address */
- = uint8_t unused;
+ = uint8_t proto;
uint8_t type; /* MR_ADDR/MR_WITH flag= s */
uint8_t netbits; /* number of bits in network par= t of address,
* valid if MR_WITH_NET= BITS is set */
@@ -183,6 +183,15 @@
{
unsigned int ret =3D 0;
verify_align_= 4(buf);
+
<= span style=3D"color: hsl(120, 100%, 40%);">+ /*

+ * Since we don't really need the pr= otocol on vaddresses for internal VPN
+ * payload packets, make sure we have the same value = to avoid hashing insert
+ * and search issues.
+ */
+ = src->proto =3D 0;
+
if (tunnel_type =3D=3D DEV_TYPE_= TUN)
{
ret =3D mroute_extract= _addr_ip(src, dest, buf);
@@ -201,6 +210,10 @@
{
return false;
}

+ if (a1->proto != =3D a2->proto)
+ = {
+ return f= alse;
+ } if (a1->netbits !=3D a2->netbits)
{=
return false;
@@ -216,13 +229,13 = @@
mroute_addr_hash_ptr(const struct mroute_addr *a)
{
/* NOTE: depends on ordering of struct m= route_addr */
- retu= rn (uint8_t *) &a->type;
+ return (uint8_t *) &a->proto;
}

static inline uint32_t
mro= ute_addr_hash_len(const struct mroute_addr *a)
{- return (uint32_t) a->len= + 2;
+ return (ui= nt32_t) a->len + 3;
}

static inline void

diff --git a/src/openvpn/mtcp.c b/src/= openvpn/mtcp.c
index 6d1d5a0..62ed044 100644
--- a/src/openvpn/mtcp.c

+++ b/src/openvpn/mtcp.c<= br>@@ -56,6 +56,7 @@
mi =3D multi_create_instanc= e(m, NULL, ls);
if (mi)
{<= br>+ mi->real.proto = =3D ls->info.proto;
struct hash_element *he;

const uint32_t hv =3D hash_value(hash, &mi->r= eal);
struct hash_bucket *bucket =3D hash_bucket(h= ash, hv);
diff --git a/src/openvpn/mudp.c b/src/openvpn/mud= p.c
index 6137578..4f2bbd7 100644
--- a/src= /openvpn/mudp.c
+++ b/src/openvpn/mudp.c
@@= -192,6 +192,7 @@
struct mroute_addr real =3D {0};
struct multi_instance *mi =3D NULL;
= struct hash *hash =3D m->hash;
+ real.proto =3D ls->info.proto;

if (mroute_extract_openvpn_sockaddr(&real, &m->t= op.c2.from.dest, true)
&& m->top.c2.buf= .len > 0)
diff --git a/src/openvpn/multi.c b/src/openvpn= /multi.c
index 3f55dd7..9c8c014 100644
--- = a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c
<= span>@@ -794,6 +794,7 @@

{
= goto err;
}
+ mi->real.proto =3D ls->info.proto;
generate_prefix(mi);
}
@@ -1243,6 +1244,7 @@
CLEAR(r= emote_si);
remote_si.addr.in4.sin_family =3D AF_INET;<= /span>
remote_si.addr.in4.sin_addr.s_addr =3D htonl(a);
+ addr.proto =3D 0;
ASSERT(mroute_extract_openvpn_sockaddr(&addr, &re= mote_si, false));

if (netbits >= =3D 0)
@@ -3548,7 +3550,6 @@
const= int dev_type =3D TUNNEL_TYPE(m->top.c1.tuntap);
= int16_t vid =3D 0;

-
#ifdef MULTI_DEBUG_EVENT_LOOP
= printf("TUN -> TCP/UDP [%d]\n", BLEN(&m->= ;top.c2.buf));
#endif

= To view, visit change 765. To unsubscribe, or for help writing mail filters, vis= it settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic66eccb5058fe9c0fae64d8e2ca= 88728068a92ab
Gerrit-Change-Number: 765
Gerrit-PatchSet: 17
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-MessageType: newpatchset
--bdQn++dvUwM=--