From: "mandree (Code Review)" Date: Fri, 17 Apr 2026 10:58:52 +0000 In-Reply-To: References: Reply-To: matthias.andree@...68..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="r1YgNDt3QKw="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: OpenSSL 4.0: Use X509_check_certificate_times instead of X509_cmp_time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --r1YgNDt3QKw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. mandree has posted comments on this change by plaisthos. ( http://gerrit.op= envpn.net/c/openvpn/+/1595?usp=3Demail ) Change subject: OpenSSL 4.0: Use X509_check_certificate_times instead of X5= 09_cmp_time ...................................................................... Patch Set 5: (2 comments) Patchset: PS5: So we're using a switch to decode a subset of errors - certainly the most l= ikely ones, but should there be a fallback path for all other errors to rep= ort them? File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1595/comment/ec8212fc_9969e4dd?usp=3D= email : PS5, Line 724: } The followup question to Frank's is whether there should be a default branc= h decoding other error values in a generic way and report them. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1595?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6c2eda0e5bbb3a70b404f821e25ded81f0f5ddd5 Gerrit-Change-Number: 1595 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: mandree Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Fri, 17 Apr 2026 10:58:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No --r1YgNDt3QKw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

View = Change

2 comments:

  • Patchset:

    • Patch Set #5:

      So we're u= sing a switch to decode a subset of errors - certainly the most likely ones= , but should there be a fallback path for all other errors to report them?<= /p>

  • File src/openvpn/= ssl_openssl.c:

    • Patch Set #5, Line 724: }

      The followup question to Frank's is whethe= r there should be a default branch decoding other error values in a generic= way and report them.

To view, visit change 1595. To = unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6c2eda0e5bbb3a70b404f821e25= ded81f0f5ddd5
Gerrit-Change-Number: 1595
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: mandree <matthias.andree@...2908...= .>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Fri, 17 Apr 2026 10:58:52= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
= --r1YgNDt3QKw=--