From: Jiangyifei Date: Wed, 12 Jan 2022 08:01:27 +0000 Subject: [PATCH v4 05/12] target/riscv: Implement kvm_arch_put_registers In-Reply-To: References: <20220110013831.1594-1-jiangyifei@huawei.com> <20220110013831.1594-6-jiangyifei@huawei.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > -----Original Message----- > From: Alistair Francis [mailto:alistair23 at gmail.com] > Sent: Tuesday, January 11, 2022 7:07 AM > To: Jiangyifei > Cc: qemu-devel at nongnu.org Developers ; open > list:RISC-V ; kvm-riscv at lists.infradead.org; open > list:Overall ; libvir-list at redhat.com; Anup Patel > ; Palmer Dabbelt ; Alistair > Francis ; Bin Meng ; > Fanliang (EulerOS) ; Wubin (H) > ; Wanghaibin (D) ; > wanbo (G) ; limingwang (A) > ; Anup Patel > Subject: Re: [PATCH v4 05/12] target/riscv: Implement kvm_arch_put_registers > > On Mon, Jan 10, 2022 at 11:57 AM Yifei Jiang via > wrote: > > > > Put GPR CSR and FP registers to kvm by KVM_SET_ONE_REG ioctl > > > > Signed-off-by: Yifei Jiang > > Signed-off-by: Mingwang Li > > Reviewed-by: Alistair Francis > > Reviewed-by: Anup Patel > > --- > > target/riscv/kvm.c | 104 > > ++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 103 insertions(+), 1 deletion(-) > > > > diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c index > > 6d4df0ef6d..e695b91dc7 100644 > > --- a/target/riscv/kvm.c > > +++ b/target/riscv/kvm.c > > @@ -73,6 +73,14 @@ static uint64_t kvm_riscv_reg_id(CPURISCVState *env, > uint64_t type, uint64_t idx > > } \ > > } while(0) > > > > +#define KVM_RISCV_SET_CSR(cs, env, csr, reg) \ > > + do { \ > > + int ret = kvm_set_one_reg(cs, RISCV_CSR_REG(env, csr), ®); \ > > + if (ret) { \ > > + return ret; \ > > + } \ > > + } while(0) > > This fails checkpatch. I know there is lots of QEMU code like this, but it probably > should be `while (0)` to keep checkpatch happy. > > Please run checkpatch on all the patches. > > Alistair OK, it will be modified in the next series. Yifei