Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B21C7618E for ; Wed, 26 Apr 2023 10:18:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231341AbjDZKSA (ORCPT ); Wed, 26 Apr 2023 06:18:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbjDZKR6 (ORCPT ); Wed, 26 Apr 2023 06:17:58 -0400 Received: from www484.your-server.de (www484.your-server.de [78.47.237.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C99A35AD for ; Wed, 26 Apr 2023 03:17:56 -0700 (PDT) Received: from sslproxy04.your-server.de ([78.46.152.42]) by www484.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1prcDh-0001QV-Lh; Wed, 26 Apr 2023 12:17:53 +0200 Received: from [2003:ca:6730:e8f8:9f6:94bc:5149:da49] by sslproxy04.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prcDh-000TAb-CI; Wed, 26 Apr 2023 12:17:53 +0200 Content-Type: multipart/mixed; boundary="------------DC5h5dqW7X9JBXaH0H8pQaFG" Message-ID: Date: Wed, 26 Apr 2023 12:17:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: =?UTF-8?Q?Konrad_Gr=c3=a4fe?= Subject: [PATCH] usb: gadget: u_ether: Fix host MAC address case To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, quentin.schulz@theobroma-systems.com References: <2023042534-thing-shamrock-88c1@gregkh> Content-Language: en-US In-Reply-To: <2023042534-thing-shamrock-88c1@gregkh> X-Authenticated-Sender: k.graefe@gateware.de X-Virus-Scanned: Clear (ClamAV 0.103.8/26888/Wed Apr 26 09:32:41 2023) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This is a multi-part message in MIME format. --------------DC5h5dqW7X9JBXaH0H8pQaFG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit As the CDC-ECM specification states the host MAC address must be sent to the host as an uppercase hexadecimal string: The Unicode character is chosen from the set of values 30h through 39h and 41h through 46h (0-9 and A-F). However, snprintf(.., "%pm", ..) generates a lowercase MAC address string. While most host drivers are tolerant to this, UsbNcm.sys on Windows 10 is not. Instead it uses a different MAC address with all bytes set to zero including and after the first byte containing a lowercase letter. On Windows 11 Microsoft fixed it, but apparently they did not backport the fix. This change fixes the issue by upper-casing the MAC to comply with the specification. Signed-off-by: Konrad Gräfe --- V1 -> V2: Fixed checkpatch.pl warnings drivers/usb/gadget/function/u_ether.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --------------DC5h5dqW7X9JBXaH0H8pQaFG Content-Type: text/x-patch; charset=UTF-8; name="0001-usb-gadget-u_ether-Fix-host-MAC-address-case.patch" Content-Disposition: attachment; filename="0001-usb-gadget-u_ether-Fix-host-MAC-address-case.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2dhZGdldC9mdW5jdGlvbi91X2V0aGVyLmMgYi9k cml2ZXJzL3VzYi9nYWRnZXQvZnVuY3Rpb24vdV9ldGhlci5jCmluZGV4IDY5NTZhZDhiYThk ZC4uMjUwNzM0ZTA5MGZjIDEwMDY0NAotLS0gYS9kcml2ZXJzL3VzYi9nYWRnZXQvZnVuY3Rp b24vdV9ldGhlci5jCisrKyBiL2RyaXZlcnMvdXNiL2dhZGdldC9mdW5jdGlvbi91X2V0aGVy LmMKQEAgLTk1OCw2ICs5NTgsNyBAQCBFWFBPUlRfU1lNQk9MX0dQTChnZXRoZXJfZ2V0X2hv c3RfYWRkcik7CiBpbnQgZ2V0aGVyX2dldF9ob3N0X2FkZHJfY2RjKHN0cnVjdCBuZXRfZGV2 aWNlICpuZXQsIGNoYXIgKmhvc3RfYWRkciwgaW50IGxlbikKIHsKIAlzdHJ1Y3QgZXRoX2Rl diAqZGV2OworCWludCBpLCBzbGVuOwogCiAJaWYgKGxlbiA8IDEzKQogCQlyZXR1cm4gLUVJ TlZBTDsKQEAgLTk2NSw3ICs5NjYsMTMgQEAgaW50IGdldGhlcl9nZXRfaG9zdF9hZGRyX2Nk YyhzdHJ1Y3QgbmV0X2RldmljZSAqbmV0LCBjaGFyICpob3N0X2FkZHIsIGludCBsZW4pCiAJ ZGV2ID0gbmV0ZGV2X3ByaXYobmV0KTsKIAlzbnByaW50Zihob3N0X2FkZHIsIGxlbiwgIiVw bSIsIGRldi0+aG9zdF9tYWMpOwogCi0JcmV0dXJuIHN0cmxlbihob3N0X2FkZHIpOworCisJ c2xlbiA9IHN0cmxlbihob3N0X2FkZHIpOworCisJZm9yIChpID0gMDsgaSA8IHNsZW47IGkr KykKKwkJaG9zdF9hZGRyW2ldID0gdG91cHBlcihob3N0X2FkZHJbaV0pOworCisJcmV0dXJu IHNsZW47CiB9CiBFWFBPUlRfU1lNQk9MX0dQTChnZXRoZXJfZ2V0X2hvc3RfYWRkcl9jZGMp OwogCgo= --------------DC5h5dqW7X9JBXaH0H8pQaFG--