From: "flichtenheld (Code Review)" Date: Wed, 18 Mar 2026 13:54:01 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ZPbZqJEZODA="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: test_buffer: Add test for buf_null_terminate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --ZPbZqJEZODA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1580?usp=3Demail to review the following change. Change subject: test_buffer: Add test for buf_null_terminate ...................................................................... test_buffer: Add test for buf_null_terminate Change-Id: I01683153a68e1809a4d7ab455eb346f53780e219 Signed-off-by: Frank Lichtenheld --- M tests/unit_tests/openvpn/test_buffer.c 1 file changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/80/1580/1 diff --git a/tests/unit_tests/openvpn/test_buffer.c b/tests/unit_tests/open= vpn/test_buffer.c index 5f43e0d..326de40 100644 --- a/tests/unit_tests/openvpn/test_buffer.c +++ b/tests/unit_tests/openvpn/test_buffer.c @@ -460,6 +460,32 @@ gc_free(&gc); } +void +test_buffer_null_terminate(void **state) +{ + struct gc_arena gc =3D gc_new(); + + struct buffer buf =3D alloc_buf_gc(5, &gc); + const char test1[] =3D "1234"; + const char test2[] =3D "12345"; + assert_true(buf_write(&buf, test1, sizeof(test1))); + assert_string_equal(BSTR(&buf), "1234"); + buf_null_terminate(&buf); + assert_string_equal(BSTR(&buf), "1234"); + + assert_true(buf_inc_len(&buf, -1)); + assert_true(buf_write_u8(&buf, '5')); + assert_memory_equal(BPTR(&buf), test2, strlen(test2)); + buf_null_terminate(&buf); + assert_string_equal(BSTR(&buf), "1234"); + + struct buffer buf2; + CLEAR(buf2); + buf_null_terminate(&buf2); + + gc_free(&gc); +} + /* for building long texts */ #define A_TIMES_256 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAO" @@ -540,6 +566,7 @@ cmocka_unit_test(test_snprintf), cmocka_unit_test(test_checked_snprintf), cmocka_unit_test(test_buffer_chomp), + cmocka_unit_test(test_buffer_null_terminate), cmocka_unit_test(test_buffer_parse) }; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1580?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I01683153a68e1809a4d7ab455eb346f53780e219 Gerrit-Change-Number: 1580 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --ZPbZqJEZODA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

test_buffer: Add test for buf_null_terminat=
e

Change-Id: I01683153a68e1809a4d7ab455eb346f53780e219
Signed-off= -by: Frank Lichtenheld <frank@...2641...>
---
M tests/unit_test= s/openvpn/test_buffer.c
1 file changed, 27 insertions(+), 0 deletions(-)=

git pull ssh://gerrit.openvpn.net:29418/openvpn=
 refs/changes/80/1580/1
diff --git a/tests/unit_tests/openvpn/test_=
buffer.c b/tests/unit_tests/openvpn/test_buffer.c
index 5f4= 3e0d..326de40 100644
--- a/tests/unit_tests/openvpn/test_bu= ffer.c
+++ b/tests/unit_tests/openvpn/test_buffer.c<= br>@@ -460,6 +460,32 @@
gc_free(&gc);=
}

+void
+test= _buffer_null_terminate(void **state)
+{
+ = struct gc_arena gc =3D gc_new();
+
+ = struct buffer buf =3D alloc_buf_gc(5, &gc);
+ const char test1[] =3D "1234";
+ const char test2[= ] =3D "12345";
+ assert_true(buf_write(&buf, test1, sizeof(test1)));
= + assert_string_equal(BSTR(&= amp;buf), "1234");
+ buf_null_terminate(&buf);
+ assert_string_equal(BSTR(&buf), "1234&q= uot;);
+
+ assert_true(buf_inc_len(&= ;buf, -1));

+ asse= rt_true(buf_write_u8(&buf, '5'));
+ assert_memory_equal(BPTR(&buf), test2, st= rlen(test2));
+ bu= f_null_terminate(&buf);
+ assert_string_equal(BSTR(&buf), "1234");+
+ struct buffer buf2;
+ CLEAR(buf2);
+ buf_null_terminate(&buf2);+
+ gc_free(&gc);
+}
+
/* for building long texts */
= #define A_TIMES_256 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAO"
=
@@ -540,6 +566,7 @@
cmocka= _unit_test(test_snprintf),
cmocka_unit_test(test_c= hecked_snprintf),
cmocka_unit_test(test_buffer_cho= mp),
+ cmocka_= unit_test(test_buffer_null_terminate),
cmocka_unit= _test(test_buffer_parse)
};

To view, visit change 1580. To unsubscribe, or for = help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I01683153a68e1809a4d7ab455eb= 346f53780e219
Gerrit-Change-Number: 1580
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --ZPbZqJEZODA=--