Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mail.openembedded.org (Postfix) with ESMTP id 90A397F2F4 for ; Fri, 2 Aug 2019 12:35:31 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id f17so66168194wme.2 for ; Fri, 02 Aug 2019 05:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=E7cPOgdJBspjppljqaizPMm1XgrMMBjh+N/TrRJWpAg=; b=PWh5LUMhAKClBCkNs0Ac7PHk4uRQRw94QpAuH5YPBrQ3Ps3E2uL4dP54xEBxywyqAv sWe7CWgfGoQyCZ0ytUmTV551c8sGXK79ukjXLchRMXr0jV0rWPyMnrQofIr0N4wW2GSA UWjoewDrX+RP1lOUcjo8ZZRyD8VsO6WQD/RRg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=E7cPOgdJBspjppljqaizPMm1XgrMMBjh+N/TrRJWpAg=; b=IIlP3iVo0+/dGkzvkNmN6rrz/VY/rgrw7nS/IXDLkAMLoSQFSGqc+3i3ujkQD5FACu Rz+BMtUMwCdnXVnHWBfeWhVYUoPIiheZEKgSCGKYJEI//J83f/kzuQ/W8uFVIDpiiGiA ddqOkZu4sRXlqeokTxDLJQB6WHUsw84S+1dj3uBVxnTbgQIV+qsDAak9VCElUWozaZiF bIxutLwLCyD4W5aiIZ/LeGjSY+adrjHGwE81XZ/4X7xJWPIn4708kEV9Lw4HlO98kzNT OB2oLMhswwy5XhmAasRTKmtQBwjjqkyHkO06K7YKWjSlNTQZTWPFSUi8bHC1but6Wv1Y +K1A== X-Gm-Message-State: APjAAAUlIAqERr+2BO6cMMHk5ROfGkKWCyOpd8NXH08n9RTmEs/3m+M6 Hj1EnnODbwG2Z4XrrD75bZj/kQ== X-Google-Smtp-Source: APXvYqw4j6hTmVmZuCM6p4mATrhPkapTKuiS1KCUkIC3fAwdzYMk4Kr6+Cer0ua5Q/XhE1FcUrmhaw== X-Received: by 2002:a7b:c3d7:: with SMTP id t23mr4335187wmj.94.1564749332124; Fri, 02 Aug 2019 05:35:32 -0700 (PDT) Received: from hex (5751f4a1.skybroadband.com. [87.81.244.161]) by smtp.gmail.com with ESMTPSA id k124sm126630532wmk.47.2019.08.02.05.35.31 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 02 Aug 2019 05:35:31 -0700 (PDT) Message-ID: From: Richard Purdie To: liu.ming50@gmail.com, openembedded-core@lists.openembedded.org Date: Fri, 02 Aug 2019 13:35:30 +0100 In-Reply-To: <1564737163-4640-1-git-send-email-liu.ming50@gmail.com> References: <1564737163-4640-1-git-send-email-liu.ming50@gmail.com> User-Agent: Evolution 3.32.2-1 MIME-Version: 1.0 Cc: marcel.ziswiler@toradex.com, Ming Liu , stefan.agner@toradex.com Subject: Re: [PATCH] image.bbclass: exclude deploy-${PN}-image-complete from rm_work X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Aug 2019 12:35:31 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2019-08-02 at 17:12 +0800, liu.ming50@gmail.com wrote: > From: Ming Liu > > The results in ${IMGDEPLOYDIR} generated by a image task could be > used by later image tasks. No they shouldn't. > , hence they should be excluded by rm_work. Or else when a image task > gets rerun but one of its dependent image task does not, then the > results generated by this dependent image task would not be there in > ${IMGDEPLOYDIR}. Nothing should be poking into IMGDEPLOYDIR outside of the image tasks. do_image_complete[sstate-inputdirs] = "${IMGDEPLOYDIR}" do_image_complete[sstate-outputdirs] = "${DEPLOY_DIR_IMAGE}" anything else should be after do_image_complete and be referencing DEPLOY_DIR_IMAGE. Cheers, Richard