From: Tvrtko Ursulin Subject: Re: [PATCH v3] drm/i915: Cleanup i915_gem_request_add_to_client Date: Thu, 29 Sep 2016 09:13:16 +0100 Message-ID: References: <20160928170930.GA28107@nuc-i3427.alporthouse.com> <1475135611-18548-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20160929080819.GD28107@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 573A86E596 for ; Thu, 29 Sep 2016 08:13:19 +0000 (UTC) In-Reply-To: <20160929080819.GD28107@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI5LzA5LzIwMTYgMDk6MDgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBUaHUsIFNlcCAy OSwgMjAxNiBhdCAwODo1MzozMUFNICswMTAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4gRnJv bTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4KPj4gU2V2ZXJh bCB0aGluZ3Mgd2UgY2FuIGNsZWFuIHVwIGluIHRoaXMgZnVuY3Rpb246Cj4+Cj4+ICAgKiBSZXF1 ZXN0IGFuZCBmaWxlIHBhc3NlZCBpbiBjYW5ub3QgYmUgTlVMTC4gVGhlcmUgaXMKPj4gICAgIGEg c2luZ2xlIGNhbGxlciB3aGljaCBtYWtlcyBpdCBpbXBvc3NpYmxlIHNvIGNoYW5nZQo+PiAgICAg dGhhdCBjb25kaXRpb24gdG8gYSBHRU1fQlVHX09OIGluc3RlYWQgb2YgYSBXQVJOCj4+ICAgICB3 aXRoIGEgcmV0dXJuIGNvZGUuCj4+Cj4+ICAgKiBTYW1lIGlzIHRydWUgZm9yIHJlcS0+ZmlsZV9w cml2IHdoaWNoIGlzIGFsd2F5cwo+PiAgICAgemVyb2VkIGJlZm9yZSB0aGlzIGZ1bmN0aW9uIGlz IGNhbGxlZC4KPj4KPj4gICAqIFdpdGggdGhlIGFib3ZlIHdlIGNhbiByZW1vdmUgdGhlIGVycm9y IHJldHVybgo+PiAgICAgZnJvbSB0aGUgZnVuY3Rpb24gbWFraW5nIGl0IHZvaWQuCj4+Cj4+ICAg KiBkZXZfcHJpdmF0ZSBsb2NhbCB2YXJpYWJsZSB3YXMgdW51c2VkLgo+Pgo+PiAgICogQ2FsbCBz aXRlIGluIGk5MTVfZ2VtX2RvX2V4ZWNidWZmZXIgY2FuIGJlCj4+ICAgICBzaW1wbGlmaWVkIHNp bmNlIHRoZXJlIGlzIG5vIGVycm9yIGhhbmRsaW5nIGFueQo+PiAgICAgbG9uZ2VyLgo+Pgo+PiB2 MjoKPj4gICAqIE1vdmUgbmV4dCB0byB0aGUgb25seSBjYWxsZXIuIChDaHJpcyBXaWxzb24pCj4+ ICAgKiBSZW1vdmUgdXNlbGVzcyBhc3NlcnRzLiAoSm9vbmFzIExhaHRpbmVuKQo+Pgo+PiB2MzoK Pj4gICAqIFNob3J0ZW4gbmFtZSwgcmVtb3ZlIGxhc3Qgc3RhbmRpbmcgYXNzZXJ0IGFuZAo+PiAg ICAgZml4IGZsdXNoaW5nIGFmdGVyIGZhaWxlZCBzdWJtaXQuIChDaHJpcyBXaWxzb24pCj4+Cj4+ IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+ Cj4+IFJldmlld2VkLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5p bnRlbC5jb20+ICh2MSkKPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f ZXhlY2J1ZmZlci5jIHwgMTYgKysrKysrKysrKysrLS0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyAgICB8IDI1IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmggICAgfCAgMiAtLQo+ PiAgIDMgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMzEgZGVsZXRpb25zKC0pCj4+ Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVy LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPj4gaW5kZXgg MzNjODUyMjc2NDNkLi5mN2I5NjM5MWZmNjYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPj4gQEAgLTE2MTIsNiArMTYxMiwxNyBAQCBlYl9zZWxl Y3RfZW5naW5lKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gICAJcmV0dXJu IGVuZ2luZTsKPj4gICB9Cj4+ICAgCj4+ICtzdGF0aWMgdm9pZAo+PiArYWRkX3RvX2NsaWVudChz dHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwgc3RydWN0IGRybV9maWxlICpmaWxlKQo+ PiArewo+PiArCXN0cnVjdCBkcm1faTkxNV9maWxlX3ByaXZhdGUgKmZpbGVfcHJpdiA9IGZpbGUt PmRyaXZlcl9wcml2Owo+PiArCj4+ICsJc3Bpbl9sb2NrKCZmaWxlX3ByaXYtPm1tLmxvY2spOwo+ PiArCXJlcS0+ZmlsZV9wcml2ID0gZmlsZV9wcml2Owo+PiArCWxpc3RfYWRkX3RhaWwoJnJlcS0+ Y2xpZW50X2xpc3QsICZmaWxlX3ByaXYtPm1tLnJlcXVlc3RfbGlzdCk7Cj4+ICsJc3Bpbl91bmxv Y2soJmZpbGVfcHJpdi0+bW0ubG9jayk7Cj4+ICt9Cj4+ICsKPj4gICBzdGF0aWMgaW50Cj4+ICAg aTkxNV9nZW1fZG9fZXhlY2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRh LAo+PiAgIAkJICAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPj4gQEAgLTE4MjQsOSArMTgz NSw3IEBAIGk5MTVfZ2VtX2RvX2V4ZWNidWZmZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9p ZCAqZGF0YSwKPj4gICAJICovCj4+ICAgCXBhcmFtcy0+cmVxdWVzdC0+YmF0Y2ggPSBwYXJhbXMt PmJhdGNoOwo+PiAgIAo+PiAtCXJldCA9IGk5MTVfZ2VtX3JlcXVlc3RfYWRkX3RvX2NsaWVudChw YXJhbXMtPnJlcXVlc3QsIGZpbGUpOwo+PiAtCWlmIChyZXQpCj4+IC0JCWdvdG8gZXJyX3JlcXVl c3Q7Cj4+ICsJYWRkX3RvX2NsaWVudChwYXJhbXMtPnJlcXVlc3QsIGZpbGUpOwo+IFNvIHdlIGFk ZCB0byB0aGUgY2xpZW50IGxpc3QgZXZlbiBpZiB3ZSBmYWlsIHRvIHN1Ym1pdCB0aGUgYmF0Y2g/ IEZvcgo+IHRoYXQgcmVhc29uIEkgcHV0IHRoZSBjYWxsIHRvIGFkZF90b19jbGllbnQoKSBpbiBl eGVjYnVmX3N1Ym1pdC4KClNhbWUgYXMgZXhpc3RpbmcgY29kZSwgdGhhdCB3YXMganVzdCB0cmlt bWluZyB0aGUgdXNlbGVzcyBiaXRzLgoKSWYgeW91IGFyZSByZXdvcmtpbmcgYWxsIHRoaXMgc2hv cnRseSBsZXRzIGRyb3AgdGhpcyB0aGVuLgoKUmVnYXJkcywKClR2cnRrbwoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==