Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 224ACC43603 for ; Thu, 19 Dec 2019 12:48:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F08C8206D7 for ; Thu, 19 Dec 2019 12:48:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F08C8206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF4C26EB60; Thu, 19 Dec 2019 12:48:03 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 064F16EB60 for ; Thu, 19 Dec 2019 12:48:01 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2019 04:48:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,331,1571727600"; d="scan'208";a="390524285" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga005.jf.intel.com with ESMTP; 19 Dec 2019 04:48:00 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.130]) by IRSMSX154.ger.corp.intel.com ([169.254.12.207]) with mapi id 14.03.0439.000; Thu, 19 Dec 2019 12:47:59 +0000 From: "Kahola, Mika" To: "intel-gfx@lists.freedesktop.org" , "Deak, Imre" Thread-Topic: [Intel-gfx] [PATCH 07/15] drm/i915/tgl: Make sure FBs have a correct CCS plane stride Thread-Index: AQHVtb3jBMZRD3L+nEaNCvbKCUhqyKfBaZmA Date: Thu, 19 Dec 2019 12:47:59 +0000 Message-ID: References: <20191218161105.30638-1-imre.deak@intel.com> <20191218161105.30638-8-imre.deak@intel.com> In-Reply-To: <20191218161105.30638-8-imre.deak@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.72.159] Content-ID: MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 07/15] drm/i915/tgl: Make sure FBs have a correct CCS plane stride X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Pandiyan, Dhinakaran" Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 2019-12-18 at 18:10 +0200, Imre Deak wrote: > The CCS plane stride must be fixed on TGL, as it's not configurable > for > the display. Instead the HW has a hardwired logic to determine it > from > the main plane stride. Make sure userspace passes in the correct > stride. > = > Cc: Dhinakaran Pandiyan > Cc: Ville Syrj=E4l=E4 > Signed-off-by: Imre Deak Reviewed-by: Mika Kahola > --- > drivers/gpu/drm/i915/display/intel_display.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > b/drivers/gpu/drm/i915/display/intel_display.c > index 641ea24539eb..7c52591172e1 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -2620,6 +2620,11 @@ bool is_ccs_modifier(u64 modifier) > modifier =3D=3D I915_FORMAT_MOD_Yf_TILED_CCS; > } > = > +static int gen12_ccs_aux_stride(struct drm_framebuffer *fb, int > ccs_plane) > +{ > + return DIV_ROUND_UP(fb->pitches[ccs_to_main_plane(fb, > ccs_plane)], 512) * 64; > +} > + > u32 intel_plane_fb_max_stride(struct drm_i915_private *dev_priv, > u32 pixel_format, u64 modifier) > { > @@ -16530,6 +16535,16 @@ static int intel_framebuffer_init(struct > intel_framebuffer *intel_fb, > goto err; > } > = > + if (is_gen12_ccs_plane(fb, i)) { > + int ccs_aux_stride =3D gen12_ccs_aux_stride(fb, > i); > + > + if (fb->pitches[i] !=3D ccs_aux_stride) { > + DRM_DEBUG_KMS("ccs aux plane %d pitch > (%d) must be %d\n", > + i, fb->pitches[i], > ccs_aux_stride); > + goto err; > + } > + } > + > fb->obj[i] =3D &obj->base; > } > = _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx