From: "plaisthos (Code Review)"
Date: Tue, 31 Mar 2026 16:35:27 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="HaDKVJdmGG0="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Rename key* to
privkey* in cert_data.h
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , openvpn-devel
--HaDKVJdmGG0=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change by plaisthos. ( http://gerrit.=
openvpn.net/c/openvpn/+/1597?usp=3Demail )
Change subject: Rename key* to privkey* in cert_data.h
......................................................................
Patch Set 1:
(1 comment)
File tests/unit_tests/openvpn/test_pkcs11.c:
http://gerrit.openvpn.net/c/openvpn/+/1597/comment/788d1766_02773756?usp=3D=
email :
PS1, Line 145: { cert1, key1, cname1, "OVPN TEST CA1", "OVPN Test C=
ert 1", { 0 }, NULL },
> what is going on here? Why do we only change one name?
When you trust your IDE to do the rename and only build the test you are wo=
rking on. This will now fail the build because of that. Will upload a new v=
ersion.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1597?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id8680e6555a66024417d6eb9322d4fde79922453
Gerrit-Change-Number: 1597
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos
Gerrit-CC: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Tue, 31 Mar 2026 16:35:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
--HaDKVJdmGG0=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: flichtenheld.
Patch Set #1, Line 145: { cert1, key1, cname1, "OVPN TEST CA1", "OVPN T=
est Cert 1", { 0 }, NULL },
what is going on her=
e? Why do we only change one name?
When you trust your IDE=
to do the rename and only build the test you are working on. This will now=
fail the build because of that. Will upload a new version.
=
li>
To view, visit change 1597. To unsubscribe, or for help writing mail=
filters, visit =
settings.