From: "flichtenheld (Code Review)" Date: Wed, 21 Jan 2026 14:30:01 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="EGGS92ykTfI="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: manage: Do not trigger actions on management disconnect if not authen... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --EGGS92ykTfI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1484?usp=3Demail to review the following change. Change subject: manage: Do not trigger actions on management disconnect if = not authenticated ...................................................................... manage: Do not trigger actions on management disconnect if not authenticated If the management interface requires authentication via password and the remote did not specify it, do not do trigger actions requested by --management-forget-disconnect and --management-signal on disconnect. Reported-By: Joshua Rogers Found-By: ZeroPath (https://zeropath.com) Github: openvpn-private-issues#5 Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af Signed-off-by: Frank Lichtenheld --- M src/openvpn/manage.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/84/1484/1 diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 8fa8784..37ae6b3 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -2073,13 +2073,14 @@ } if (!exiting) { - if (man->settings.flags & MF_FORGET_DISCONNECT) + if (man->settings.flags & MF_FORGET_DISCONNECT && !man_password_ne= eded(man)) { + msg(D_MANAGEMENT, "MANAGEMENT: Reset authentication on disconn= ect"); ssl_purge_auth(false); (void)ssl_clean_auth_token(); } - if (man->settings.flags & MF_SIGNAL) + if (man->settings.flags & MF_SIGNAL && !man_password_needed(man)) { int mysig =3D man_mod_signal(man, SIGUSR1); if (mysig >=3D 0) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1484?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af Gerrit-Change-Number: 1484 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --EGGS92ykTfI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

manage: Do not trigger actions on managemen=
t disconnect if not authenticated

If the management interface requir= es authentication via password
and the remote did not specify it, do not= do trigger actions
requested by --management-forget-disconnect and --ma= nagement-signal
on disconnect.

Reported-By: Joshua Rogers <con= tact@...2949...>
Found-By: ZeroPath (https://zeropath.com)
Github:= openvpn-private-issues#5
Change-Id: I575d65912ce9065a0b0868e73998b4a9ae= ce62af
Signed-off-by: Frank Lichtenheld <frank@...2641...>
---<= br>M src/openvpn/manage.c
1 file changed, 3 insertions(+), 2 deletions(-= )

git pull ssh://gerrit.openvpn.net:29418/openvp=
n refs/changes/84/1484/1
diff --git a/src/openvpn/manage.c b/src/op=
envpn/manage.c
index 8fa8784..37ae6b3 100644
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -2073,13 +2073,14 @@
}
if (!exiting)

{
- if (man->settings.flags & MF_FORGET_DIS= CONNECT)
+ if = (man->settings.flags & MF_FORGET_DISCONNECT && !man_password= _needed(man))
{
+ msg(D_MANAGEMENT, "MANAGEMENT: Reset = authentication on disconnect");
ssl_purge= _auth(false);
(void)ssl_clean_auth_token();
}

- if (man->settings.flags & MF_SIGNAL)
+ if (man->se= ttings.flags & MF_SIGNAL && !man_password_needed(man)) {
int mysig =3D man_mod_signa= l(man, SIGUSR1);
if (mysig >=3D 0)

To view, visit change 1484. To unsubscribe, or for = help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I575d65912ce9065a0b0868e7399= 8b4a9aece62af
Gerrit-Change-Number: 1484
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --EGGS92ykTfI=--