Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E1022CA5 for ; Tue, 7 Mar 2023 09:51:30 +0000 (UTC) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C39856602FE5; Tue, 7 Mar 2023 09:51:27 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678182688; bh=vkkFYd3loRrOSSOnY088flgwXtY2fsz3MI2px8MiqHQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FvjkZSoKncFHS3NEPw0+fU1qd1+2i3EiXrC6U9A1GQ+9sb9zw2STaKQRZaLD63ii0 Zff6jfIyfc7M3vzAkM0UtGpuFYeDkRWxH6Dn8UwkRadngbfhh0sxFJK9gWWURrp7Ws 5hOABq0FmfjP1t19KBgpd5Eym35qs3J9xT9zJSgvKwztrdQQTAKn6u2NDA1tuuea3G x/g55xmr8/N9BgmPqUZOpE9AZ/r/wsbrSPRr+qt6TlwI8IvdTtiY/jcn28jX3At/zS 6euu71DP9uXJuT3uKiN2VHx3s+tJhKwQjVu6KFZ7fomQeQugkXe2RLr738NfeV36EX s1C1e7kFrsVQA== Message-ID: Date: Tue, 7 Mar 2023 10:51:25 +0100 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v8 1/7] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU Content-Language: en-US To: Yong Wu , Joerg Roedel , Will Deacon , Rob Herring , Matthias Brugger Cc: Robin Murphy , Krzysztof Kozlowski , iommu@lists.linux.dev, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mingyuan.ma@mediatek.com, yf.wang@mediatek.com, jianjiao.zeng@mediatek.com, chengci.xu@mediatek.com, youlin.pei@mediatek.com, Krzysztof Kozlowski References: <20230307080555.14399-1-yong.wu@mediatek.com> <20230307080555.14399-2-yong.wu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230307080555.14399-2-yong.wu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 07/03/23 09:05, Yong Wu ha scritto: > From: "Chengci.Xu" > > Add descriptions for mt8188 IOMMU which also use ARM Short-Descriptor > translation table format. > > In mt8188, there are two smi-common HW and IOMMU, one is for vdo(video > output), the other is for vpp(video processing pipe). They connects > with different smi-larbs, then some setting(larbid_remap) is different. > Differentiate them with the compatible string. > > Something like this: > > IOMMU(VDO) IOMMU(VPP) > | | > SMI_COMMON_VDO SMI_COMMON_VPP > > --------------- ---------------- > | | ... | | ... > larb0 larb2 ... larb1 larb3 ... > > We also have an IOMMU that is for infra master like PCIe. > And infra master don't have the larb and ports. > > Signed-off-by: Chengci.Xu > Reviewed-by: Yong Wu > Acked-by: Krzysztof Kozlowski Yong, if you're sending someone else's patch, you have to add your own signoff tag, otherwise it's not going to be accepted. With that fixed: Reviewed-by: AngeloGioacchino Del Regno