Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5DB9C433F5 for ; Tue, 8 Feb 2022 23:38:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 43EB683E05; Wed, 9 Feb 2022 00:38:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="o9ThIClu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2D82983E14; Wed, 9 Feb 2022 00:38:08 +0100 (CET) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A182583E05 for ; Wed, 9 Feb 2022 00:38:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20220208233759epoutp02ec441d766a260640b7d94ea573baedde~R899eMjKw2071020710epoutp02J for ; Tue, 8 Feb 2022 23:37:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20220208233759epoutp02ec441d766a260640b7d94ea573baedde~R899eMjKw2071020710epoutp02J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1644363479; bh=c+3ZUfEYd/TiYsk0eJjA6nHOlCRwLM4+5dukY+wdADs=; h=Date:Subject:From:To:Cc:In-Reply-To:References:From; b=o9ThICluH7vMG3bUFjWoDXgZZ+XmAOK0GwCwN0nsWFizPqPtaWUrg+elrluCDfZTi O4GtgMfESSt8atfgpzFRHORkznhjPen21/WZgzD7sDU27/ZwJbDPj3uajDo/8OwATB YXGvZZ1QUXiBcMnbC81SIAaBMJssSozI8SA77+W4= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20220208233759epcas1p12b1c8d3b5e3f2b2f8e398c461cc2ee07~R899RZOPh0405604056epcas1p1b; Tue, 8 Feb 2022 23:37:59 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.36.134]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4JtfZT0hTVz4x9Q8; Tue, 8 Feb 2022 23:37:53 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id A5.1E.21932.CCEF2026; Wed, 9 Feb 2022 08:37:48 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20220208233748epcas1p3f282eb6aa15d24fd0ea60060bb9fd4b3~R89yxMt9O1308013080epcas1p39; Tue, 8 Feb 2022 23:37:48 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220208233748epsmtrp2147002cc467b3961130378c9bc30b517~R89ywl7jS2080320803epsmtrp2y; Tue, 8 Feb 2022 23:37:48 +0000 (GMT) X-AuditID: b6c32a38-93fff700000255ac-a1-6202feccfa80 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 25.B0.29871.CCEF2026; Wed, 9 Feb 2022 08:37:48 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220208233747epsmtip108dcf03092ffef61bf88eca2a5314564~R89yaBGbJ0427204272epsmtip1B; Tue, 8 Feb 2022 23:37:47 +0000 (GMT) Message-ID: Date: Wed, 9 Feb 2022 08:38:39 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] cmd: mmc: Consider GP partitions in mmc hwpartition user enh start - Content-Language: en-US From: Jaehoon Chung To: Marek Vasut , u-boot@lists.denx.de Cc: Fabio Estevam , Peng Fan , Stefano Babic In-Reply-To: <68e5a925-7ee6-f621-3545-a2d9c8dd0d58@samsung.com> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgk+LIzCtJLcpLzFFi42LZdlhTX/fMP6YkgytTxCweXvW3eNPWyGjx Y9UXVov2Uz4Wb/d2sjuwesybdYLFY+esu+weZ+/sYPTY+G4HUwBLVLZNRmpiSmqRQmpecn5K Zl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBaJYWyxJxSoFBAYnGxkr6dTVF+ aUmqQkZ+cYmtUmpBSk6BaYFecWJucWleul5eaomVoYGBkSlQYUJ2xtPl/9gK1ktX/P/WztLA uFeki5GTQ0LARGLytqlMXYxcHEICOxgltj7ewArhfGKUmHPvMJTzjVGi+f1mdpiWhj2TWSAS exklPuy5wg7hvGeU2PHgMlgVr4CdxMpZW5hBbBYBFYkP/XMZIeKCEidnPmEBsUUFIiReHvkL tJyDQ1ggWuL5XjaQMLOAuMStJ/OZQGw2AR2J7d+Og9kiAqYSa2ctZoKoSZWY0w4xnlPAXqJj +0SoXnmJ7W/nMIPcIyHwkV3i4rufLBBXu0hcfrMQ6gNhiVfHt0DZUhKf34EsBmloZpRYuuQg K4TTwyjxr+E6G0SVscT+pZPBLmUW0JRYv0sfIqwosfM3xGPMAnwS7772sIKUSAjwSnS0CUGU qEhcev2SCWbX3Sf/oUo8JP7eLZ7AqDgLKVRmIXl/FpJ3ZiHsXcDIsopRLLWgODc9tdiwwAQe 28n5uZsYwUlSy2IH49y3H/QOMTJxMB5ilOBgVhLhlen+nyjEm5JYWZValB9fVJqTWnyI0RQY NxOZpUST84FpOq8k3tDE0sDEzMjYxMLQzFBJnLd36ulEIYH0xJLU7NTUgtQimD4mDk6pBqbw tRzTbjRxRF3e/O69UlTTp3vWhWrqKiJLnstPfqQiOc/G43nKV71tV7xvX07aXp9x+KXqrL9X Hm00+nl0UcWuWzed7wumJrbPC/Jvfc84NXft9Aln7lc0KtvMY+hctfxQzJ60E8dPnyq33XF6 s3R3n84ltkndaxfaeHXdaa/5v0vm3qMdAl8eOSjJrBYPsL7to+w59/2HTzX8tl+cV00Rm7Z+ QXlV+lYuc5+GGQdM93r+/OAvZWJ8tSNh49sTTwx/apW+T1+49bFbW+XnlLz+SCsV3Z76lk9C TNO/BwlJX/Eu2V82Mf7Yp4WW8jZvY++1796QqFKa9fRc0FvXP6klmrOcy3QPSxTOECm7vWey EktxRqKhFnNRcSIA9Cf1RRsEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsWy7bCSnO6Zf0xJBtMns1o8vOpv8aatkdHi x6ovrBbtp3ws3u7tZHdg9Zg36wSLx85Zd9k9zt7Zweix8d0OpgCWKC6blNSczLLUIn27BK6M p8v/sRWsl674/62dpYFxr0gXIyeHhICJRMOeySwgtpDAbkaJKze4IOJSEp+fTmXrYuQAsoUl Dh8u7mLkAip5yygxbdVZsHpeATuJlbO2MIPYLAIqEh/65zJCxAUlTs58AlYjKhAh0bZsCliN sEC0xJbN78HizALiEreezGcCsdkEdCS2fzsOZosImEqsnbWYCaImVeLd8XZGuNs2Ts0AsTkF 7CU6tk8Eu41ZQF1i/TwhiHJ5ie1v5zBPYBSaheSKWUi2zULomIWkYwEjyypGydSC4tz03GLD AsO81HK94sTc4tK8dL3k/NxNjOB40NLcwbh91Qe9Q4xMHIyHGCU4mJVEeGW6/ycK8aYkVlal FuXHF5XmpBYfYpTmYFES573QdTJeSCA9sSQ1OzW1ILUIJsvEwSnVwMQttuyZyP+v5+eHGSvW xPA/6H2+6vhMVvnv+40e+c5ctOqpg5HFC/30i0JlBRvV9sr7W/GqhKw1M5qwpcHn4GH1F+0W cQdDy7erO3R986ucdvyr38KjTCW79pzcmsZz+52c/MQ9i24ukL/yM2aZWvG5HLFt3tK+PzN8 FilMjpv58PLktyGHb189UfC4ZrmwuPXWZpklXnfYHnuWGX6fJz7/3Ia9Vy5dFmPp22C7sXeZ 6znRaPf0ygI3nn0nneLMZt7+kRW11spy+bqYSY8XXGKMudLfmqb1KfXL83tTqxxtj51q3rjx 8Ic0G03Hd0G9wmkfzzy57bvuaMJBN4/oRetK/ywNe3ssaJdtRY3X5AtLlFiKMxINtZiLihMB R3M7o/YCAAA= X-CMS-MailID: 20220208233748epcas1p3f282eb6aa15d24fd0ea60060bb9fd4b3 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220117215450epcas1p3d59b43cdda488e463c1c9933135ef084 References: <20220117215429.88037-1-marex@denx.de> <68e5a925-7ee6-f621-3545-a2d9c8dd0d58@samsung.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 1/27/22 08:16, Jaehoon Chung wrote: > On 1/18/22 06:54, Marek Vasut wrote: >> In case the eMMC contains any GP partitions or user sets up new GP >> partitions, the size of these GP partitions reduce the size of the >> USER partition. Subtract the size of those GP partitions from the >> calculated size of USER partition when using `user enh start -`. >> >> The following test used to fail before: >> ``` >> u-boot=> mmc hwpartition gp1 524288 enh user enh 0 - wrrel on check >> Partition configuration: >> User Enhanced Start: 0 Bytes >> User Enhanced Size: 1.8 GiB >> User partition write reliability: on >> GP1 Capacity: 256 MiB ENH >> No GP2 partition >> No GP3 partition >> No GP4 partition >> Total enhanced size exceeds maximum (261 > 229) >> Failed! >> ``` >> The test now passes: >> ``` >> u-boot=> mmc hwpartition gp1 524288 enh user enh 0 - wrrel on check >> Partition configuration: >> User Enhanced Start: 0 Bytes >> User Enhanced Size: 1.5 GiB >> User partition write reliability: on >> GP1 Capacity: 256 MiB ENH >> No GP2 partition >> No GP3 partition >> No GP4 partition >> ``` >> >> Signed-off-by: Marek Vasut >> Cc: Fabio Estevam >> Cc: Jaehoon Chung >> Cc: Peng Fan >> Cc: Stefano Babic > > Reviewed-by: Jaehoon Chung Applied on u-boot-mmc/master. Thanks! Best Regards, Jaehoon Chung > > Best Regards, > Jaehoon Chung > >> --- >> cmd/mmc.c | 22 ++++++++++++++++++++-- >> 1 file changed, 20 insertions(+), 2 deletions(-) >> >> diff --git a/cmd/mmc.c b/cmd/mmc.c >> index 96d81ffdf36..503dbb6199c 100644 >> --- a/cmd/mmc.c >> +++ b/cmd/mmc.c >> @@ -597,7 +597,7 @@ static void parse_hwpart_user_enh_size(struct mmc *mmc, >> struct mmc_hwpart_conf *pconf, >> char *argv) >> { >> - int ret; >> + int i, ret; >> >> pconf->user.enh_size = 0; >> >> @@ -606,7 +606,7 @@ static void parse_hwpart_user_enh_size(struct mmc *mmc, >> ret = mmc_send_ext_csd(mmc, ext_csd); >> if (ret) >> return; >> - /* This value is in 512B block units */ >> + /* The enh_size value is in 512B block units */ >> pconf->user.enh_size = >> ((ext_csd[EXT_CSD_MAX_ENH_SIZE_MULT + 2] << 16) + >> (ext_csd[EXT_CSD_MAX_ENH_SIZE_MULT + 1] << 8) + >> @@ -614,6 +614,24 @@ static void parse_hwpart_user_enh_size(struct mmc *mmc, >> ext_csd[EXT_CSD_HC_ERASE_GRP_SIZE] * >> ext_csd[EXT_CSD_HC_WP_GRP_SIZE]; >> pconf->user.enh_size -= pconf->user.enh_start; >> + for (i = 0; i < ARRAY_SIZE(mmc->capacity_gp); i++) { >> + /* >> + * If the eMMC already has GP partitions set, >> + * subtract their size from the maximum USER >> + * partition size. >> + * >> + * Else, if the command was used to configure new >> + * GP partitions, subtract their size from maximum >> + * USER partition size. >> + */ >> + if (mmc->capacity_gp[i]) { >> + /* The capacity_gp is in 1B units */ >> + pconf->user.enh_size -= mmc->capacity_gp[i] >> 9; >> + } else if (pconf->gp_part[i].size) { >> + /* The gp_part[].size is in 512B units */ >> + pconf->user.enh_size -= pconf->gp_part[i].size; >> + } >> + } >> } else { >> pconf->user.enh_size = dectoul(argv, NULL); >> } > >