From: "its_Giaan (Code Review)" Date: Wed, 13 Mar 2024 08:38:05 +0000 In-Reply-To: References: Reply-To: gianmarco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="+oR3H6+SbNQ="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , plaisthos , openvpn-devel --+oR3H6+SbNQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/524?usp=3Demail ) Change subject: Route: add support for user defined routing table ...................................................................... Patch Set 3: (7 comments) File doc/man-sections/vpn-network-options.rst: http://gerrit.openvpn.net/c/openvpn/+/524/comment/28a9b0d7_797a7b8f : PS3, Line 374: a user defined routing table can be used instead. > "an user" Since "user" begins with a consonant sound "y" (as in "you"), "a" is the ap= propriate article to use. You would say "a unicorn" instead of "an unicorn"= imho. http://gerrit.openvpn.net/c/openvpn/+/524/comment/fc3149bd_56ee7cdc : PS3, Line 407: Since this option must be an entirely local choice, = won't be pushable. > Time seems weird to me, would change to "it isn't pushable" Done http://gerrit.openvpn.net/c/openvpn/+/524/comment/293941ea_2c34e0eb : PS3, Line 408: default taken from ``--route-table`` if set, otherwis= e :code:`0`. > please change tab to space Done http://gerrit.openvpn.net/c/openvpn/+/524/comment/d10bebfd_142729b1 : PS3, Line 461: route-ipv6 ipv6addr/bits [gateway] > when listing all possible choices, you can leave off the "[" optional mar= kers Done http://gerrit.openvpn.net/c/openvpn/+/524/comment/a4df0975_2ea65b9f : PS3, Line 464: > trailing whitespace Done http://gerrit.openvpn.net/c/openvpn/+/524/comment/1d25817b_bf7cb0e6 : PS3, Line 475: default taken from ``--route-table`` if set, otherwis= e :code:`0`. > same comments apply here as for --route (tab, won't->it isn't) Done File src/openvpn/route.h: http://gerrit.openvpn.net/c/openvpn/+/524/comment/4897ce61_2c46962d : PS3, Line 98: > spurious whitespace? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7 Gerrit-Change-Number: 524 Gerrit-PatchSet: 3 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 13 Mar 2024 08:38:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --+oR3H6+SbNQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

7 comments:

    =
  • File doc/man-sections/vpn-network-o= ptions.rst:

    • Patch S= et #3, Line 374: a us= er defined routing table can be used instead.

      "a= n user"

      Since "user" begins with a consonant sound "y&q= uot; (as in "you"), "a" is the appropriate article to u= se. You would say "a unicorn" instead of "an unicorn" i= mho.

    • Patch Set #3, Line 407: Since this option must be an entirely local = choice, won't be pushable.

      Time seems weird to me= , would change to "it isn't pushable"

      Done

    • = Patch Set #3, Line 408: default taken from ``--route-table`` if set, otherwise :code:`0`.

      please change tab to space

      Done

    • Patch= Set #3, Line 461: = route-ipv6 ipv6addr/bits [gateway]

      when listing all = possible choices, you can leave off the "[" optional markers

      Done=

    • Patch Set #3, Line 464:

      trailing whitespace

      Done

    • Patch Set #3, Line 475: default taken from ``--route-table`` if set, otherwise := code:`0`.

      same comments apply here as for --route (ta= b, won't->it isn't)

      Done

  • File src/openvpn/route.h:

To view, visit change 524. To unsubscribe, or for help= writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede56= 17ee98bf218a7
Gerrit-Change-Number: 524
Gerrit-PatchSet: 3
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 13 Mar 2024 08:38:05= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--+oR3H6+SbNQ=--