From: "flichtenheld (Code Review)" Date: Tue, 28 Nov 2023 11:21:56 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="rM/x/nVJPxI="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --rM/x/nVJPxI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/460?usp=3Demail ) Change subject: Check PRF availability on initialisation and add --force-tl= s-key-material-export ...................................................................... Patch Set 1: Code-Review-2 (2 comments) File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/2a674c0e_9a4fdc16 : PS1, Line 1797: * limits our compatibility to other 2.6.x+ OpernVPN pe= ers. Do a simple "OpenVPN" File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/d4124e62_ecf20def : PS1, Line 2583: if (options->force_key_material_export) This is in "if (options->mode =3D=3D MODE_SERVER)" which is wrong. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee6ca89c7e86c70 Gerrit-Change-Number: 460 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Tue, 28 Nov 2023 11:21:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --rM/x/nVJPxI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 1:Code-Review -2=

Vi= ew Change

2 comments:

  • File src/openvpn/crypto.c:

    <= ul style=3D"list-style: none; padding: 0;">
  • Patch Set #1, Line 1797= : * limits our com= patibility to other 2.6.x+ OpernVPN peers. Do a simple

    "OpenVPN"

    <= /li>
  • File src/openvpn/opti= ons.c:

    • Patch Set #1= , Line 2583: if= (options->force_key_material_export)

      This is in "if (options->mode = =3D=3D MODE_SERVER)" which is wrong.

  • To view= , visit c= hange 460. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee= 6ca89c7e86c70
    Gerrit-Change-Number: 460
    Gerrit-PatchSet: 1
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Comment-Date: Tue, 28 Nov 2023 11:21:56= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --rM/x/nVJPxI=--