Message-ID: Date: Thu, 6 Oct 2022 15:05:08 +0200 MIME-Version: 1.0 Content-Language: en-GB References: <20220923085804.3743109-1-arne@...1227...> From: Arne Schwabe In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH] Document/cleanup event_timeout functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Frank Lichtenheld Cc: openvpn-devel@lists.sourceforge.net Am 23.09.22 um 12:12 schrieb Frank Lichtenheld: > >> bool event_timeout_trigger(struct event_timeout *et, >> struct timeval *tv, >> - const int et_const_retry); >> + int et_const_retry); > > Why remove the const here? You did not remove it in interval.c clang-tidy complains here. The reason is that the const is doing nothing in the prototype: Clang-Tidy: Parameter 'et_const_retry' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions. Arne