Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MDlnK-0005FE-Mx for mharc-grub-devel@gnu.org; Mon, 08 Jun 2009 16:50:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDlnI-0005Eo-I8 for grub-devel@gnu.org; Mon, 08 Jun 2009 16:50:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDlnE-0005CC-5b for grub-devel@gnu.org; Mon, 08 Jun 2009 16:50:12 -0400 Received: from [199.232.76.173] (port=46498 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDlnD-0005C9-RY for grub-devel@gnu.org; Mon, 08 Jun 2009 16:50:07 -0400 Received: from mail-fx0-f217.google.com ([209.85.220.217]:43446) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MDlnD-0007iv-Dv for grub-devel@gnu.org; Mon, 08 Jun 2009 16:50:07 -0400 Received: by fxm17 with SMTP id 17so1198080fxm.42 for ; Mon, 08 Jun 2009 13:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=x39Z0FQZSz7ecYsufYRPFb+t2lUCGkivQgmlwNg89oA=; b=WQEp+/CtihcVNHD3j92hkzHPVerACB9bXqxiNo/Xx2zpC5PPr/NFX6NtT/GBrq0Uz0 NfUnjkQ4v3EQ0Wxx0R9wNK3/9mMgCDywQc28AJfOCv0jm5i9S+rJrEdM7uD+RJOp+Sh5 DTKzeKV7xdj8TUtsc3/HoaRyx4Qc+/k89Cxzw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=HYuwLlIC9e2x1dpLDtbFlEpAZrVa//g9jIVuHQsvtaoKglp9ekxYfEMzi+XkQniT0Q hoS90AKI9R+xWxDaDS4ER8FQW5DvQdAKDmyY2WED83NzUYzfevBQ6weyvdoCahIvAEBY BCioUWsRO8y9ohrUJN97YN9Fa7ykXvyb+zIow= MIME-Version: 1.0 Received: by 10.204.31.196 with SMTP id z4mr7057479bkc.73.1244494205516; Mon, 08 Jun 2009 13:50:05 -0700 (PDT) In-Reply-To: <1241369732.4472.27.camel@ct> References: <1241369732.4472.27.camel@ct> Date: Mon, 8 Jun 2009 22:50:05 +0200 Message-ID: From: "Vladimir 'phcoder' Serbinenko" To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] hfs+ uuid X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2009 20:50:12 -0000 On Sun, May 3, 2009 at 6:55 PM, Pavel Roskin wrote: > On Sun, 2009-05-03 at 12:42 +0200, Vladimir 'phcoder' Serbinenko wrote: >> This is a patch to support UUIDs on HFS+. MD5 code is copied from >> Michael Gorven's patch which is copied from libgcrypt nearly verbatim. >> Thanks for Cris for the info about how xnu expects UUID to be > > I suggest that you run all new code through GNU indent. =A0Spacing in > "32-(n)" will probably need to be fixed manually, as it's a preprocessor > directive. > > Commented out call to to _gcry_burn_stack() should probably be removed. > I would prefer that we don't use #undef. =A0Instead, the preprocessor > defines should use unique names that never need to be redefined. > > Setting two environment variables is undocumented. =A0I think rd_string > should not be needed. =A0If you need it due to the script engine problems= , > it's better to fix the script engine. =A0At least please mark that hack a= s > a hack. > > Perhaps we should consider adding %X support to grub_printf(). =A0I > realize that it will increase the core slightly, but if it's just a few > bytes, we could accept it. =A0Other modules may use it. =A0Or maybe we co= uld > have grub_toupper(), perhaps an inline function? > > Another thing to consider is whether md5 support should be in a separate > file. =A0It would make it possible to reuse md5 for other commands. Here is the improved patch. I deliberately ignored md5 comments because this part will be gone anyway whel Michael Gorven signs his copyright assignment and we incorporate luks patches > > -- > Regards, > Pavel Roskin > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > --=20 Regards Vladimir 'phcoder' Serbinenko