From: Maarten Lankhorst Subject: Re: [PATCH 2/6] drm/i915: use drm_connector_list_iter in intel_hotplug.c Date: Tue, 20 Dec 2016 14:32:01 +0100 Message-ID: References: <20161219082423.27798-1-daniel.vetter@ffwll.ch> <20161219082423.27798-2-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA6126EE34 for ; Tue, 20 Dec 2016 13:32:03 +0000 (UTC) In-Reply-To: <20161219082423.27798-2-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T3AgMTktMTItMTYgb20gMDk6MjQgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE5vdGhpbmcgc3Bl Y2lhbCwganVzdCByb3RlIGNvbnZlcnNpb24uCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0 dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfaG90cGx1Zy5jIHwgMjggKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jCj4gaW5kZXggM2Q1NDZjMDE5ZGUwLi4yZGRjOWU1 ODQyZWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jCj4gQEAgLTE0NSwx NiArMTQ1LDE3IEBAIHN0YXRpYyBib29sIGludGVsX2hwZF9pcnFfc3Rvcm1fZGV0ZWN0KHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgc3RhdGljIHZvaWQgaW50ZWxfaHBkX2ly cV9zdG9ybV9kaXNhYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9ICZkZXZfcHJpdi0+ZHJtOwo+IC0Jc3RydWN0IGRy bV9tb2RlX2NvbmZpZyAqbW9kZV9jb25maWcgPSAmZGV2LT5tb2RlX2NvbmZpZzsKPiAgCXN0cnVj dCBpbnRlbF9jb25uZWN0b3IgKmludGVsX2Nvbm5lY3RvcjsKPiAgCXN0cnVjdCBpbnRlbF9lbmNv ZGVyICppbnRlbF9lbmNvZGVyOwo+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsK PiArCXN0cnVjdCBkcm1fY29ubmVjdG9yX2xpc3RfaXRlciBjb25uX2l0ZXI7Cj4gIAllbnVtIGhw ZF9waW4gcGluOwo+ICAJYm9vbCBocGRfZGlzYWJsZWQgPSBmYWxzZTsKPiAgCj4gIAlhc3NlcnRf c3Bpbl9sb2NrZWQoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4gIAo+IC0JbGlzdF9mb3JfZWFjaF9l bnRyeShjb25uZWN0b3IsICZtb2RlX2NvbmZpZy0+Y29ubmVjdG9yX2xpc3QsIGhlYWQpIHsKPiAr CWRybV9jb25uZWN0b3JfbGlzdF9pdGVyX2dldChkZXYsICZjb25uX2l0ZXIpOwo+ICsJZHJtX2Zv cl9lYWNoX2Nvbm5lY3Rvcl9pdGVyKGNvbm5lY3RvciwgJmNvbm5faXRlcikgewo+ICAJCWlmIChj b25uZWN0b3ItPnBvbGxlZCAhPSBEUk1fQ09OTkVDVE9SX1BPTExfSFBEKQo+ICAJCQljb250aW51 ZTsKVGhpcyBpcyBjYWxsZWQgd2l0aCBpcnFzIGRpc2FibGVkLCB3aWxsIGxvY2tkZXAgY29tcGxh aW4gYWJvdXQgaW5jb25zaXN0ZW50IHVzZSBvZiB0aGlzIGxvY2sgd2l0aCBhbmQgd2l0aG91dCBp cnFzPwoKSWYgbm90LAoKUmV2aWV3ZWQtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxh bmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQEAgLTE3Nyw2ICsxNzgsNyBAQCBzdGF0aWMgdm9p ZCBpbnRlbF9ocGRfaXJxX3N0b3JtX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+ICAJCQl8IERSTV9DT05ORUNUT1JfUE9MTF9ESVNDT05ORUNUOwo+ICAJCWhwZF9k aXNhYmxlZCA9IHRydWU7Cj4gIAl9Cj4gKwlkcm1fY29ubmVjdG9yX2xpc3RfaXRlcl9wdXQoJmNv bm5faXRlcik7Cj4gIAo+ICAJLyogRW5hYmxlIHBvbGxpbmcgYW5kIHF1ZXVlIGhvdHBsdWcgcmUt ZW5hYmxpbmcuICovCj4gIAlpZiAoaHBkX2Rpc2FibGVkKSB7Cj4gQEAgLTE5Miw3ICsxOTQsNiBA QCBzdGF0aWMgdm9pZCBpbnRlbF9ocGRfaXJxX3N0b3JtX3JlZW5hYmxlX3dvcmsoc3RydWN0IHdv cmtfc3RydWN0ICp3b3JrKQo+ICAJCWNvbnRhaW5lcl9vZih3b3JrLCB0eXBlb2YoKmRldl9wcml2 KSwKPiAgCQkJICAgICBob3RwbHVnLnJlZW5hYmxlX3dvcmsud29yayk7Cj4gIAlzdHJ1Y3QgZHJt X2RldmljZSAqZGV2ID0gJmRldl9wcml2LT5kcm07Cj4gLQlzdHJ1Y3QgZHJtX21vZGVfY29uZmln ICptb2RlX2NvbmZpZyA9ICZkZXYtPm1vZGVfY29uZmlnOwo+ICAJaW50IGk7Cj4gIAo+ICAJaW50 ZWxfcnVudGltZV9wbV9nZXQoZGV2X3ByaXYpOwo+IEBAIC0yMDAsMTMgKzIwMSwxNSBAQCBzdGF0 aWMgdm9pZCBpbnRlbF9ocGRfaXJxX3N0b3JtX3JlZW5hYmxlX3dvcmsoc3RydWN0IHdvcmtfc3Ry dWN0ICp3b3JrKQo+ICAJc3Bpbl9sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPiAgCWZv cl9lYWNoX2hwZF9waW4oaSkgewo+ICAJCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7 Cj4gKwkJc3RydWN0IGRybV9jb25uZWN0b3JfbGlzdF9pdGVyIGNvbm5faXRlcjsKPiAgCj4gIAkJ aWYgKGRldl9wcml2LT5ob3RwbHVnLnN0YXRzW2ldLnN0YXRlICE9IEhQRF9ESVNBQkxFRCkKPiAg CQkJY29udGludWU7Cj4gIAo+ICAJCWRldl9wcml2LT5ob3RwbHVnLnN0YXRzW2ldLnN0YXRlID0g SFBEX0VOQUJMRUQ7Cj4gIAo+IC0JCWxpc3RfZm9yX2VhY2hfZW50cnkoY29ubmVjdG9yLCAmbW9k ZV9jb25maWctPmNvbm5lY3Rvcl9saXN0LCBoZWFkKSB7Cj4gKwkJZHJtX2Nvbm5lY3Rvcl9saXN0 X2l0ZXJfZ2V0KGRldiwgJmNvbm5faXRlcik7Cj4gKwkJZHJtX2Zvcl9lYWNoX2Nvbm5lY3Rvcl9p dGVyKGNvbm5lY3RvciwgJmNvbm5faXRlcikgewo+ICAJCQlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9y ICppbnRlbF9jb25uZWN0b3IgPSB0b19pbnRlbF9jb25uZWN0b3IoY29ubmVjdG9yKTsKPiAgCj4g IAkJCWlmIChpbnRlbF9jb25uZWN0b3ItPmVuY29kZXItPmhwZF9waW4gPT0gaSkgewo+IEBAIC0y MTgsNiArMjIxLDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfaHBkX2lycV9zdG9ybV9yZWVuYWJsZV93 b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiAgCQkJCQljb25uZWN0b3ItPnBvbGxlZCA9 IERSTV9DT05ORUNUT1JfUE9MTF9IUEQ7Cj4gIAkJCX0KPiAgCQl9Cj4gKwkJZHJtX2Nvbm5lY3Rv cl9saXN0X2l0ZXJfcHV0KCZjb25uX2l0ZXIpOwo+ICAJfQo+ICAJaWYgKGRldl9wcml2LT5kaXNw bGF5LmhwZF9pcnFfc2V0dXApCj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuaHBkX2lycV9zZXR1cChk ZXZfcHJpdik7Cj4gQEAgLTMwMywxNCArMzA3LDE0IEBAIHN0YXRpYyB2b2lkIGk5MTVfaG90cGx1 Z193b3JrX2Z1bmMoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0KPiAgCQljb250YWluZXJfb2Yod29yaywgc3RydWN0IGRybV9p OTE1X3ByaXZhdGUsIGhvdHBsdWcuaG90cGx1Z193b3JrKTsKPiAgCXN0cnVjdCBkcm1fZGV2aWNl ICpkZXYgPSAmZGV2X3ByaXYtPmRybTsKPiAtCXN0cnVjdCBkcm1fbW9kZV9jb25maWcgKm1vZGVf Y29uZmlnID0gJmRldi0+bW9kZV9jb25maWc7Cj4gIAlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpp bnRlbF9jb25uZWN0b3I7Cj4gIAlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqaW50ZWxfZW5jb2RlcjsK PiAgCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5l Y3Rvcl9saXN0X2l0ZXIgY29ubl9pdGVyOwo+ICAJYm9vbCBjaGFuZ2VkID0gZmFsc2U7Cj4gIAl1 MzIgaHBkX2V2ZW50X2JpdHM7Cj4gIAo+IC0JbXV0ZXhfbG9jaygmbW9kZV9jb25maWctPm11dGV4 KTsKPiArCW11dGV4X2xvY2soJmRldi0+bW9kZV9jb25maWcubXV0ZXgpOwo+ICAJRFJNX0RFQlVH X0tNUygicnVubmluZyBlbmNvZGVyIGhvdHBsdWcgZnVuY3Rpb25zXG4iKTsKPiAgCj4gIAlzcGlu X2xvY2tfaXJxKCZkZXZfcHJpdi0+aXJxX2xvY2spOwo+IEBAIC0zMjMsNyArMzI3LDggQEAgc3Rh dGljIHZvaWQgaTkxNV9ob3RwbHVnX3dvcmtfZnVuYyhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmsp Cj4gIAo+ICAJc3Bpbl91bmxvY2tfaXJxKCZkZXZfcHJpdi0+aXJxX2xvY2spOwo+ICAKPiAtCWxp c3RfZm9yX2VhY2hfZW50cnkoY29ubmVjdG9yLCAmbW9kZV9jb25maWctPmNvbm5lY3Rvcl9saXN0 LCBoZWFkKSB7Cj4gKwlkcm1fY29ubmVjdG9yX2xpc3RfaXRlcl9nZXQoZGV2LCAmY29ubl9pdGVy KTsKPiArCWRybV9mb3JfZWFjaF9jb25uZWN0b3JfaXRlcihjb25uZWN0b3IsICZjb25uX2l0ZXIp IHsKPiAgCQlpbnRlbF9jb25uZWN0b3IgPSB0b19pbnRlbF9jb25uZWN0b3IoY29ubmVjdG9yKTsK PiAgCQlpZiAoIWludGVsX2Nvbm5lY3Rvci0+ZW5jb2RlcikKPiAgCQkJY29udGludWU7Cj4gQEAg LTMzNyw3ICszNDIsOCBAQCBzdGF0aWMgdm9pZCBpOTE1X2hvdHBsdWdfd29ya19mdW5jKHN0cnVj dCB3b3JrX3N0cnVjdCAqd29yaykKPiAgCQkJCWNoYW5nZWQgPSB0cnVlOwo+ICAJCX0KPiAgCX0K PiAtCW11dGV4X3VubG9jaygmbW9kZV9jb25maWctPm11dGV4KTsKPiArCWRybV9jb25uZWN0b3Jf bGlzdF9pdGVyX3B1dCgmY29ubl9pdGVyKTsKPiArCW11dGV4X3VubG9jaygmZGV2LT5tb2RlX2Nv bmZpZy5tdXRleCk7Cj4gIAo+ICAJaWYgKGNoYW5nZWQpCj4gIAkJZHJtX2ttc19oZWxwZXJfaG90 cGx1Z19ldmVudChkZXYpOwo+IEBAIC00ODMsMTUgKzQ4OSwxNiBAQCBzdGF0aWMgdm9pZCBpOTE1 X2hwZF9wb2xsX2luaXRfd29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gIAkJY29udGFp bmVyX29mKHdvcmssIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlLAo+ICAJCQkgICAgIGhvdHBsdWcu cG9sbF9pbml0X3dvcmspOwo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9ICZkZXZfcHJpdi0+ ZHJtOwo+IC0Jc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqbW9kZV9jb25maWcgPSAmZGV2LT5tb2Rl X2NvbmZpZzsKPiAgCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gKwlzdHJ1Y3Qg ZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXIgY29ubl9pdGVyOwo+ICAJYm9vbCBlbmFibGVkOwo+ICAK PiAgCW11dGV4X2xvY2soJmRldi0+bW9kZV9jb25maWcubXV0ZXgpOwo+ICAKPiAgCWVuYWJsZWQg PSBSRUFEX09OQ0UoZGV2X3ByaXYtPmhvdHBsdWcucG9sbF9lbmFibGVkKTsKPiAgCj4gLQlsaXN0 X2Zvcl9lYWNoX2VudHJ5KGNvbm5lY3RvciwgJm1vZGVfY29uZmlnLT5jb25uZWN0b3JfbGlzdCwg aGVhZCkgewo+ICsJZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXJfZ2V0KGRldiwgJmNvbm5faXRlcik7 Cj4gKwlkcm1fZm9yX2VhY2hfY29ubmVjdG9yX2l0ZXIoY29ubmVjdG9yLCAmY29ubl9pdGVyKSB7 Cj4gIAkJc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxfY29ubmVjdG9yID0KPiAgCQkJdG9f aW50ZWxfY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gIAkJY29ubmVjdG9yLT5wb2xsZWQgPSBpbnRl bF9jb25uZWN0b3ItPnBvbGxlZDsKPiBAQCAtNTA5LDYgKzUxNiw3IEBAIHN0YXRpYyB2b2lkIGk5 MTVfaHBkX3BvbGxfaW5pdF93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiAgCQkJCURS TV9DT05ORUNUT1JfUE9MTF9IUEQ7Cj4gIAkJfQo+ICAJfQo+ICsJZHJtX2Nvbm5lY3Rvcl9saXN0 X2l0ZXJfcHV0KCZjb25uX2l0ZXIpOwo+ICAKPiAgCWlmIChlbmFibGVkKQo+ICAJCWRybV9rbXNf aGVscGVyX3BvbGxfZW5hYmxlX2xvY2tlZChkZXYpOwoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=