Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A07FCC433EF for ; Sun, 17 Jul 2022 15:00:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9484A83DEB; Sun, 17 Jul 2022 17:00:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="Vb7FG4GS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 30FB283E03; Sun, 17 Jul 2022 17:00:34 +0200 (CEST) Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A2BD48118A for ; Sun, 17 Jul 2022 17:00:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=afd@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 26HF0Teg022356; Sun, 17 Jul 2022 10:00:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1658070029; bh=+y1pZywnBoru6etAW7pkVHT50EBp9ZOJS86HhmgQO3w=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=Vb7FG4GSSTKmj8hBzj0DeWibIjmKPFBrkyF2/sWvfoq6/CdWoH7gHVSbD8Kh3Cr8s sv+GEt5hrYKRUpl/9gjp59eTYW5FXs+KUyPT/jmwuUTopdENasztbNMbgS5pXEexc5 ajorPMSG1jL8hJ0B/c4gBwEaHI+jriNGmLrmz2eg= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 26HF0TFj036307 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 17 Jul 2022 10:00:29 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Sun, 17 Jul 2022 10:00:28 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Sun, 17 Jul 2022 10:00:28 -0500 Received: from [10.250.35.232] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 26HF0SLU041432; Sun, 17 Jul 2022 10:00:28 -0500 Message-ID: Date: Sun, 17 Jul 2022 10:00:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] spl: Move check for SPL_LIBCOMMON support to header Content-Language: en-US To: Simon Glass CC: Tom Rini , U-Boot Mailing List References: <20220715153500.15598-1-afd@ti.com> From: Andrew Davis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 7/16/22 7:00 AM, Simon Glass wrote: > Hi Andrew, > > On Fri, 15 Jul 2022 at 09:35, Andrew Davis wrote: >> >> From: "Andrew F. Davis" >> >> Print statements in SPL depend on lib/common support, due to this many >> such print statements are ifdef'd. Instead of checking at each call site >> move the check to the common.h header and remove these inline checks. > > nit: stdio.h I think? > Ah yes, looks like this header got renamed since I wrote this patch. Will fix if v2 is needed. Thanks, Andrew >> >> Signed-off-by: Andrew F. Davis >> Reviewed-by: Simon Glass >> --- >> boot/common_fit.c | 2 -- >> common/spl/spl.c | 4 +--- >> common/spl/spl_ext.c | 8 -------- >> common/spl/spl_fat.c | 6 ------ >> common/spl/spl_mmc.c | 18 ------------------ >> common/spl/spl_usb.c | 2 -- >> drivers/mmc/mmc-uclass.c | 2 -- >> drivers/mmc/mmc.c | 12 ------------ >> drivers/mmc/mmc_legacy.c | 2 -- >> include/stdio.h | 5 ++--- >> 10 files changed, 3 insertions(+), 58 deletions(-) >> > > Regards, > Simon