From: Dhinakaran Pandiyan Subject: Re: [PATCH v2 2/6] drm/i915/psr: Always wait for idle state when disabling PSR Date: Fri, 19 Oct 2018 13:47:15 -0700 Message-ID: References: <20181011004124.4110-1-jose.souza@intel.com> <20181011004124.4110-2-jose.souza@intel.com> <25246891.FZNb5hYFUk@dk-thinkpad-x260> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C11AF6E552 for ; Fri, 19 Oct 2018 20:47:33 +0000 (UTC) In-Reply-To: <25246891.FZNb5hYFUk@dk-thinkpad-x260> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE4LTEwLTE5IGF0IDEzOjQyIC0wNzAwLCBEaGluYWthcmFuIFBhbmRpeWFuIHdy b3RlOgo+IE9uIFdlZG5lc2RheSwgT2N0b2JlciAxMCwgMjAxOCA1OjQxOjIwIFBNIFBEVCBKb3PD qSBSb2JlcnRvIGRlIFNvdXphCj4gd3JvdGU6Cj4gPiBJdCBzaG91bGQgYWx3YXlzIHdhaXQgZm9y IGlkbGUgc3RhdGUgd2hlbiBkaXNhYmxpbmcgUFNSIGJlY2F1c2UgUFNSCj4gPiBjb3VsZCBiZSBp bmFjdGl2ZSBkdWUgYSBjYWxsIHRvIGludGVsX3Bzcl9leGl0KCkgYW5kIHdoaWxlIFBTUiBpcwo+ ID4gc3RpbGwgYmVpbmcgZGlzYWJsZWQgYXN5bmNocm9ub3VzbHkgdXNlcnNwYWNlIGNvdWxkIGNo YW5nZSB0aGUKPiA+IG1vZGVzZXQgY2F1c2luZyBhIGNhbGwgdG8gcHNyX2Rpc2FibGUoKSB0aGF0 IHdpbGwgbm90IHdhaXQgZm9yIFBTUgo+ID4gaWRsZSBhbmQgdGhlbiBQU1Igd2lsbCBiZSBlbmFi bGVkIGFnYWluIHdoaWxlIFBTUiBpcyBzdGlsbCBub3QKPiA+IGlkbGUuCj4gPiAKPiA+IHYyOiBy ZWJhc2VkIG9uIHRvcCBvZiB0aGUgcGF0Y2ggcmV1c2luZyBwc3JfZXhpdCgpCj4gPiAKPiA+IENj OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gPiBDYzogRGhpbmFrYXJh biBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gPiBTaWduZWQtb2Zm LWJ5OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KPiA+IC0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIHwgNDEgKysrKysrKysrKysr KystLS0tLS0tLS0tLS0KPiA+IC0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRp b25zKCspLCAyMyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bz ci5jIGluZGV4IGY2OThiM2Y0NWM2ZC4uMTZkMGUzZGY3ZGUwCj4gPiAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gQEAgLTY2MSw4ICs2NjEsMTIgQEAgc3RhdGljIHZvaWQg aW50ZWxfcHNyX2V4aXQoc3RydWN0Cj4gPiBkcm1faTkxNV9wcml2YXRlCj4gPiAqZGV2X3ByaXYp IHsKPiA+ICAJdTMyIHZhbDsKPiA+IAo+ID4gLQlpZiAoIWRldl9wcml2LT5wc3IuYWN0aXZlKQo+ ID4gKwlpZiAoIWRldl9wcml2LT5wc3IuYWN0aXZlKSB7Cj4gPiArCQlpZiAoSU5URUxfR0VOKGRl dl9wcml2KSA+PSA5KQo+ID4gKwkJCVdBUk5fT04oSTkxNV9SRUFEKEVEUF9QU1IyX0NUTCkgJgo+ ID4gRURQX1BTUjJfRU5BQkxFKTsKPiA+ICsJCVdBUk5fT04oSTkxNV9SRUFEKEVEUF9QU1JfQ1RM KSAmIEVEUF9QU1JfRU5BQkxFKTsKPiAKPiBEbyB3ZSByZWFsbHkgbmVlZCBzbyBtYW55IFdBUk5f T05zIG5lZWRpbmcgTU1JTyByZWFkcz8gVGhlcmUgYXJlCj4gYWxtb3N0IGFzIAo+IG1hbnkgbGlu ZXMgb2Ygd2FybmluZ3MgYXMgY29kZSBpbiB0aGlzIGZ1bmN0aW9uLiBJIHRoaW5rIGF0IHRoaXMK PiBwb2ludCwgd2UgCj4ga25vdyB0aGlzIGNvZGUgd29ya3MgYW5kIHRoZSB3YXJuaW5ncyBpbiBw c3JfZXhpdCgpIHNob3VsZCBiZQo+IHJlbW92ZWQuCj4gCj4gPiAgCQlyZXR1cm47Cj4gPiArCX0K PiA+IAo+ID4gIAlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJsZWQpIHsKPiA+ICAJCXZhbCA9 IEk5MTVfUkVBRChFRFBfUFNSMl9DVEwpOwo+ID4gQEAgLTY4MCwzMiArNjg0LDIzIEBAIHN0YXRp YyB2b2lkCj4gPiAgaW50ZWxfcHNyX2Rpc2FibGVfc291cmNlKHN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHApCj4gPiAgewo+ID4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBk cF90b19pOTE1KGludGVsX2RwKTsKPiA+ICsJaTkxNV9yZWdfdCBwc3Jfc3RhdHVzOwo+ID4gKwl1 MzIgcHNyX3N0YXR1c19tYXNrOwo+ID4gCj4gPiAtCWlmIChkZXZfcHJpdi0+cHNyLmFjdGl2ZSkg ewo+ID4gLQkJaTkxNV9yZWdfdCBwc3Jfc3RhdHVzOwo+ID4gLQkJdTMyIHBzcl9zdGF0dXNfbWFz azsKPiA+IC0KPiA+IC0JCWludGVsX3Bzcl9leGl0KGRldl9wcml2KTsKPiA+ICsJaW50ZWxfcHNy X2V4aXQoZGV2X3ByaXYpOwo+ID4gCj4gPiAtCQlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJs ZWQpIHsKPiA+IC0JCQlwc3Jfc3RhdHVzID0gRURQX1BTUjJfU1RBVFVTOwo+ID4gLQkJCXBzcl9z dGF0dXNfbWFzayA9IEVEUF9QU1IyX1NUQVRVU19TVEFURV9NQVNLOwo+ID4gLQkJfSBlbHNlIHsK PiA+IC0JCQlwc3Jfc3RhdHVzID0gRURQX1BTUl9TVEFUVVM7Cj4gPiAtCQkJcHNyX3N0YXR1c19t YXNrID0gRURQX1BTUl9TVEFUVVNfU1RBVEVfTUFTSzsKPiA+IC0JCX0KPiA+IC0KPiA+IC0JCS8q IFdhaXQgdGlsbCBQU1IgaXMgaWRsZSAqLwo+ID4gLQkJaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lz dGVyKGRldl9wcml2LAo+ID4gLQkJCQkJICAgIHBzcl9zdGF0dXMsCj4gPiBwc3Jfc3RhdHVzX21h c2ssIDAsCj4gPiAtCQkJCQkgICAgMjAwMCkpCj4gPiAtCQkJRFJNX0VSUk9SKCJUaW1lZCBvdXQg d2FpdGluZyBmb3IgUFNSIElkbGUKPiA+IFN0YXRlXG4iKTsKPiA+ICsJaWYgKGRldl9wcml2LT5w c3IucHNyMl9lbmFibGVkKSB7Cj4gPiArCQlwc3Jfc3RhdHVzID0gRURQX1BTUjJfU1RBVFVTOwo+ ID4gKwkJcHNyX3N0YXR1c19tYXNrID0gRURQX1BTUjJfU1RBVFVTX1NUQVRFX01BU0s7Cj4gPiAg CX0gZWxzZSB7Cj4gPiAtCQlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJsZWQpCj4gPiAtCQkJ V0FSTl9PTihJOTE1X1JFQUQoRURQX1BTUjJfQ1RMKSAmCj4gPiBFRFBfUFNSMl9FTkFCTEUpOwo+ ID4gLQkJZWxzZQo+ID4gLQkJCVdBUk5fT04oSTkxNV9SRUFEKEVEUF9QU1JfQ1RMKSAmCj4gPiBF RFBfUFNSX0VOQUJMRSk7Cj4gPiArCQlwc3Jfc3RhdHVzID0gRURQX1BTUl9TVEFUVVM7Cj4gPiAr CQlwc3Jfc3RhdHVzX21hc2sgPSBFRFBfUFNSX1NUQVRVU19TVEFURV9NQVNLOwo+ID4gIAl9Cj4g PiArCj4gPiArCS8qIFdhaXQgdGlsbCBQU1IgaXMgaWRsZSAqLwo+ID4gKwlpZiAoaW50ZWxfd2Fp dF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIHBzcl9zdGF0dXMsCj4gPiBwc3Jfc3RhdHVzX21hc2ss IDAsCj4gPiArCQkJCSAgICAyMDAwKSkKPiA+ICsJCURSTV9FUlJPUigiVGltZWQgb3V0IHdhaXRp bmcgZm9yIFBTUiBJZGxlIFN0YXRlXG4iKTsKbml0cGljazogTWluZCB3cml0aW5nIHRoaXMgYXMg IlRpbWVkIG91dCB3YWl0aW5nIFBTUiBpZGxlIHN0YXRlXG4iIGlmCnlvdSBlbmQgdXAgc2VuZGlu ZyBhbm90aGVyIHZlcnNpb24gd2l0aG91dCB0aGUgd2FybmluZ3M/CgoKPiA+ICB9Cj4gPiAKPiA+ ICBzdGF0aWMgdm9pZCBpbnRlbF9wc3JfZGlzYWJsZV9sb2NrZWQoc3RydWN0IGludGVsX2RwICpp bnRlbF9kcCkKPiAKPiAKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=