From: Maarten Lankhorst Subject: Re: [PATCH V3 3/5] drm/i915: Implement 16GB dimm wa for latency level-0 Date: Fri, 31 Aug 2018 12:24:52 +0200 Message-ID: References: <20180824093225.12598-1-mahesh1.kumar@intel.com> <20180824093225.12598-4-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 483E96E8A4 for ; Fri, 31 Aug 2018 10:25:07 +0000 (UTC) In-Reply-To: <20180824093225.12598-4-mahesh1.kumar@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar , intel-gfx@lists.freedesktop.org Cc: rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T3AgMjQtMDgtMTggb20gMTE6MzIgc2NocmVlZiBNYWhlc2ggS3VtYXI6Cj4gTWVtb3J5IHdpdGgg MTZHQiBkaW1tcyByZXF1aXJlIGFuIGluY3JlYXNlIG9mIDF1cyBpbiBsZXZlbC0wIGxhdGVuY3ku Cj4gVGhpcyBwYXRjaCBpbXBsZW1lbnRzIHRoZSBzYW1lLgo+IEJzcGVjOiA0MzgxCj4KPiBjaGFu Z2VzIHNpbmNlIFYxOgo+ICAtIHMvbWVtZGV2X2luZm8vZHJhbV9pbmZvCj4gIC0gbWFrZSBza2xf aXNfMTZnYl9kaW1tIHB1cmUgZnVuY3Rpb24KPiBDaGFuZ2VzIHNpbmNlIFYyOgo+ICAtIG1ha2Ug aXNfMTZnYl9kaW1tIG1vcmUgZ2VuZXJpYwo+ICAtIHJlYmFzZQo+Cj4gU2lnbmVkLW9mZi1ieTog TWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFyQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuYyB8IDMzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIHwgIDMgKysrCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAxMyArKysrKysrKysrKysrCj4gIDMgZmlsZXMg Y2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuYwo+IGluZGV4IGUwOWU5Y2U4ZmFkZi4uMmJjNzRjMDFhMGU1IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5jCj4gQEAgLTEwODgsNiArMTA4OCwyMSBAQCBzdGF0aWMgZW51bSBk cmFtX3Jhbmsgc2tsX2dldF9kaW1tX3JhbmsodTggc2l6ZSwgdTMyIHJhbmspCj4gIAlyZXR1cm4g STkxNV9EUkFNX1JBTktfSU5WQUxJRDsKPiAgfQo+ICAKPiArc3RhdGljIGJvb2wKPiArc2tsX2lz XzE2Z2JfZGltbShlbnVtIGRyYW1fcmFuayByYW5rLCB1OCBzaXplLCB1OCB3aWR0aCkKPiArewo+ ICsJaWYgKHJhbmsgPT0gSTkxNV9EUkFNX1JBTktfU0lOR0xFICYmIHdpZHRoID09IDggJiYgc2l6 ZSA9PSAxNikKPiArCQlyZXR1cm4gdHJ1ZTsKPiArCWVsc2UgaWYgKHJhbmsgPT0gSTkxNV9EUkFN X1JBTktfRFVBTCAmJiB3aWR0aCA9PSA4ICYmIHNpemUgPT0gMzIpCj4gKwkJcmV0dXJuIHRydWU7 Cj4gKwllbHNlIGlmIChyYW5rID09IFNLTF9EUkFNX1JBTktfU0lOR0xFICYmIHdpZHRoID09IDE2 ICYmIHNpemUgPT0gOCkKPiArCQlyZXR1cm4gdHJ1ZTsKPiArCWVsc2UgaWYgKHJhbmsgPT0gU0tM X0RSQU1fUkFOS19EVUFMICYmIHdpZHRoID09IDE2ICYmIHNpemUgPT0gMTYpCj4gKwkJcmV0dXJu IHRydWU7Cj4gKwo+ICsJcmV0dXJuIGZhbHNlOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50Cj4gIHNr bF9kcmFtX2dldF9jaGFubmVsX2luZm8oc3RydWN0IGRyYW1fY2hhbm5lbF9pbmZvICpjaCwgdTMy IHZhbCkKPiAgewo+IEBAIC0xMTI1LDYgKzExNDAsMTEgQEAgc2tsX2RyYW1fZ2V0X2NoYW5uZWxf aW5mbyhzdHJ1Y3QgZHJhbV9jaGFubmVsX2luZm8gKmNoLCB1MzIgdmFsKQo+ICAJZWxzZQo+ICAJ CWNoLT5yYW5rID0gSTkxNV9EUkFNX1JBTktfU0lOR0xFOwo+ICAKPiArCWNoLT5pc18xNmdiX2Rp bW0gPSBza2xfaXNfMTZnYl9kaW1tKGNoLT5sX2luZm8ucmFuaywgY2gtPmxfaW5mby5zaXplLAo+ ICsJCQkJCSAgICBjaC0+bF9pbmZvLndpZHRoKSB8fAo+ICsJCQkgICBza2xfaXNfMTZnYl9kaW1t KGNoLT5zX2luZm8ucmFuaywgY2gtPnNfaW5mby5zaXplLAo+ICsJCQkJCSAgICBjaC0+c19pbmZv LndpZHRoKTsKPiArCj4gIAlEUk1fREVCVUdfS01TKCIoc2l6ZTp3aWR0aDpyYW5rKSBMKCVkR0I6 WCVkOiVzKSBTKCVkR0I6WCVkOiVzKVxuIiwKPiAgCQkgICAgICBjaC0+bF9pbmZvLnNpemUsIGNo LT5sX2luZm8ud2lkdGgsCj4gIAkJICAgICAgY2gtPmxfaW5mby5yYW5rID8gImR1YWwiIDogInNp bmdsZSIsCj4gQEAgLTExNTcsNiArMTE3Nyw4IEBAIHNrbF9kcmFtX2dldF9jaGFubmVsc19pbmZv KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQlyZXR1cm4gLUVJTlZBTDsK PiAgCX0KPiAgCj4gKwlkcmFtX2luZm8tPnZhbGlkX2RpbW0gPSB0cnVlOwo+ICsKPiAgCS8qCj4g IAkgKiBJZiBhbnkgb2YgdGhlIGNoYW5uZWwgaXMgc2luZ2xlIHJhbmsgY2hhbm5lbCwgd29yc3Qg Y2FzZSBvdXRwdXQKPiAgCSAqIHdpbGwgYmUgc2FtZSBhcyBpZiBzaW5nbGUgcmFuayBtZW1vcnks IHNvIGNvbnNpZGVyIHNpbmdsZSByYW5rCj4gQEAgLTExNzIsNiArMTE5NCwxMCBAQCBza2xfZHJh bV9nZXRfY2hhbm5lbHNfaW5mbyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g IAkJRFJNX0lORk8oImNvdWxkbid0IGdldCBtZW1vcnkgcmFuayBpbmZvcm1hdGlvblxuIik7Cj4g IAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAl9Cj4gKwo+ICsJaWYgKGNoMC5pc18xNmdiX2RpbW0gfHwg Y2gxLmlzXzE2Z2JfZGltbSkKPiArCQlkcmFtX2luZm8tPmlzXzE2Z2JfZGltbSA9IHRydWU7Cj4g Kwo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gQEAgLTEyODQsNiArMTMxMCw3IEBAIGJ4dF9nZXRf ZHJhbV9pbmZvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQlyZXR1cm4g LUVJTlZBTDsKPiAgCX0KPiAgCj4gKwlkcmFtX2luZm8tPnZhbGlkX2RpbW0gPSB0cnVlOwo+ICAJ ZHJhbV9pbmZvLT52YWxpZCA9IHRydWU7Cj4gIAlyZXR1cm4gMDsKPiAgfQo+IEBAIC0xMjk2LDYg KzEzMjMsOCBAQCBpbnRlbF9nZXRfZHJhbV9pbmZvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiAgCWludCByZXQ7Cj4gIAo+ICAJZHJhbV9pbmZvLT52YWxpZCA9IGZhbHNlOwo+ ICsJZHJhbV9pbmZvLT52YWxpZF9kaW1tID0gZmFsc2U7Cj4gKwlkcmFtX2luZm8tPmlzXzE2Z2Jf ZGltbSA9IGZhbHNlOwo+ICAJZHJhbV9pbmZvLT5yYW5rID0gSTkxNV9EUkFNX1JBTktfSU5WQUxJ RDsKPiAgCWRyYW1faW5mby0+YmFuZHdpZHRoX2ticHMgPSAwOwo+ICAJZHJhbV9pbmZvLT5udW1f Y2hhbm5lbHMgPSAwOwo+IEBAIC0xMzE5LDkgKzEzNDgsOSBAQCBpbnRlbF9nZXRfZHJhbV9pbmZv KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQlzcHJpbnRmKGJhbmR3aWR0 aF9zdHIsICJ1bmtub3duIik7Cj4gIAlEUk1fREVCVUdfS01TKCJEUkFNIGJhbmR3aWR0aDolcywg dG90YWwtY2hhbm5lbHM6ICV1XG4iLAo+ICAJCSAgICAgIGJhbmR3aWR0aF9zdHIsIGRyYW1faW5m by0+bnVtX2NoYW5uZWxzKTsKPiAtCURSTV9ERUJVR19LTVMoIkRSQU0gcmFuazogJXMgcmFua1xu IiwKPiArCURSTV9ERUJVR19LTVMoIkRSQU0gcmFuazogJXMgcmFuayAxNkdCLWRpbW06JXNcbiIs Cj4gIAkJICAgICAgKGRyYW1faW5mby0+cmFuayA9PSBJOTE1X0RSQU1fUkFOS19EVUFMKSA/Cj4g LQkJICAgICAgImR1YWwiIDogInNpbmdsZSIpOwo+ICsJCSAgICAgICJkdWFsIiA6ICJzaW5nbGUi LCB5ZXNubyhkcmFtX2luZm8tPmlzXzE2Z2JfZGltbSkpOwo+ICB9Cj4gIAo+ICAvKioKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCAwZGZhMGZkYmJhZTIuLjZjNDMyNjg0YzcyMSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0xOTQ2LDYgKzE5NDYsOCBAQCBzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSB7Cj4gIAo+ICAJc3RydWN0IGRyYW1faW5mbyB7Cj4gIAkJYm9vbCB2 YWxpZDsKPiArCQlib29sIHZhbGlkX2RpbW07Cj4gKwkJYm9vbCBpc18xNmdiX2RpbW07Cj4gIAkJ dTggbnVtX2NoYW5uZWxzOwo+ICAJCWVudW0gZHJhbV9yYW5rIHsKPiAgCQkJSTkxNV9EUkFNX1JB TktfSU5WQUxJRCA9IDAsCj4gQEAgLTIxNzQsNiArMjE3Niw3IEBAIHN0cnVjdCBkcmFtX2NoYW5u ZWxfaW5mbyB7Cj4gIAkJZW51bSBkcmFtX3JhbmsgcmFuazsKPiAgCX0gbF9pbmZvLCBzX2luZm87 Cj4gIAllbnVtIGRyYW1fcmFuayByYW5rOwo+ICsJYm9vbCBpc18xNmdiX2RpbW07Cj4gIH07Cj4g IAo+ICBzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICp0b19pOTE1KGNvbnN0 IHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gaW5kZXgg ZDk5ZTVmYWJlOTNjLi45NTUwZTI0ZmZjMmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMK PiBAQCAtMjg3NSw2ICsyODc1LDE5IEBAIHN0YXRpYyB2b2lkIGludGVsX3JlYWRfd21fbGF0ZW5j eShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCX0KPiAgCQl9Cj4gIAo+ ICsJCS8qCj4gKwkJICogV0EgTGV2ZWwtMCBhZGp1c3RtZW50IGZvciAxNkdCIERJTU1zOiBTS0wr Cj4gKwkJICogSWYgd2UgY291bGQgbm90IGdldCBkaW1tIGluZm8gZW5hYmxlIHRoaXMgV0EgdG8g cHJldmVudCBmcm9tCj4gKwkJICogYW55IHVuZGVycnVuLiBJZiBub3QgYWJsZSB0byBnZXQgRGlt bSBpbmZvIGFzc3VtZSAxNkdCIGRpbW0KPiArCQkgKiB0byBhdm9pZCBhbnkgdW5kZXJydW4uCj4g KwkJICovCj4gKwkJaWYgKGRldl9wcml2LT5kcmFtX2luZm8udmFsaWRfZGltbSkgewo+ICsJCQlp ZiAoZGV2X3ByaXYtPmRyYW1faW5mby5pc18xNmdiX2RpbW0pCj4gKwkJCQl3bVswXSArPSAxOwo+ ICsJCX0gZWxzZSB7Cj4gKwkJCXdtWzBdICs9IDE7Cj4gKwkJfQpDb3VsZCBiZSBzaW1wbGlmaWVk IHRvICF2YWxpZF9kaW1tIHx8IGlzXzE2X2diX2RpbW0uIDopCj4gKwo+ICAJfSBlbHNlIGlmIChJ U19IQVNXRUxMKGRldl9wcml2KSB8fCBJU19CUk9BRFdFTEwoZGV2X3ByaXYpKSB7Cj4gIAkJdWlu dDY0X3Qgc3NrcGQgPSBJOTE1X1JFQUQ2NChNQ0hfU1NLUEQpOwo+ICAKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK