From: "flichtenheld (Code Review)"
Date: Wed, 26 Jun 2024 13:51:11 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, gert@...1296...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="xfx1BbYz4wk="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: configure: Try to
detect LZO with pkg-config
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: cron2 , plaisthos , openvpn-devel
--xfx1BbYz4wk=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/556?usp=3Demail )
Change subject: configure: Try to detect LZO with pkg-config
......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS6:
> I think the pc is broken... everything LZO itself includes uses ... [=E2=80=A6]
Done
Patchset:
PS7:
> Tested on FreeBSD 14, "configure with no option" -> succeeds & builds fin=
e (LZO in /usr/local/... [=E2=80=A6]
We found out this is because lzodefs.h relies on lzoconf.h to include limit=
s.h. So we need to imitate that.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/556?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c038dc4ec80d3499582d81eee61fee74f26e693
Gerrit-Change-Number: 556
Gerrit-PatchSet: 8
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: cron2
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Comment-Date: Wed, 26 Jun 2024 13:51:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--xfx1BbYz4wk=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, plaisthos.
View C=
hange
2 comments:
=
Patchset:
Patch Set #6:
I think the pc is bro=
ken... everything LZO itself includes uses <lzo/lzoconf.h>... [=E2=80=
=A6]
Done
Patchse=
t:
Patch Set #7:
Tested on FreeBSD 14, "configure with no option" -> suc=
ceeds & builds fine (LZO in /usr/local/... [=E2=80=A6]
=
We found out thi=
s is because lzodefs.h relies on lzoconf.h to include limits.h. So we need =
to imitate that.
To view, visit change 556. To unsubsc=
ribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c038dc4ec80d3499582d81eee6=
1fee74f26e693
Gerrit-Change-Number: 556
Gerrit-PatchSet: 8
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Comment-Date: Wed, 26 Jun 2024 13:51:11=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Gerrit-MessageType: comment
--xfx1BbYz4wk=--