Received: by 2002:a17:906:b10c:b0:992:abd5:50eb with SMTP id u12csp2979945ejy; Tue, 4 Jul 2023 08:21:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlE9FZqhnwLveyGHt60w9bpg4NC6oa4J1N3StRxkJZagGrT9bdy89KYctgrfQ12aUURpvZll X-Received: by 2002:ad4:594c:0:b0:630:1732:7090 with SMTP id eo12-20020ad4594c000000b0063017327090mr14039383qvb.55.1688484117918; Tue, 04 Jul 2023 08:21:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688484117; cv=none; d=google.com; s=arc-20160816; b=J4c9rggU9F07gezYegMIt6Ix/g3wzEPHRBtBjLgAGxLJRCvCTchpVca2pxqDKYEDh9 vQ23x/NT/6XX+lrgwW24Pdg/sI5TFkJua0Gn4nYV4RQWaA2cJwYL7dLRxUaBLY+UqsnC Kxzw3Cra+z7jY+3kctbCNQFlxJFYrGX1Tahh0Mqk+h4kBEkHhM7L9Jc96QzT5CcZWTeM zctGzFIxhooXV8bilDoDh+iCN9No80AqDwp5HwuvJcLxX6s4HVbI5SI3VOlf9iWtP1f8 VnB2FOLSPtv9PPnlhUMpK+gMEC1Ng+LCGRrt2lA2UQ7lRRjAKXft41RBOzdKF9hU/dWJ EH5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=gbS8ou3K3WgLGLWO7F6RM3pjaHqkGe6mRJLuqkjTdNw=; fh=sKOliLpsPmef7CS5atamlyEPWIP0kxb6Hu7HmDEzLZo=; b=SaB59eXysTTjvXn2KV6NPlWTkuJuYsoqqfDTOMh8RE7+5HUNt3X1qn1dShFjhGJCtx RQDLe7TlU2nTWzURFvfXtlOJq69m3xkxRX+aEaQnzivJxpInLmtMtrFyaYl3+elRkio8 5CAHemUw6/ygcQtPcVwrpfa05GgHRFbo1i7dOUqAbj8Zx44sAx5cmM8K4IHDXb0bPHwT 4FxyPTbZe77drsPOqs7wJCYLc3eHZVF79zWbBi8Ps4MF5LIDORhiKP+j3ETtl19mn0+7 kv4Pbu0uOjMH0Wqxme6nOOc/uK4F/w715poh1rt6YA2JJmE1HyUNKbDbZLYOrtgIKTYo h6jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SB+MMuLk; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ke26-20020a056214301a00b00631eb39b7b2si11092019qvb.63.2023.07.04.08.21.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Jul 2023 08:21:57 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SB+MMuLk; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGhqR-0000CZ-EW; Tue, 04 Jul 2023 11:21:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGhqP-0000Bp-S3 for qemu-arm@nongnu.org; Tue, 04 Jul 2023 11:21:33 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGhqO-0001oY-52 for qemu-arm@nongnu.org; Tue, 04 Jul 2023 11:21:33 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fbd33a57ddso32814185e9.1 for ; Tue, 04 Jul 2023 08:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688484090; x=1691076090; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gbS8ou3K3WgLGLWO7F6RM3pjaHqkGe6mRJLuqkjTdNw=; b=SB+MMuLkgrZNh/Dd0t8m3Ngtt8j4VfZrJL3WjI9nFv9VPTg30LbfSgGaH23eWn6aUM IxNmEzL8S9sM7RgoVPWXDpJwnwBu1hGkVEjdIpFD+sqbibFbgiKRGX4/KoaODEonYB0c Edu6Hm0Si1Azme3sO+KnRarOaeZjg+Kxi7/wANoQye+336MUZbhOksgI7D8KK/rqcx+D j0NSY9kkVq4cIQMP/c3FtachzlG/mU3HfF/AdI9y6RvVN5+ydGsUzQZv3CgGDPDu4Ezz DIOX2xaoabk+Io42GBK9cRVdnLHpO5XLKgxSl9mNYhPLEKyukGlKtQDorYg9XP3cc8vz M6CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688484090; x=1691076090; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gbS8ou3K3WgLGLWO7F6RM3pjaHqkGe6mRJLuqkjTdNw=; b=bHKMMt+1SmJQdPlPl/hvAkCws4k0Smw5ItguoJVQ84CR7iRVcp9mjRRTiqTJCx/yrI 0Du1NkPxUnrXY3POzI064p+mqC/dFYY5Sxgo+l4hW09N7kh0yNyc1v15UKrLHQY8PK5z NLHu6sxO3/ByCpYYFBHytnO9WkWl2qi+FEWr7N+Xxr7uZqFHA3r49Id8g86uSotcmCID uXLaRZgmf/fwcfkYJZee/iCsvIKpAxxZEY5SgoA9SgCuXJFDQ9t24MgNT5DuZpIhVkZb csWq5mijycp23OT2ArQXqKeBrBqjScgs4KQlx7ioWSwvhUJ3gzaNseTH3RC3xRZR05dn yabw== X-Gm-Message-State: ABy/qLbSaRHiNHTbnT1O/MH/MsXSauYn28TkB5n/IssSvqBknOrigwCP jqs3WBMGgqgVFtDVADzG7DNmlCtuHFSUIj58lXs= X-Received: by 2002:a05:600c:2041:b0:3fb:e189:3535 with SMTP id p1-20020a05600c204100b003fbe1893535mr1859439wmg.27.1688484090473; Tue, 04 Jul 2023 08:21:30 -0700 (PDT) Received: from [192.168.1.102] ([176.176.157.122]) by smtp.gmail.com with ESMTPSA id c9-20020adfe749000000b0031416362e23sm14362382wrn.3.2023.07.04.08.21.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 08:21:30 -0700 (PDT) Message-ID: Date: Tue, 4 Jul 2023 17:21:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG Content-Language: en-US To: Fabiano Rosas , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Richard Henderson References: <20230628164821.16771-1-farosas@suse.de> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230628164821.16771-1-farosas@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.09, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: CB5IhxzfdEVQ On 28/6/23 18:48, Fabiano Rosas wrote: > This code is only relevant when TCG is present in the build. Building > with --disable-tcg --enable-xen on an x86 host we get: > > $ ../configure --target-list=x86_64-softmmu,aarch64-softmmu --disable-tcg --enable-xen > $ make -j$(nproc) > ... > libqemu-aarch64-softmmu.fa.p/target_arm_gdbstub.c.o: in function `m_sysreg_ptr': > ../target/arm/gdbstub.c:358: undefined reference to `arm_v7m_get_sp_ptr' > ../target/arm/gdbstub.c:361: undefined reference to `arm_v7m_get_sp_ptr' > > libqemu-aarch64-softmmu.fa.p/target_arm_gdbstub.c.o: in function `arm_gdb_get_m_systemreg': > ../target/arm/gdbstub.c:405: undefined reference to `arm_v7m_mrs_control' > > Signed-off-by: Fabiano Rosas > --- > This is a respin of: > https://lore.kernel.org/r/20230313151058.19645-5-farosas@suse.de > --- > target/arm/gdbstub.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c > index 03b17c814f..f421c5d041 100644 > --- a/target/arm/gdbstub.c > +++ b/target/arm/gdbstub.c > @@ -324,6 +324,7 @@ static int arm_gen_dynamic_sysreg_xml(CPUState *cs, int base_reg) > return cpu->dyn_sysreg_xml.num; > } > > +#ifdef CONFIG_TCG OK. > typedef enum { > M_SYSREG_MSP, > M_SYSREG_PSP, > @@ -481,6 +482,7 @@ static int arm_gen_dynamic_m_secextreg_xml(CPUState *cs, int orig_base_reg) > return cpu->dyn_m_secextreg_xml.num; > } > #endif > +#endif /* CONFIG_TCG */ > > const char *arm_gdb_get_dynamic_xml(CPUState *cs, const char *xmlname) > { > @@ -561,6 +563,7 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu) > arm_gen_dynamic_sysreg_xml(cs, cs->gdb_num_regs), > "system-registers.xml", 0); > > +#ifdef CONFIG_TCG IIUC tcg_enabled(), this guard shouldn't be necessary; if CONFIG_TCG is not defined, tcg_enabled() evaluates to 0, and the compiler should elide the whole block. > if (arm_feature(env, ARM_FEATURE_M) && tcg_enabled()) { > gdb_register_coprocessor(cs, > arm_gdb_get_m_systemreg, arm_gdb_set_m_systemreg, > @@ -575,4 +578,5 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu) > } > #endif > } > +#endif /* CONFIG_TCG */ > }