Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jae.hyun.yoo@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46S4hW5lGJzDqKW for ; Tue, 10 Sep 2019 09:52:10 +1000 (AEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 16:52:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,487,1559545200"; d="scan'208";a="196354162" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.148]) ([10.7.153.148]) by orsmga002.jf.intel.com with ESMTP; 09 Sep 2019 16:52:08 -0700 Subject: Re: [PATCH v3 dev-5.2 2/2] i2c: aspeed: add slave inactive timeout support To: Tao Ren , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andrew Jeffery , Ryan Chen Cc: "openbmc@lists.ozlabs.org" References: <20190909222634.26146-1-jae.hyun.yoo@linux.intel.com> <20190909222634.26146-3-jae.hyun.yoo@linux.intel.com> From: Jae Hyun Yoo Message-ID: Date: Mon, 9 Sep 2019 16:52:08 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Sep 2019 23:52:12 -0000 On 9/9/2019 4:40 PM, Tao Ren wrote: > On 9/9/19 3:26 PM, Jae Hyun Yoo wrote: >> In case of multi-master environment, if a peer master incorrectly handles >> a bus in the middle of a transaction, I2C hardware hangs in slave state >> and it can't escape from the slave state, so this commit adds slave >> inactive timeout support to recover the bus in the case. >> >> Signed-off-by: Jae Hyun Yoo > > The patch looks good to me. Thank you Jae for making the changes. > > Reviewed-by: Tao Ren Hi Tao, Thanks a lot for your code review and your help on testing it. I'll submit it to linux upstream as well after completing other backlog I2C patches' upstreaming. Cheers, Jae