References: <20200626082743.15397-1-gert@...1296...> From: Antonio Quartulli Message-ID: Date: Fri, 3 Jul 2020 19:11:04 +0200 MIME-Version: 1.0 In-Reply-To: <20200626082743.15397-1-gert@...1296...> Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH] t_client.sh: correctly report all failed instances in summary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Gert Doering , openvpn-devel@lists.sourceforge.net Hi, On 26/06/2020 10:27, Gert Doering wrote: > t_client.sh reports a summary at the end: > > Test sets succeeded: none. > Test sets failed: 1 2 3 4 5. > > for tests that are skipped due to the pre-test ping check ("vpn target > IP must not ping before VPN ist started") the script forgot to add > the instance number to the summary line. Fixed. > > Signed-off-by: Gert Doering Simple enough and pretty clear. This is the only FAIL case where we set the exit code, print a message, but don't append the test to the SUMMARY_FAIL. This is fixed now. I can't easily come up with a t_client instance that verifies this failure, but I trust Gert to have done so after having spotted the issue. Acked-by: Antonio Quartulli -- Antonio Quartulli