From: "Koenig, Christian" Subject: Re: [PATCH v3] drm: Don't free jobs in wait_event_interruptible() Date: Thu, 26 Sep 2019 13:50:29 +0000 Message-ID: References: <20190926123134.4947-1-steven.price@arm.com> <73f058bb-8ba8-611b-e3a0-f6282445179c@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on061f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe49::61f]) by gabe.freedesktop.org (Postfix) with ESMTPS id B73686ED29 for ; Thu, 26 Sep 2019 13:50:31 +0000 (UTC) In-Reply-To: Content-Language: en-US Content-ID: <2DB134F39A315C4C9E6EEB44F70173CC@namprd12.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Steven Price , Daniel Vetter , David Airlie Cc: Nayan Deshmukh , "Deucher, Alexander" , Sharat Masetty , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org QW0gMjYuMDkuMTkgdW0gMTU6NDMgc2NocmllYiBTdGV2ZW4gUHJpY2U6DQo+IE9uIDI2LzA5LzIw MTkgMTQ6MzcsIEtvZW5pZywgQ2hyaXN0aWFuIHdyb3RlOg0KPj4gQW0gMjYuMDkuMTkgdW0gMTQ6 MzEgc2NocmllYiBTdGV2ZW4gUHJpY2U6DQo+Pj4gZHJtX3NjaGVkX2NsZWFudXBfam9icygpIGF0 dGVtcHRzIHRvIGZyZWUgZmluaXNoZWQgam9icywgaG93ZXZlciBiZWNhdXNlDQo+Pj4gaXQgaXMg Y2FsbGVkIGFzIHRoZSBjb25kaXRpb24gb2Ygd2FpdF9ldmVudF9pbnRlcnJ1cHRpYmxlKCkgaXQg bXVzdCBub3QNCj4+PiBzbGVlcC4gVW5mb3J0dWFudGx5IHNvbWUgZnJlZSBjYWxsYmFja3MgKG5v dGlibHkgZm9yIFBhbmZyb3N0KSBkbyBzbGVlcC4NCj4+Pg0KPj4+IEluc3RlYWQgbGV0J3MgcmVu YW1lIGRybV9zY2hlZF9jbGVhbnVwX2pvYnMoKSB0bw0KPj4+IGRybV9zY2hlZF9nZXRfY2xlYW51 cF9qb2IoKSBhbmQgc2ltcGx5IHJldHVybiBhIGpvYiBmb3IgcHJvY2Vzc2luZyBpZg0KPj4+IHRo ZXJlIGlzIG9uZS4gVGhlIGNhbGxlciBjYW4gdGhlbiBjYWxsIHRoZSBmcmVlX2pvYigpIGNhbGxi YWNrIG91dHNpZGUNCj4+PiB0aGUgd2FpdF9ldmVudF9pbnRlcnJ1cHRpYmxlKCkgd2hlcmUgc2xl ZXBpbmcgaXMgcG9zc2libGUgYmVmb3JlDQo+Pj4gcmUtY2hlY2tpbmcgYW5kIHJldHVybmluZyB0 byBzbGVlcCBpZiBuZWNlc3NhcnkuDQo+Pj4NCj4+PiBTaWduZWQtb2ZmLWJ5OiBTdGV2ZW4gUHJp Y2UgPHN0ZXZlbi5wcmljZUBhcm0uY29tPg0KPj4+IC0tLQ0KPj4+DQo+Pj4gQ2hhbmdlcyBmcm9t IHYyOg0KPj4+ICAgICogQWN0dWFsbHkgbW92ZSBsaXN0X2ZpcnN0X2VudHJ5X29yX251bGwoKSB3 aXRoaW4gdGhlIGxvY2sNCj4+Pg0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9zY2hlZHVsZXIvc2No ZWRfbWFpbi5jIHwgNDIgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0NCj4+PiAgICAxIGZpbGUg Y2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pDQo+Pj4NCj4+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMgYi9kcml2ZXJz L2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX21haW4uYw0KPj4+IGluZGV4IDlhMGVlNzRkODJkYy4u ZTRiZDc5MmYyYjI5IDEwMDY0NA0KPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zY2hlZHVsZXIv c2NoZWRfbWFpbi5jDQo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9t YWluLmMNCj4+PiBAQCAtNjIyLDQzICs2MjIsNDEgQEAgc3RhdGljIHZvaWQgZHJtX3NjaGVkX3By b2Nlc3Nfam9iKHN0cnVjdCBkbWFfZmVuY2UgKmYsIHN0cnVjdCBkbWFfZmVuY2VfY2IgKmNiKQ0K Pj4+ICAgIH0NCj4+PiAgICANCj4+PiAgICAvKioNCj4+PiAtICogZHJtX3NjaGVkX2NsZWFudXBf am9icyAtIGRlc3Ryb3kgZmluaXNoZWQgam9icw0KPj4+ICsgKiBkcm1fc2NoZWRfZ2V0X2NsZWFu dXBfam9iIC0gZmV0Y2ggdGhlIG5leHQgZmluaXNoZWQgam9iIHRvIGJlIGRlc3Ryb3llZA0KPj4+ ICAgICAqDQo+Pj4gICAgICogQHNjaGVkOiBzY2hlZHVsZXIgaW5zdGFuY2UNCj4+PiAgICAgKg0K Pj4+IC0gKiBSZW1vdmUgYWxsIGZpbmlzaGVkIGpvYnMgZnJvbSB0aGUgbWlycm9yIGxpc3QgYW5k IGRlc3Ryb3kgdGhlbS4NCj4+PiArICogUmV0dXJucyB0aGUgbmV4dCBmaW5pc2hlZCBqb2IgZnJv bSB0aGUgbWlycm9yIGxpc3QgKGlmIHRoZXJlIGlzIG9uZSkNCj4+PiArICogcmVhZHkgZm9yIGl0 IHRvIGJlIGRlc3Ryb3llZC4NCj4+PiAgICAgKi8NCj4+PiAtc3RhdGljIHZvaWQgZHJtX3NjaGVk X2NsZWFudXBfam9icyhzdHJ1Y3QgZHJtX2dwdV9zY2hlZHVsZXIgKnNjaGVkKQ0KPj4+ICtzdGF0 aWMgc3RydWN0IGRybV9zY2hlZF9qb2IgKg0KPj4+ICtkcm1fc2NoZWRfZ2V0X2NsZWFudXBfam9i KHN0cnVjdCBkcm1fZ3B1X3NjaGVkdWxlciAqc2NoZWQpDQo+Pj4gICAgew0KPj4+ICsJc3RydWN0 IGRybV9zY2hlZF9qb2IgKmpvYiA9IE5VTEw7DQo+Pj4gICAgCXVuc2lnbmVkIGxvbmcgZmxhZ3M7 DQo+Pj4gICAgDQo+Pj4gICAgCS8qIERvbid0IGRlc3Ryb3kgam9icyB3aGlsZSB0aGUgdGltZW91 dCB3b3JrZXIgaXMgcnVubmluZyAqLw0KPj4+ICAgIAlpZiAoc2NoZWQtPnRpbWVvdXQgIT0gTUFY X1NDSEVEVUxFX1RJTUVPVVQgJiYNCj4+PiAgICAJICAgICFjYW5jZWxfZGVsYXllZF93b3JrKCZz Y2hlZC0+d29ya190ZHIpKQ0KPj4+IC0JCXJldHVybjsNCj4+PiAtDQo+Pj4gKwkJcmV0dXJuIE5V TEw7DQo+Pj4gICAgDQo+Pj4gLQl3aGlsZSAoIWxpc3RfZW1wdHkoJnNjaGVkLT5yaW5nX21pcnJv cl9saXN0KSkgew0KPj4+IC0JCXN0cnVjdCBkcm1fc2NoZWRfam9iICpqb2I7DQo+Pj4gKwlzcGlu X2xvY2tfaXJxc2F2ZSgmc2NoZWQtPmpvYl9saXN0X2xvY2ssIGZsYWdzKTsNCj4+PiAgICANCj4+ PiAtCQlqb2IgPSBsaXN0X2ZpcnN0X2VudHJ5KCZzY2hlZC0+cmluZ19taXJyb3JfbGlzdCwNCj4+ PiArCWpvYiA9IGxpc3RfZmlyc3RfZW50cnlfb3JfbnVsbCgmc2NoZWQtPnJpbmdfbWlycm9yX2xp c3QsDQo+Pj4gICAgCQkJCSAgICAgICBzdHJ1Y3QgZHJtX3NjaGVkX2pvYiwgbm9kZSk7DQo+Pj4g LQkJaWYgKCFkbWFfZmVuY2VfaXNfc2lnbmFsZWQoJmpvYi0+c19mZW5jZS0+ZmluaXNoZWQpKQ0K Pj4+IC0JCQlicmVhazsNCj4+PiAgICANCj4+PiAtCQlzcGluX2xvY2tfaXJxc2F2ZSgmc2NoZWQt PmpvYl9saXN0X2xvY2ssIGZsYWdzKTsNCj4+PiArCWlmIChqb2IgJiYgZG1hX2ZlbmNlX2lzX3Np Z25hbGVkKCZqb2ItPnNfZmVuY2UtPmZpbmlzaGVkKSkgew0KPj4+ICAgIAkJLyogcmVtb3ZlIGpv YiBmcm9tIHJpbmdfbWlycm9yX2xpc3QgKi8NCj4+PiAgICAJCWxpc3RfZGVsX2luaXQoJmpvYi0+ bm9kZSk7DQo+Pj4gLQkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmc2NoZWQtPmpvYl9saXN0X2xv Y2ssIGZsYWdzKTsNCj4+PiAtDQo+Pj4gLQkJc2NoZWQtPm9wcy0+ZnJlZV9qb2Ioam9iKTsNCj4+ PiArCX0gZWxzZSB7DQo+Pj4gKwkJam9iID0gTlVMTDsNCj4+PiArCQkvKiBxdWV1ZSB0aW1lb3V0 IGZvciBuZXh0IGpvYiAqLw0KPj4+ICsJCWRybV9zY2hlZF9zdGFydF90aW1lb3V0KHNjaGVkKTsN Cj4+IFNvcnJ5IEkndmUgb25seSBzZWVuIHRoaXMgcmlnaHQgbm93OiBUaGlzIHdvbid0IHdvcmsu DQo+Pg0KPj4gU2VlIHlvdSBhbHdheXMgbmVlZCB0byBzdGFydCB0aGUgdGltZW91dCwgb3IgY2Fu Y2VsX2RlbGF5ZWRfd29yaygpIHdpbGwNCj4+IGFib3J0IHRoZSB3aG9sZSB0aGluZyBhZnRlciBy ZXR1cm5pbmcgdGhlIGZpcnN0IGpvYi4NCj4gR29vZCBzcG90IQ0KPg0KPiBNeSBsb2dpYyB3YXMg dGhhdCBkcm1fc2NoZWRfbWFpbigpIHdvdWxkIGNhbGwgYWdhaW4gYW5kIHRoYXQgd291bGQNCj4g cmUtYXJtIHRoZSB0aW1lb3V0IGFmdGVyIHRoZSBqb2IgaGFzIGJlZW4gY29tcGxldGVkLg0KPg0K PiBCdXQgbG9va2luZyBhdCB0aGlzIG1vcmUgY2xvc2VseSBJIHNlZSB0aGF0IGlzbid0IGFjdHVh bGx5IGdvaW5nIHRvIHdvcmsNCj4gcmVsaWFibHkgLSBpZiB0aGUgd29yayBoYXMgYmVlbiBjYW5j ZWxsZWQgdGhlIGZpcnN0IHRpbWUgdGhlbg0KPiBjYW5jZWxfZGVsYXllZF93b3JrKCkgd2lsbCBy ZXR1cm4gZmFsc2UgY2F1c2luZyBhbiBlYXJseSBvdXQgYW5kIHRoZQ0KPiB0aW1lb3V0IGlzbid0 IHJlLWFybWVkLg0KPg0KPiBJcyBpdCBhcyBzaW1wbGUgYXMgbW92aW5nIGRybV9zY2hlZF9zdGFy dF90aW1lb3V0KCkgb3V0IG9mIHRoZSBlbHNlIGNhc2UNCj4gYW5kIHVuY29uZGl0aW9uYWxseSBy ZS1hcm1pbmcgdGhlIHRpbWVvdXQ/IEknbSB3b3JyaWVkIGFib3V0IHJhY2VzIHdpdGgNCj4gdGhl IGpvYiB0aGF0IGlzIGJlaW5nIHJldHVybmVkLCBhbHRob3VnaCBpdCBoYXMgYWxyZWFkeSBiZWVu IHJlbW92ZWQNCj4gZnJvbSByaW5nX21pcnJvcl9saXN0IHNvIHBlcmhhcHMgaXQncyBzYWZlIHRv IGRvPw0KPg0KPiBBbHRlcm5hdGl2ZWx5IHRoZSBjYWxsZXIgY291bGQgbWFudWFsbHkgcmUtYXJt IHRoZSB0aW1lb3V0IGFmdGVyDQo+IGhhbmRsaW5nIHRoZSBqb2IgZnJlZS4NCg0KSSBkb24ndCBz ZWUgYW55dGhpbmcgdGhhdCBjb3VsZCBnbyB3cm9uZyBpbW1lZGlhdGVseSwgYnV0IHRoYXQgaXMg DQpwcm9iYWJseSB0aGUgY2xlYW5lciBhcHByb2FjaC4NCg0KU28gcGxlYXNlIGRvIHRoaXMgYW5k IHNpbmNlIHdlIGFyZSBub3cgZG9pbmcgbW9yZSB0aGFuIGp1c3QgcmVtb3ZpbmcgdGhlIA0Kam9i LCBwbGVhc2Uga2VlcCB0aGF0IGluIGEgc2VwYXJhdGUgZnVuY3Rpb24uDQoNClJlZ2FyZHMsDQpD aHJpc3RpYW4uDQoNCj4NCj4gU3RldmUNCj4NCj4+IENocmlzdGlhbi4NCj4+DQo+Pj4gICAgCX0N Cj4+PiAgICANCj4+PiAtCS8qIHF1ZXVlIHRpbWVvdXQgZm9yIG5leHQgam9iICovDQo+Pj4gLQlz cGluX2xvY2tfaXJxc2F2ZSgmc2NoZWQtPmpvYl9saXN0X2xvY2ssIGZsYWdzKTsNCj4+PiAtCWRy bV9zY2hlZF9zdGFydF90aW1lb3V0KHNjaGVkKTsNCj4+PiAgICAJc3Bpbl91bmxvY2tfaXJxcmVz dG9yZSgmc2NoZWQtPmpvYl9saXN0X2xvY2ssIGZsYWdzKTsNCj4+PiAgICANCj4+PiArCXJldHVy biBqb2I7DQo+Pj4gICAgfQ0KPj4+ICAgIA0KPj4+ICAgIC8qKg0KPj4+IEBAIC02OTgsMTIgKzY5 NiwxOCBAQCBzdGF0aWMgaW50IGRybV9zY2hlZF9tYWluKHZvaWQgKnBhcmFtKQ0KPj4+ICAgIAkJ c3RydWN0IGRybV9zY2hlZF9mZW5jZSAqc19mZW5jZTsNCj4+PiAgICAJCXN0cnVjdCBkcm1fc2No ZWRfam9iICpzY2hlZF9qb2I7DQo+Pj4gICAgCQlzdHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZTsNCj4+ PiArCQlzdHJ1Y3QgZHJtX3NjaGVkX2pvYiAqY2xlYW51cF9qb2IgPSBOVUxMOw0KPj4+ICAgIA0K Pj4+ICAgIAkJd2FpdF9ldmVudF9pbnRlcnJ1cHRpYmxlKHNjaGVkLT53YWtlX3VwX3dvcmtlciwN Cj4+PiAtCQkJCQkgKGRybV9zY2hlZF9jbGVhbnVwX2pvYnMoc2NoZWQpLA0KPj4+ICsJCQkJCSAo Y2xlYW51cF9qb2IgPSBkcm1fc2NoZWRfZ2V0X2NsZWFudXBfam9iKHNjaGVkKSkgfHwNCj4+PiAg ICAJCQkJCSAoIWRybV9zY2hlZF9ibG9ja2VkKHNjaGVkKSAmJg0KPj4+ICAgIAkJCQkJICAoZW50 aXR5ID0gZHJtX3NjaGVkX3NlbGVjdF9lbnRpdHkoc2NoZWQpKSkgfHwNCj4+PiAtCQkJCQkga3Ro cmVhZF9zaG91bGRfc3RvcCgpKSk7DQo+Pj4gKwkJCQkJIGt0aHJlYWRfc2hvdWxkX3N0b3AoKSk7 DQo+Pj4gKw0KPj4+ICsJCXdoaWxlIChjbGVhbnVwX2pvYikgew0KPj4+ICsJCQlzY2hlZC0+b3Bz LT5mcmVlX2pvYihjbGVhbnVwX2pvYik7DQo+Pj4gKwkJCWNsZWFudXBfam9iID0gZHJtX3NjaGVk X2dldF9jbGVhbnVwX2pvYihzY2hlZCk7DQo+Pj4gKwkJfQ0KPj4+ICAgIA0KPj4+ICAgIAkJaWYg KCFlbnRpdHkpDQo+Pj4gICAgCQkJY29udGludWU7DQo+PiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXw0KPj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdA0KPj4g ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZw0KPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwNCj4+DQoNCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==