From: "Grodzovsky, Andrey" Subject: Re: [PATCH] drm: Don't free jobs in wait_event_interruptible() Date: Wed, 25 Sep 2019 16:07:34 +0000 Message-ID: References: <20190925151404.23222-1-steven.price@arm.com> <078332cf-ef58-5f76-5c49-8034435f7bea@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-eopbgr800042.outbound.protection.outlook.com [40.107.80.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1CE189C29 for ; Wed, 25 Sep 2019 16:07:35 +0000 (UTC) In-Reply-To: <078332cf-ef58-5f76-5c49-8034435f7bea@arm.com> Content-Language: en-US Content-ID: <5364DB814D1F124599350D29E816FC22@namprd12.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Steven Price , Daniel Vetter , David Airlie , "Koenig, Christian" Cc: "Deucher, Alexander" , Nayan Deshmukh , Sharat Masetty , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gOS8yNS8xOSAxMjowMCBQTSwgU3RldmVuIFByaWNlIHdyb3RlOg0KDQo+IE9uIDI1LzA5LzIw MTkgMTY6NTYsIEdyb2R6b3Zza3ksIEFuZHJleSB3cm90ZToNCj4+IE9uIDkvMjUvMTkgMTE6MTQg QU0sIFN0ZXZlbiBQcmljZSB3cm90ZToNCj4+DQo+Pj4gZHJtX3NjaGVkX2NsZWFudXBfam9icygp IGF0dGVtcHRzIHRvIGZyZWUgZmluaXNoZWQgam9icywgaG93ZXZlciBiZWNhdXNlDQo+Pj4gaXQg aXMgY2FsbGVkIGFzIHRoZSBjb25kaXRpb24gb2Ygd2FpdF9ldmVudF9pbnRlcnJ1cHRpYmxlKCkg aXQgbXVzdCBub3QNCj4+PiBzbGVlcC4gVW5mb3J0dW5hdGVseSBzb21lIGZyZWUgY2FsbGJhY2tz IChub3RhYmx5IGZvciBQYW5mcm9zdCkgZG8gc2xlZXAuDQo+Pj4NCj4+PiBJbnN0ZWFkIGxldCdz IHJlbmFtZSBkcm1fc2NoZWRfY2xlYW51cF9qb2JzKCkgdG8NCj4+PiBkcm1fc2NoZWRfZ2V0X2Ns ZWFudXBfam9iKCkgYW5kIHNpbXBseSByZXR1cm4gYSBqb2IgZm9yIHByb2Nlc3NpbmcgaWYNCj4+ PiB0aGVyZSBpcyBvbmUuIFRoZSBjYWxsZXIgY2FuIHRoZW4gY2FsbCB0aGUgZnJlZV9qb2IoKSBj YWxsYmFjayBvdXRzaWRlDQo+Pj4gdGhlIHdhaXRfZXZlbnRfaW50ZXJydXB0aWJsZSgpIHdoZXJl IHNsZWVwaW5nIGlzIHBvc3NpYmxlIGJlZm9yZQ0KPj4+IHJlLWNoZWNraW5nIGFuZCByZXR1cm5p bmcgdG8gc2xlZXAgaWYgbmVjZXNzYXJ5Lg0KPj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogU3RldmVu IFByaWNlIDxzdGV2ZW4ucHJpY2VAYXJtLmNvbT4NCj4+PiAtLS0NCj4+PiAgICBkcml2ZXJzL2dw dS9kcm0vc2NoZWR1bGVyL3NjaGVkX21haW4uYyB8IDQ0ICsrKysrKysrKysrKysrLS0tLS0tLS0t LS0tDQo+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9u cygtKQ0KPj4+DQo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zY2hlZHVsZXIvc2No ZWRfbWFpbi5jIGIvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMNCj4+PiBp bmRleCA5YTBlZTc0ZDgyZGMuLjBlZDRhYWE0ZTZkMSAxMDA2NDQNCj4+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX21haW4uYw0KPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9zY2hlZHVsZXIvc2NoZWRfbWFpbi5jDQo+Pj4gQEAgLTYyMiw0MyArNjIyLDQxIEBAIHN0YXRp YyB2b2lkIGRybV9zY2hlZF9wcm9jZXNzX2pvYihzdHJ1Y3QgZG1hX2ZlbmNlICpmLCBzdHJ1Y3Qg ZG1hX2ZlbmNlX2NiICpjYikNCj4+PiAgICB9DQo+Pj4gICAgDQo+Pj4gICAgLyoqDQo+Pj4gLSAq IGRybV9zY2hlZF9jbGVhbnVwX2pvYnMgLSBkZXN0cm95IGZpbmlzaGVkIGpvYnMNCj4+PiArICog ZHJtX3NjaGVkX2dldF9jbGVhbnVwX2pvYiAtIGZldGNoIHRoZSBuZXh0IGZpbmlzaGVkIGpvYiB0 byBiZSBkZXN0cm95ZWQNCj4+PiAgICAgKg0KPj4+ICAgICAqIEBzY2hlZDogc2NoZWR1bGVyIGlu c3RhbmNlDQo+Pj4gICAgICoNCj4+PiAtICogUmVtb3ZlIGFsbCBmaW5pc2hlZCBqb2JzIGZyb20g dGhlIG1pcnJvciBsaXN0IGFuZCBkZXN0cm95IHRoZW0uDQo+Pj4gKyAqIFJldHVybnMgdGhlIG5l eHQgZmluaXNoZWQgam9iIGZyb20gdGhlIG1pcnJvciBsaXN0IChpZiB0aGVyZSBpcyBvbmUpDQo+ Pj4gKyAqIHJlYWR5IGZvciBpdCB0byBiZSBkZXN0cm95ZWQuDQo+Pj4gICAgICovDQo+Pj4gLXN0 YXRpYyB2b2lkIGRybV9zY2hlZF9jbGVhbnVwX2pvYnMoc3RydWN0IGRybV9ncHVfc2NoZWR1bGVy ICpzY2hlZCkNCj4+PiArc3RhdGljIHN0cnVjdCBkcm1fc2NoZWRfam9iICoNCj4+PiArZHJtX3Nj aGVkX2dldF9jbGVhbnVwX2pvYihzdHJ1Y3QgZHJtX2dwdV9zY2hlZHVsZXIgKnNjaGVkKQ0KPj4+ ICAgIHsNCj4+PiArCXN0cnVjdCBkcm1fc2NoZWRfam9iICpqb2IgPSBOVUxMOw0KPj4+ICAgIAl1 bnNpZ25lZCBsb25nIGZsYWdzOw0KPj4+ICAgIA0KPj4+ICAgIAkvKiBEb24ndCBkZXN0cm95IGpv YnMgd2hpbGUgdGhlIHRpbWVvdXQgd29ya2VyIGlzIHJ1bm5pbmcgKi8NCj4+PiAgICAJaWYgKHNj aGVkLT50aW1lb3V0ICE9IE1BWF9TQ0hFRFVMRV9USU1FT1VUICYmDQo+Pj4gICAgCSAgICAhY2Fu Y2VsX2RlbGF5ZWRfd29yaygmc2NoZWQtPndvcmtfdGRyKSkNCj4+PiAtCQlyZXR1cm47DQo+Pj4g LQ0KPj4+IC0NCj4+PiAtCXdoaWxlICghbGlzdF9lbXB0eSgmc2NoZWQtPnJpbmdfbWlycm9yX2xp c3QpKSB7DQo+Pj4gLQkJc3RydWN0IGRybV9zY2hlZF9qb2IgKmpvYjsNCj4+PiArCQlyZXR1cm4g TlVMTDsNCj4+PiAgICANCj4+PiAtCQlqb2IgPSBsaXN0X2ZpcnN0X2VudHJ5KCZzY2hlZC0+cmlu Z19taXJyb3JfbGlzdCwNCj4+PiArCWpvYiA9IGxpc3RfZmlyc3RfZW50cnlfb3JfbnVsbCgmc2No ZWQtPnJpbmdfbWlycm9yX2xpc3QsDQo+Pj4gICAgCQkJCSAgICAgICBzdHJ1Y3QgZHJtX3NjaGVk X2pvYiwgbm9kZSk7DQo+Pj4gLQkJaWYgKCFkbWFfZmVuY2VfaXNfc2lnbmFsZWQoJmpvYi0+c19m ZW5jZS0+ZmluaXNoZWQpKQ0KPj4+IC0JCQlicmVhazsNCj4+PiAgICANCj4+PiAtCQlzcGluX2xv Y2tfaXJxc2F2ZSgmc2NoZWQtPmpvYl9saXN0X2xvY2ssIGZsYWdzKTsNCj4+PiArCXNwaW5fbG9j a19pcnFzYXZlKCZzY2hlZC0+am9iX2xpc3RfbG9jaywgZmxhZ3MpOw0KPj4+ICsNCj4+PiArCWlm IChqb2IgJiYgZG1hX2ZlbmNlX2lzX3NpZ25hbGVkKCZqb2ItPnNfZmVuY2UtPmZpbmlzaGVkKSkg ew0KPj4+ICAgIAkJLyogcmVtb3ZlIGpvYiBmcm9tIHJpbmdfbWlycm9yX2xpc3QgKi8NCj4+PiAg ICAJCWxpc3RfZGVsX2luaXQoJmpvYi0+bm9kZSk7DQo+Pj4gLQkJc3Bpbl91bmxvY2tfaXJxcmVz dG9yZSgmc2NoZWQtPmpvYl9saXN0X2xvY2ssIGZsYWdzKTsNCj4+PiAtDQo+Pj4gLQkJc2NoZWQt Pm9wcy0+ZnJlZV9qb2Ioam9iKTsNCj4+PiArCX0gZWxzZSB7DQo+Pj4gKwkJam9iID0gTlVMTDsN Cj4+PiArCQkvKiBxdWV1ZSB0aW1lb3V0IGZvciBuZXh0IGpvYiAqLw0KPj4+ICsJCWRybV9zY2hl ZF9zdGFydF90aW1lb3V0KHNjaGVkKTsNCj4+PiAgICAJfQ0KPj4+ICAgIA0KPj4+IC0JLyogcXVl dWUgdGltZW91dCBmb3IgbmV4dCBqb2IgKi8NCj4+PiAtCXNwaW5fbG9ja19pcnFzYXZlKCZzY2hl ZC0+am9iX2xpc3RfbG9jaywgZmxhZ3MpOw0KPj4+IC0JZHJtX3NjaGVkX3N0YXJ0X3RpbWVvdXQo c2NoZWQpOw0KPj4+ICAgIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZzY2hlZC0+am9iX2xpc3Rf bG9jaywgZmxhZ3MpOw0KPj4+ICAgIA0KPj4+ICsJcmV0dXJuIGpvYjsNCj4+PiAgICB9DQo+Pj4g ICAgDQo+Pj4gICAgLyoqDQo+Pj4gQEAgLTY5OCwxMiArNjk2LDE4IEBAIHN0YXRpYyBpbnQgZHJt X3NjaGVkX21haW4odm9pZCAqcGFyYW0pDQo+Pj4gICAgCQlzdHJ1Y3QgZHJtX3NjaGVkX2ZlbmNl ICpzX2ZlbmNlOw0KPj4+ICAgIAkJc3RydWN0IGRybV9zY2hlZF9qb2IgKnNjaGVkX2pvYjsNCj4+ PiAgICAJCXN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlOw0KPj4+ICsJCXN0cnVjdCBkcm1fc2NoZWRf am9iICpjbGVhbnVwX2pvYiA9IE5VTEw7DQo+Pj4gICAgDQo+Pj4gICAgCQl3YWl0X2V2ZW50X2lu dGVycnVwdGlibGUoc2NoZWQtPndha2VfdXBfd29ya2VyLA0KPj4+IC0JCQkJCSAoZHJtX3NjaGVk X2NsZWFudXBfam9icyhzY2hlZCksDQo+Pj4gKwkJCQkJIChjbGVhbnVwX2pvYiA9IGRybV9zY2hl ZF9nZXRfY2xlYW51cF9qb2Ioc2NoZWQpKSB8fA0KPj4+ICAgIAkJCQkJICghZHJtX3NjaGVkX2Js b2NrZWQoc2NoZWQpICYmDQo+Pj4gICAgCQkJCQkgIChlbnRpdHkgPSBkcm1fc2NoZWRfc2VsZWN0 X2VudGl0eShzY2hlZCkpKSB8fA0KPj4+IC0JCQkJCSBrdGhyZWFkX3Nob3VsZF9zdG9wKCkpKTsN Cj4+PiArCQkJCQkga3RocmVhZF9zaG91bGRfc3RvcCgpKTsNCj4+DQo+PiBDYW4ndCB3ZSBqdXN0 IGNhbGwgZHJtX3NjaGVkX2NsZWFudXBfam9icyByaWdodCBoZXJlLCByZW1vdmUgYWxsIHRoZQ0K Pj4gY29uZGl0aW9ucyBpbiB3YWl0X2V2ZW50X2ludGVycnVwdGlibGUgKG1ha2UgaXQgYWx3YXlz IHRydWUpIGFuZCBhZnRlcg0KPj4gZHJtX3NjaGVkX2NsZWFudXBfam9icyBpcyBjYWxsZWQgdGVz dCBmb3IgYWxsIHRob3NlIGNvbmRpdGlvbnMgYW5kDQo+PiByZXR1cm4gdG8gc2xlZXAgaWYgdGhl eSBldmFsdWF0ZSB0byBmYWxzZSA/IGRybV9zY2hlZF9jbGVhbnVwX2pvYnMgaXMNCj4+IGNhbGxl ZCB1bmNvbmRpdGlvbmFsbHkgaW5zaWRlIHdhaXRfZXZlbnRfaW50ZXJydXB0aWJsZSBhbnl3YXku Li4gVGhpcyBpcw0KPj4gbW9yZSBvZiBhIHF1ZXN0aW9uIHRvIENocmlzdGlhbi4NCj4gQ2hyaXN0 aWFuIG1heSBrbm93IGJldHRlciB0aGFuIG1lLCBidXQgSSB0aGluayB0aG9zZSBjb25kaXRpb25z IG5lZWQgdG8NCj4gYmUgaW4gd2FpdF9ldmVudF9pbnRlcnJ1cHRpYmxlKCkgdG8gYXZvaWQgcmFj ZSBjb25kaXRpb25zLiBJZiB3ZSBzaW1wbHkNCj4gcmVwbGFjZSBhbGwgdGhlIGNvbmRpdGlvbnMg d2l0aCBhIGxpdGVyYWwgInRydWUiIHRoZW4NCj4gd2FpdF9ldmVudF9pbnRlcnJ1cHRpYmxlKCkg d2lsbCBuZXZlciBhY3R1YWxseSBzbGVlcC4NCj4NCj4gU3RldmUNCg0KWWVzIHlvdSByaWdodCwg aXQgd29uJ3Qgd29yayBhcyBJIG1pc3NlZCB0aGF0IGNvbmRpdGlvbiBpcyBldmFsdWF0ZWQgYXMg DQpmaXJzdCBzdGVwIGluIHdhaXRfZXZlbnRfaW50ZXJydXB0aWJsZSBiZWZvcmUgaXQgc2xlZXBz Lg0KDQpBbmRyZXkNCg0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWw=