From: "flichtenheld (Code Review)"
Date: Wed, 1 Apr 2026 12:29:03 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="UOb4F3FvL0Q="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Do not access
internals of ASN1_INTEGER to print hex of serial
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--UOb4F3FvL0Q=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change by plaisthos. ( http://gerr=
it.openvpn.net/c/openvpn/+/1589?usp=3Demail )
Change subject: Do not access internals of ASN1_INTEGER to print hex of ser=
ial
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/openvpn/ssl_verify_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1589/comment/ff897ba8_973ab117?usp=3D=
email :
PS4, Line 320: char *ret =3D format_hex_ex(buf, len_serial, 0, 1, ":", =
gc);
> For reference the change with BN_bn2hex: [=E2=80=A6]
Acknowledged
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1589?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5158fbb0762443ea4954e5745f520e83e019ed30
Gerrit-Change-Number: 1589
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Wed, 01 Apr 2026 12:29:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos
Comment-In-Reply-To: flichtenheld
--UOb4F3FvL0Q=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: plaisthos.
Patch set 5:Code-Review +2=
V=
iew Change
1 comment:
Acknowledged
To view, visit=
change =
1589. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5158fbb0762443ea4954e5745f5=
20e83e019ed30
Gerrit-Change-Number: 1589
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 12:29:03=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
=
--UOb4F3FvL0Q=--