From: Sean Anderson Date: Wed, 25 Dec 2019 00:41:32 -0500 Subject: [PATCH] clk: Check that ops of composite clock components exist, before calling In-Reply-To: References: Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/25/19 12:20 AM, Sean Anderson wrote: > int num_parents, struct clk *mux, > @@ -94,7 +106,9 @@ struct clk *clk_register_composite(struct device *dev, const char *name, > struct clk *clk; > struct clk_composite *composite; > int ret; > - struct clk_ops *composite_ops = &clk_composite_ops; > + > + if (!num_parents || (num_parents == 1 && !mux)) this should be if (!num_parents || (num_parents != 1 && !mux)) > + return ERR_PTR(-EINVAL); > > composite = kzalloc(sizeof(*composite), GFP_KERNEL); > if (!composite)