Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947F2C433EF for ; Tue, 28 Sep 2021 20:42:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74F0D6138E for ; Tue, 28 Sep 2021 20:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242226AbhI1Uo2 (ORCPT ); Tue, 28 Sep 2021 16:44:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46500 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242817AbhI1Uo0 (ORCPT ); Tue, 28 Sep 2021 16:44:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632861766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q/j8lu7tFVONNif5bHLiSAgHNxKsf9udcHGujsFhPw0=; b=Kl6HE9gvaIFKOzAuZMFEg366fqhmNoH0bdj6GvzOoRRQ8bchad6K60H+wrm6xTnDpEfMFg LCPW32kImaZ5qawxD6SsMygset9GajSLbfqdcpSZWCfwdH5VqjPlCcqUS7BoIRdWQa5gQh b++0SCM/U6mFlgj7Ru9LhZY9yYax+Lo= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-XBxQvH6YN6WwJnQjSjerOw-1; Tue, 28 Sep 2021 16:42:45 -0400 X-MC-Unique: XBxQvH6YN6WwJnQjSjerOw-1 Received: by mail-oo1-f70.google.com with SMTP id f2-20020a4a2202000000b0028c8a8074deso112755ooa.20 for ; Tue, 28 Sep 2021 13:42:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=q/j8lu7tFVONNif5bHLiSAgHNxKsf9udcHGujsFhPw0=; b=NvaaBh8IU7ioaNpRD1KIRGrqxMPcyPNctX5EzKjtAVenoYT/8LP1XOWpGN7ZeMsJUP dSTCBgIl75NvEWo/dlsAG1afFvC/+UGuvxofDBwnqntDqCPCZ1vBxG75GgOJ4tvMHJIi tqTXSkc0s54CLvmp4YprESpEf6pXqhpIwcIbUIIIMmvdX5+WyJ+f1keWU5k/hbHuiGub a3afx+eycr8CtW+eC6IsSk9GBC1kH68of5U/b/PZJFi0rFfnHyOxq+Y4p2SDgwabrLiw gKawS0Qc/wWCjk5lBmmjD8gHjeG3CgYhvcUUcMua8a6T4MQEuqBnmCAnoXIZvdyg+d7A +4cA== X-Gm-Message-State: AOAM532Yqb7SSmXQxgL03w8G+Efpl083DmZFgv6og/ksnoqo/5WkP4S1 mG+K5iihtPIC/i22XmLmthS8q8nA3LWo5+Bu1zBnBXx2JaVx+03BoqgCw94q16jdW57lp9RnBk8 YuXD77lh7YNT/K/ERpkRTwQ== X-Received: by 2002:a05:6808:287:: with SMTP id z7mr5155498oic.8.1632861764242; Tue, 28 Sep 2021 13:42:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwLFJvr/Tu92X62J2GJbZgkOlFxzve+GFpDXa35TsS80V/B6TDgkF0Ov4pbMtPZ4zTEjDCkg== X-Received: by 2002:a05:6808:287:: with SMTP id z7mr5155486oic.8.1632861764052; Tue, 28 Sep 2021 13:42:44 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id u12sm36724otq.20.2021.09.28.13.42.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Sep 2021 13:42:43 -0700 (PDT) Subject: Re: [PATCH] of: remove duplicate declaration of of_iomap() To: Randy Dunlap , robh+dt@kernel.org, frowand.list@gmail.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210928201214.294737-1-trix@redhat.com> From: Tom Rix Message-ID: Date: Tue, 28 Sep 2021 13:42:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 9/28/21 1:33 PM, Randy Dunlap wrote: > On 9/28/21 1:12 PM, trix@redhat.com wrote: >> From: Tom Rix >> >> A ranconfig produces this linker error > > randconfig .. on what arch, please? s390 > >> irq-al-fic.c:252: undefined reference to `of_iomap' >> >> The declaration of of_iomap() is dependent on OF >> The definition of of_iomap() is dependent on OF_ADDRESS >> These should match.  There are duplicate declarations >> of of_iomap(), remove of_iomap() and the >> of_address_to_resource() duplicate. >> >> Signed-off-by: Tom Rix >> --- >>   include/linux/of_address.h | 8 +------- >>   1 file changed, 1 insertion(+), 7 deletions(-) >> > > > thanks.