Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ngJIR-0005uO-2e for mharc-grub-devel@gnu.org; Mon, 18 Apr 2022 00:47:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngJIO-0005tp-Q6 for grub-devel@gnu.org; Mon, 18 Apr 2022 00:47:28 -0400 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]:35528) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngJIM-0006f0-HF for grub-devel@gnu.org; Mon, 18 Apr 2022 00:47:28 -0400 Received: by mail-qk1-x729.google.com with SMTP id y129so2539626qkb.2 for ; Sun, 17 Apr 2022 21:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=RLqwrGD2RNGdd0/4wnCgoXw+cPqBcnWr6Q3A8zLt414=; b=BnIbHS4tI5tqhqy4UUoLKsVKF+lqsj8nanaSLIHMDhnTh5Cscmt1F8mNfko5qE6haF q6nsB3k5WWJrILZNNscbQIyK2bw9xkNcwEh87th3S3kEfIxq5op+docrFY7v4hw23vmj S8a4q0CtnVgZDT1CwDy1UmcXQ72RIZUCjo0tLkg2LwtV1mK8D5+vbgDQI0OyqG6/DQN+ uhw0cQNcWT+oLcT31dkkz+u9tD3nXPtPF/t0u+LW/bjNSCWpGN6rCOKQ+64hjOj15d2z gVBrpBxInI74m8QuU3cX06KJUv+j/gbrhR2g+xHoaGd/rFGfN7xXya+1uIG+3q9WMr5/ c+yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=RLqwrGD2RNGdd0/4wnCgoXw+cPqBcnWr6Q3A8zLt414=; b=5tGUtm8SeuS8bnp74Js9L0JZmOO4VBSlBxWW7OLFCDGIsv2snnLbjZQvjz/+iygH4c wslVdNd8nZbeKOiM7/rVzjLX+sGkcU5tjI6pH5eb6/QmFzRed1ZbjjXKMHcxXvQQWZpE xOnw1qdk8vkEnD8nwhCywCCC7os15+AKSs39iKYo9WTKIrMZuy/be0YTcGrUF0RjHAgr Q+hTTnBc7ctzwtQqWYxGH5vamv/kXLHCWr9isWxrAeCwPr4p4jxP/ijZj+1Ln4q6lva4 tsBF5Zo/4NN8KynYPX4IdarM2VzduakkN0+tE2s1XxE7GLyJxiIhU6nXRPnqV9zDNv3G PfNg== X-Gm-Message-State: AOAM533mJ74xq5OYB3xHXSEgsvGnjfVyc9MBQ8mM4hASWYLl2pU3ZWsy 25fywtve64mf3P4JVl2MC4T6TKZjiEO44pi2 X-Google-Smtp-Source: ABdhPJyZbOXSOPIv12RR+0mDtwxM5gVIhYsIRfT2iGl6qbDsqXOtG77MIro35ogoaXvja7znPUvyVQ== X-Received: by 2002:a37:b481:0:b0:69b:eab8:1e79 with SMTP id d123-20020a37b481000000b0069beab81e79mr5551802qkf.453.1650257245111; Sun, 17 Apr 2022 21:47:25 -0700 (PDT) Received: from [10.41.0.198] ([37.218.244.249]) by smtp.gmail.com with ESMTPSA id bl14-20020a05620a1a8e00b0069e622e593esm3935087qkb.95.2022.04.17.21.47.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 21:47:24 -0700 (PDT) Message-ID: Date: Mon, 18 Apr 2022 04:47:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] tests: Give grub-fs-tester temp directory a better name Content-Language: en-US To: Daniel Kiper Cc: grub-devel@gnu.org References: <20220414163250.td6xup2x2d2qar3y@tomti.i.net-space.pl> From: Glenn Washburn In-Reply-To: <20220414163250.td6xup2x2d2qar3y@tomti.i.net-space.pl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::729; envelope-from=development@efficientek.com; helo=mail-qk1-x729.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2022 04:47:29 -0000 On 4/14/22 16:32, Daniel Kiper wrote: > On Sat, Apr 09, 2022 at 02:44:47AM +0000, Glenn Washburn wrote: >> Instead of "tmp" the name is prefixed by the name of the scripts (eg. >> grub-fs-tester). A timestamp is added in the name to allow for easily >> seeing a chronological sorting of runs and the name of the filesystem >> being tested. The random component is set to the minimal possible, 3 >> characters, because the timestamp should provide enough uniqueness. >> >> Signed-off-by: Glenn Washburn >> --- >> tests/util/grub-fs-tester.in | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in >> index 868199109f..02edcf897f 100644 >> --- a/tests/util/grub-fs-tester.in >> +++ b/tests/util/grub-fs-tester.in >> @@ -7,7 +7,7 @@ fs="$1" >> >> GRUBFSTEST="@builddir@/grub-fstest" >> >> -tempdir=`mktemp -d "${TMPDIR:-/tmp}/tmp.XXXXXXXXXX"` || >> +tempdir=`mktemp -d "${TMPDIR:-/tmp}/${0##*/}.$(date '+%Y%m%d%H%M%S%N').${fs}.XXX"` || > > I would just s/XXX/tmp/. Otherwise LGTM... mktemp fails with "too few X's in template" if the minimum number of X's (which is 3) are not provided. > For both patches Reviewed-by: Daniel Kiper > > Daniel Glenn