From: Lyude Paul Subject: Re: [PATCH 1/2] drm/nouveau: tegra: Fix NULL pointer dereference Date: Tue, 17 Sep 2019 14:11:37 -0400 Message-ID: References: <20190916143606.9272-1-thierry.reding@gmail.com> <20190916143606.9272-2-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190916143606.9272-2-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Thierry Reding , Ben Skeggs Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org Tm90IHN1cmUgSSB1bmRlcnN0YW5kIGVub3VnaCBhYm91dCB3aHkgQkFSMiBpcyBuZWVkZWQgb3Ig d2hhdCBpdCdzIHVzZWQgZm9yIHRvCmdpdmUgYSBwcm9wZXIgcmV2aWV3IG9uIHRoaXMgb25lLCBw cm9iYWJseSBiZXR0ZXIgdG8gd2FpdCBmb3Igc2tlZ2dzYiB0byB0YWtlCmEgbG9vayBhdCB0aGlz CgpPbiBNb24sIDIwMTktMDktMTYgYXQgMTY6MzYgKzAyMDAsIFRoaWVycnkgUmVkaW5nIHdyb3Rl Ogo+IEZyb206IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+Cj4gCj4gRmlsbCBp biBCQVIyIGNhbGxiYWNrcyBmb3IgaW5zdGFuY2UgbWVtb3J5LiBUaGVyZSdzIG5vIEJBUjIgb24g VGVncmEKPiBHUFVzLCBidXQgYnVmZmVycyBhcmUgYWxsIGluIHN5c3RlbSBtZW1vcnkgYW55d2F5 LCBzbyBqdXN0IHJldHVybiB0aGUKPiBwbGFpbiBhZGRyZXNzLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+Cj4gLS0tCj4gIC4uLi9kcm0vbm91 dmVhdS9udmttL3N1YmRldi9pbnN0bWVtL2drMjBhLmMgICB8IDMwICsrKysrKysrKysrKysrKysr KysKPiAgMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnZrbS9zdWJkZXYvaW5zdG1lbS9nazIwYS5jCj4gYi9k cml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udmttL3N1YmRldi9pbnN0bWVtL2drMjBhLmMKPiBpbmRl eCA5ODVmMjk5MGFiMGQuLmIwNDkzZjhkZjFmZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vbm91dmVhdS9udmttL3N1YmRldi9pbnN0bWVtL2drMjBhLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vbm91dmVhdS9udmttL3N1YmRldi9pbnN0bWVtL2drMjBhLmMKPiBAQCAtMjYxLDYgKzI2 MSwzNCBAQCBnazIwYV9pbnN0b2JqX3JlbGVhc2VfaW9tbXUoc3RydWN0IG52a21fbWVtb3J5ICpt ZW1vcnkpCj4gIAludmttX2x0Y19pbnZhbGlkYXRlKGx0Yyk7Cj4gIH0KPiAgCj4gK3N0YXRpYyB1 NjQKPiArZ2syMGFfaW5zdG9ial9iYXIyX2RtYShzdHJ1Y3QgbnZrbV9tZW1vcnkgKm1lbW9yeSkK PiArewo+ICsJc3RydWN0IGdrMjBhX2luc3RvYmpfZG1hICppb2JqID0gZ2syMGFfaW5zdG9ial9k bWEobWVtb3J5KTsKPiArCXU2NCBhZGRyID0gfjBVTEw7Cj4gKwo+ICsJaWYgKGdrMjBhX2luc3Rv YmpfYWNxdWlyZV9kbWEoJmlvYmotPmJhc2UubWVtb3J5KSkKPiArCQlhZGRyID0gZ2syMGFfaW5z dG9ial9hZGRyKCZpb2JqLT5iYXNlLm1lbW9yeSk7Cj4gKwo+ICsJZ2syMGFfaW5zdG9ial9yZWxl YXNlX2RtYSgmaW9iai0+YmFzZS5tZW1vcnkpOwo+ICsKPiArCXJldHVybiBhZGRyOwo+ICt9Cj4g Kwo+ICtzdGF0aWMgdTY0Cj4gK2drMjBhX2luc3RvYmpfYmFyMl9pb21tdShzdHJ1Y3QgbnZrbV9t ZW1vcnkgKm1lbW9yeSkKPiArewo+ICsJc3RydWN0IGdrMjBhX2luc3RvYmpfaW9tbXUgKmlvYmog PSBnazIwYV9pbnN0b2JqX2lvbW11KG1lbW9yeSk7Cj4gKwl1NjQgYWRkciA9IH4wVUxMOwo+ICsK PiArCWlmIChnazIwYV9pbnN0b2JqX2FjcXVpcmVfaW9tbXUoJmlvYmotPmJhc2UubWVtb3J5KSkK PiArCQlhZGRyID0gZ2syMGFfaW5zdG9ial9hZGRyKCZpb2JqLT5iYXNlLm1lbW9yeSk7Cj4gKwo+ ICsJZ2syMGFfaW5zdG9ial9yZWxlYXNlX2lvbW11KCZpb2JqLT5iYXNlLm1lbW9yeSk7Cj4gKwo+ ICsJcmV0dXJuIGFkZHI7Cj4gK30KPiArCj4gIHN0YXRpYyB1MzIKPiAgZ2syMGFfaW5zdG9ial9y ZDMyKHN0cnVjdCBudmttX21lbW9yeSAqbWVtb3J5LCB1NjQgb2Zmc2V0KQo+ICB7Cj4gQEAgLTM1 Myw2ICszODEsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG52a21fbWVtb3J5X2Z1bmMKPiAgZ2sy MGFfaW5zdG9ial9mdW5jX2RtYSA9IHsKPiAgCS5kdG9yID0gZ2syMGFfaW5zdG9ial9kdG9yX2Rt YSwKPiAgCS50YXJnZXQgPSBnazIwYV9pbnN0b2JqX3RhcmdldCwKPiArCS5iYXIyID0gZ2syMGFf aW5zdG9ial9iYXIyX2RtYSwKPiAgCS5wYWdlID0gZ2syMGFfaW5zdG9ial9wYWdlLAo+ICAJLmFk ZHIgPSBnazIwYV9pbnN0b2JqX2FkZHIsCj4gIAkuc2l6ZSA9IGdrMjBhX2luc3RvYmpfc2l6ZSwK PiBAQCAtMzY1LDYgKzM5NCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbnZrbV9tZW1vcnlfZnVu Ywo+ICBnazIwYV9pbnN0b2JqX2Z1bmNfaW9tbXUgPSB7Cj4gIAkuZHRvciA9IGdrMjBhX2luc3Rv YmpfZHRvcl9pb21tdSwKPiAgCS50YXJnZXQgPSBnazIwYV9pbnN0b2JqX3RhcmdldCwKPiArCS5i YXIyID0gZ2syMGFfaW5zdG9ial9iYXIyX2lvbW11LAo+ICAJLnBhZ2UgPSBnazIwYV9pbnN0b2Jq X3BhZ2UsCj4gIAkuYWRkciA9IGdrMjBhX2luc3RvYmpfYWRkciwKPiAgCS5zaXplID0gZ2syMGFf aW5zdG9ial9zaXplLAotLSAKQ2hlZXJzLAoJTHl1ZGUgUGF1bAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTm91dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVh dUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9ub3V2ZWF1