Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kIodZ-0006zU-0V for mharc-qemu-trivial@gnu.org; Thu, 17 Sep 2020 03:47:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIodX-0006xl-GD for qemu-trivial@nongnu.org; Thu, 17 Sep 2020 03:47:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kIodV-0004jG-Hl for qemu-trivial@nongnu.org; Thu, 17 Sep 2020 03:47:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600328840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ot9QkrYEDbGS3t+N9d85/lzjBh1N8X9TllGTFiyj/RQ=; b=V/rUKds8Rjr1hMvGFFWMH6b6R3SAamwfAVqlqH4TQONJkuM09loCl7HvYAaCej7kwKl8iy yfKhMISQd7rh9Mk7TefHRNYjRqJSMFohBdV4ern3LhEfZaLaBy1oQC1uMq0QA2bze4xFU5 SDpR7wizL9+kGAXiEyozJGzyXMqBfxE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-LwmDZYgGNFWOm7dgijetYA-1; Thu, 17 Sep 2020 03:47:16 -0400 X-MC-Unique: LwmDZYgGNFWOm7dgijetYA-1 Received: by mail-wr1-f69.google.com with SMTP id f18so536029wrv.19 for ; Thu, 17 Sep 2020 00:47:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Ot9QkrYEDbGS3t+N9d85/lzjBh1N8X9TllGTFiyj/RQ=; b=p53p6RZVFFQ7+F5jfr5XZZwuH1teUljSryGZ64ta9KHOPpdyrNi4M+DwoHMjP0YN+L VfZIEJ0die76riuZKUda9QVvJ9dLOXN9ZsmhJin7bkcVtMKjUYkiCQz4ALpO/ehxW/Dk nonR7lxYpxfuqOZscHrL1NdDHIIbVcHjzxCBDBsXfSM4P+pOYIhAcyvOytlfEQRil5Yj bau7SbKz5hDyFzge+0G9cRrPO1smVoZUbNG2D40fpztyu3dC5G6H1N3ppUnfFqQ+Gaye bWAWqqL6cO5DWdHgsNCpBwUwnn6DFJ9pcIGgoevtlSm/mA8Tmoz3dFhZWzAb5Sb3L/0b ZwHw== X-Gm-Message-State: AOAM533BOegJ98ZRKipE9nv3prhPj7QWc5eYQciLNn1XA4hNdnn4O+gW j3IY04n6e52YPcZ3un2NI2VZo1yYhrG4k1f8fZEIYZ0PUJQQRRi7tgRDCjyGwgrcnyh37FZ6MNa VdFW1n6qinu1kk38Ysg== X-Received: by 2002:a5d:68d1:: with SMTP id p17mr29531125wrw.378.1600328835409; Thu, 17 Sep 2020 00:47:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKwJx9stU1EiVE9OEJMzQOyi4Qy7d/9RHeSn5Ck2s//GJCqdC+FI7/mRpUOonLRTZ4vwMl0A== X-Received: by 2002:a5d:68d1:: with SMTP id p17mr29531112wrw.378.1600328835220; Thu, 17 Sep 2020 00:47:15 -0700 (PDT) Received: from [192.168.1.36] (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id z9sm10121544wmg.46.2020.09.17.00.47.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2020 00:47:14 -0700 (PDT) Subject: Re: [PATCH v2] migration: Silence compiler warning in global_state_store_running() To: Thomas Huth , Juan Quintela , "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Paolo Bonzini References: <20200917074344.168785-1-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Thu, 17 Sep 2020 09:47:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200917074344.168785-1-thuth@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.003 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/17 02:01:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.062, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 07:47:23 -0000 On 9/17/20 9:43 AM, Thomas Huth wrote: > GCC 9.3.0 on Ubuntu complains: > > In file included from /usr/include/string.h:495, > from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, > from ../migration/global_state.c:13: > In function ‘strncpy’, > inlined from ‘global_state_store_running’ at ../migration/global_state.c:47:5: > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: > ‘__builtin_strncpy’ specified bound 100 equals destination size [-Werror=stringop-truncation] > 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > ... but we apparently really want to do a strncpy here - the size is already > checked with the assert() statement right in front of it. To silence the > warning, simply replace it with our strpadcpy() function. > > Signed-off-by: Thomas Huth > --- > v2: Use strpadcpy instead of QEMU_NONSTRING (and yes, this time it seems > to really silence the compiler warning :-)) > > migration/global_state.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/migration/global_state.c b/migration/global_state.c > index 25311479a4..a33947ca32 100644 > --- a/migration/global_state.c > +++ b/migration/global_state.c > @@ -44,8 +44,8 @@ void global_state_store_running(void) > { > const char *state = RunState_str(RUN_STATE_RUNNING); > assert(strlen(state) < sizeof(global_state.runstate)); > - strncpy((char *)global_state.runstate, > - state, sizeof(global_state.runstate)); > + strpadcpy((char *)global_state.runstate, sizeof(global_state.runstate), > + state, '\0'); https://www.mail-archive.com/qemu-block@nongnu.org/msg44925.html ;) > } > > bool global_state_received(void) >