Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 789CBC3A5A9 for ; Mon, 4 May 2020 08:38:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 567D6206B9 for ; Mon, 4 May 2020 08:38:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728273AbgEDIi4 convert rfc822-to-8bit (ORCPT ); Mon, 4 May 2020 04:38:56 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:43859 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726445AbgEDIiz (ORCPT ); Mon, 4 May 2020 04:38:55 -0400 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.69 with qID 0448cePjB005287, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexmb06.realtek.com.tw[172.21.6.99]) by rtits2.realtek.com.tw (8.15.2/2.66/5.86) with ESMTPS id 0448cePjB005287 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 4 May 2020 16:38:40 +0800 Received: from RTEXMB04.realtek.com.tw (172.21.6.97) by RTEXMB06.realtek.com.tw (172.21.6.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Mon, 4 May 2020 16:38:39 +0800 Received: from RTEXMB04.realtek.com.tw ([fe80::8001:f5f5:a41e:f8d4]) by RTEXMB04.realtek.com.tw ([fe80::8001:f5f5:a41e:f8d4%3]) with mapi id 15.01.1779.005; Mon, 4 May 2020 16:38:39 +0800 From: Tony Chuang To: Kalle Valo , Sebastian Andrzej Siewior CC: "linux-wireless@vger.kernel.org" , Pkshih Subject: RE: [PATCH v3 5/8] rtw88: 8723d: 11N chips don't support LDPC Thread-Topic: [PATCH v3 5/8] rtw88: 8723d: 11N chips don't support LDPC Thread-Index: AQHWHgyQMqCUEkg1Tk2+cl6WpckpnaiQ+S4AgACXe8GABhHrIA== Date: Mon, 4 May 2020 08:38:39 +0000 Message-ID: References: <20200429095656.19315-1-yhchuang@realtek.com> <20200429095656.19315-6-yhchuang@realtek.com> <20200430105418.v3s5obb3skhv4732@linutronix.de> <877dxxkx0z.fsf@codeaurora.org> In-Reply-To: <877dxxkx0z.fsf@codeaurora.org> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.68.175] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > Sebastian Andrzej Siewior writes: > > > On 2020-04-29 17:56:53 [+0800], yhchuang@realtek.com wrote: > >> --- a/drivers/net/wireless/realtek/rtw88/main.c > >> +++ b/drivers/net/wireless/realtek/rtw88/main.c > >> @@ -933,7 +933,7 @@ static void rtw_init_ht_cap(struct rtw_dev > *rtwdev, > >> ht_cap->cap = 0; > >> ht_cap->cap |= IEEE80211_HT_CAP_SGI_20 | > >> IEEE80211_HT_CAP_MAX_AMSDU | > >> - IEEE80211_HT_CAP_LDPC_CODING | > >> + (rtw_chip_wcpu_11ac(rtwdev) ? > IEEE80211_HT_CAP_LDPC_CODING : 0) | > >> (1 << IEEE80211_HT_CAP_RX_STBC_SHIFT); > > > > What about > > > > ht_cap->cap = IEEE80211_HT_CAP_SGI_20 | > > IEEE80211_HT_CAP_MAX_AMSDU | > > (1 << IEEE80211_HT_CAP_RX_STBC_SHIFT); > > if (rtw_chip_wcpu_11ac(rtwdev)) > > ht_cap->cap |= IEEE80211_HT_CAP_LDPC_CODING; > > instead? > > Yes, that's much better. I even missed the '?' operator in my own review > as it was not that visible. > Will fix that in v4, thanks. Yen-Hsuan