From: "flichtenheld (Code Review)" Date: Thu, 21 Nov 2024 17:20:21 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., samuli@...515..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="9F+3pU1RQrA="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mattock Cc: plaisthos , openvpn-devel --9F+3pU1RQrA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/811?usp=3Demail ) Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 2: Code-Review-1 (6 comments) File tests/lwip_client_up.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/1843a1b0_52ead016 : PS2, Line 20: echo "Waiting for fping to exit ($count/$maxcount)" mixed indent over the next three lines File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/c505db89_06e4ea15 : PS2, Line 6: if echo "$test_name"|grep _lwip > /dev/null 2>&1; then is "grep -q" portable? That would be nicer here. http://gerrit.openvpn.net/c/openvpn/+/811/comment/81b73860_900e7d09 : PS2, Line 8: return 1 tab indent http://gerrit.openvpn.net/c/openvpn/+/811/comment/2d16907b_24ca5a14 : PS2, Line 41: return 0 tab indent http://gerrit.openvpn.net/c/openvpn/+/811/comment/ae1b215d_2f625303 : PS2, Line 162: if test -r ./lwipovpn; then Would be nice to be able to override this with something like `$LWIPOVPN`. = Definitely do not want to copy that executable around all the time. http://gerrit.openvpn.net/c/openvpn/+/811/comment/b99be658_67323adc : PS2, Line 189: if echo "$test_name"|grep _lwip > /dev/null; then another case for grep -q -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 2 Gerrit-Owner: mattock Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: mattock Gerrit-Comment-Date: Thu, 21 Nov 2024 17:20:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --9F+3pU1RQrA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: mattock, plaisthos.

Patch set 2:Code-Review -1=

Vi= ew Change

6 comments:

  • File tests/lwip_client_up.sh:

  • File tests/t_ser= ver_null_client.sh:

To view, v= isit chan= ge 811. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca= 6b8c029f0d250
Gerrit-Change-Number: 811
Gerrit-PatchSet: 2
Gerrit-Owner: mattock <samuli@...515...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: mattock <samuli@...515...= >
Gerrit-Comment-Date: Thu, 21 Nov 2024 17:20:21= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--9F+3pU1RQrA=--