Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F2D4C2D0E7 for ; Fri, 27 Mar 2020 02:11:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1091B2074D for ; Fri, 27 Mar 2020 02:11:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KHattziT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1091B2074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHeSe-0008ND-6g for qemu-devel@archiver.kernel.org; Thu, 26 Mar 2020 22:11:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47192) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHeRp-0007le-HC for qemu-devel@nongnu.org; Thu, 26 Mar 2020 22:10:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHeRo-0003nO-GL for qemu-devel@nongnu.org; Thu, 26 Mar 2020 22:10:13 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:47131) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jHeRo-0003mt-CQ for qemu-devel@nongnu.org; Thu, 26 Mar 2020 22:10:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585275012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jTS/A/r8FwJx0pyyRMmMuWCyUhQ3Ag9+MhFwgoRZJk4=; b=KHattziT+8DHj4W3gxpzTil7EO/szwVw8AmH+2QlJpSHyQIz2jqwhr64Hr8Ylx0Gu061K5 gSr030/Lj0UdAQdHB9LijItqrjfOitesNWPshhd6yoS+gGSrXFKZwCJvF2NybWOkRhKtSB 4Wx4kgc0mlQB3f23b0l+sPX6fqjBwNM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-66-qiIe98uSNde8W6AbwvDoAQ-1; Thu, 26 Mar 2020 22:10:10 -0400 X-MC-Unique: qiIe98uSNde8W6AbwvDoAQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E1F67107ACC7; Fri, 27 Mar 2020 02:10:08 +0000 (UTC) Received: from [10.72.13.132] (ovpn-13-132.pek2.redhat.com [10.72.13.132]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F8FE60304; Fri, 27 Mar 2020 02:10:06 +0000 (UTC) Subject: Re: [PATCH] hw/net/i82596.c: Avoid reading off end of buffer in i82596_receive() To: Peter Maydell References: <20200312201638.6375-1-peter.maydell@linaro.org> From: Jason Wang Message-ID: Date: Fri, 27 Mar 2020 10:10:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Helge Deller , QEMU Developers , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020/3/27 =E4=B8=8A=E5=8D=885:11, Peter Maydell wrote: > On Tue, 17 Mar 2020 at 06:13, Jason Wang wrote: >> On 2020/3/13 =E4=B8=8A=E5=8D=884:16, Peter Maydell wrote: >>> The i82596_receive() function attempts to pass the guest a buffer >>> which is effectively the concatenation of the data it is passed and a >>> 4 byte CRC value. However, rather than implementing this as "write >>> the data; then write the CRC" it instead bumps the length value of >>> the data by 4, and writes 4 extra bytes from beyond the end of the >>> buffer, which it then overwrites with the CRC. It also assumed that >>> we could always fit all four bytes of the CRC into the final receive >>> buffer, which might not be true if the CRC needs to be split over two >>> receive buffers. >> Applied. > Hi Jason -- this doesn't seem to have reached master yet. > Has it gotten lost somewhere along the line? > > thanks > -- PMM Nope, it's in my queue. I will send a pull request shortly. Thanks