From: "cron2 (Code Review)" Date: Sat, 30 Dec 2023 16:00:04 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="umwBU3yoDmY="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --umwBU3yoDmY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/471?usp=3Demail ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Add test_ssl unit test and test export of PEM to file ...................................................................... Patch Set 3: Code-Review-2 (1 comment) Patchset: PS3: this fails the GHA mingw builds with ``` /home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/test_ssl.c: In= function =E2=80=98crypto_pem_encode_certificate=E2=80=99: Error: /home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/test_ss= l.c:112:5: error: implicit declaration of function =E2=80=98backend_x509_wr= ite_pem=E2=80=99 [-Werror=3Dimplicit-function-declaration] 112 | backend_x509_write_pem(cert, tmpfile); | ^~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors ``` (see https://github.com/cron2/openvpn/actions/runs/7365003797/job/200458928= 88) so it can't go in yet. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Gerrit-Change-Number: 471 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Sat, 30 Dec 2023 16:00:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --umwBU3yoDmY= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 3:Code-Review -2=

The change is no longer submittable: Code-Review is unsatisfied now.=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #3:

      this fails the GHA mingw builds with

      ```
      = /home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/test_ssl.c: In f= unction =E2=80=98crypto_pem_encode_certificate=E2=80=99:
      Error: /home/= runner/work/openvpn/openvpn/tests/unit_tests/openvpn/test_ssl.c:112:5: erro= r: implicit declaration of function =E2=80=98backend_x509_write_pem=E2=80= =99 [-Werror=3Dimplicit-function-declaration]
      112 | backend_x509= _write_pem(cert, tmpfile);
      | ^~~~~~~~~~~~~~~~~~~~~~
      cc1= : all warnings being treated as errors
      ```

      (see https://github.com/cron2/openvpn/ac= tions/runs/7365003797/job/20045892888) so it can't go in yet.

    • <= /ul>

    To view, visit change 471. To unsubscribe, or for help writing = mail filters, visit settings= .

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c= 77ba0d6fa3381
    Gerrit-Change-Number: 471
    Gerrit-PatchSet: 3
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Comment-Date: Sat, 30 Dec 2023 16:00:04= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --umwBU3yoDmY=--