From: Felix Kuehling Subject: Re: [PATCH 09/16] drm/amdkfd: Use wait_queue_t to implement event waiting Date: Wed, 25 Oct 2017 12:02:46 -0400 Message-ID: References: <1508545400-24338-1-git-send-email-Felix.Kuehling@amd.com> <1508545400-24338-10-git-send-email-Felix.Kuehling@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-CA List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Oded Gabbay Cc: Kent Russell , amd-gfx list CgpPbiAyMDE3LTEwLTI1IDA2OjI4IEFNLCBPZGVkIEdhYmJheSB3cm90ZToKPiBPbiBTYXQsIE9j dCAyMSwgMjAxNyBhdCAzOjIzIEFNLCBGZWxpeCBLdWVobGluZyA8RmVsaXguS3VlaGxpbmdAYW1k LmNvbT4gd3JvdGU6Cj4+IFNpZ25lZC1vZmYtYnk6IEtlbnQgUnVzc2VsbCA8a2VudC5ydXNzZWxs QGFtZC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IEZlbGl4IEt1ZWhsaW5nIDxGZWxpeC5LdWVobGlu Z0BhbWQuY29tPgo+IEkgd291bGQgbGlrZSBzb21lIG1vcmUgZXhwbGFuYXRpb24gaW4gdGhlIGNv bW1pdCBtZXNzYWdlIGFib3V0IHRoaXMgY2hhbmdlLgo+IC0gV2hhdCBpcyB0aGUgZ2VuZXJhbCBp ZGVhIGluIHRoaXMgc29sdXRpb24uCj4gLSBXaHkgaXQgd2FzIGRvbmUsIGkuZS4gd2hhdCBpcyB0 aGUgaW1wcm92ZW1lbnQKCkl0J3MgbW9zdGx5IGFib3V0IG5vdCBkdXBsaWNhdGluZyB0aGUgZXhp c3Rpbmcgd2FpdCBxdWV1ZSBtZWNoYW5pc20uIE5vdApzdXJlIGhvdyBtdWNoIGVsc2UgdGhlcmUg aXMgdG8gc2F5IGFib3V0IGl0LgoKPiBUaGFua3MsCj4gT2RlZAo+Cj4KPj4gLS0tCj4+ICBkcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZXZlbnRzLmMgfCA1MyArKysrKysrKysrKy0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9ldmVu dHMuaCB8ICAzICstCj4+ICAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDM3IGRl bGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQv a2ZkX2V2ZW50cy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2V2ZW50cy5jCj4+ IGluZGV4IDk0OWI4MGEuLmYxNzgyNDggMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1ka2ZkL2tmZF9ldmVudHMuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtm ZC9rZmRfZXZlbnRzLmMKPj4gQEAgLTMzLDIyICszMywxMiBAQAo+PiAgI2luY2x1ZGUgPGxpbnV4 L2RldmljZS5oPgo+Pgo+PiAgLyoKPj4gLSAqIEEgdGFzayBjYW4gb25seSBiZSBvbiBhIHNpbmds ZSB3YWl0X3F1ZXVlIGF0IGEgdGltZSwgYnV0IHdlIG5lZWQgdG8gc3VwcG9ydAo+PiAtICogd2Fp dGluZyBvbiBtdWx0aXBsZSBldmVudHMgKGFueS9hbGwpLgo+PiAtICogSW5zdGVhZCBvZiBlYWNo IGV2ZW50IHNpbXBseSBoYXZpbmcgYSB3YWl0X3F1ZXVlIHdpdGggc2xlZXBpbmcgdGFza3MsIGl0 Cj4+IC0gKiBoYXMgYSBzaW5nbHktbGlua2VkIGxpc3Qgb2YgdGFza3MuCj4+IC0gKiBBIHRocmVh ZCB0aGF0IHdhbnRzIHRvIHNsZWVwIGNyZWF0ZXMgYW4gYXJyYXkgb2YgdGhlc2UsIG9uZSBmb3Ig ZWFjaCBldmVudAo+PiAtICogYW5kIGFkZHMgb25lIHRvIGVhY2ggZXZlbnQncyB3YWl0ZXIgY2hh aW4uCj4+ICsgKiBXcmFwcGVyIGFyb3VuZCB3YWl0X3F1ZXVlX2VudHJ5X3QKPj4gICAqLwo+PiAg c3RydWN0IGtmZF9ldmVudF93YWl0ZXIgewo+PiAtICAgICAgIHN0cnVjdCBsaXN0X2hlYWQgd2Fp dGVyczsKPj4gLSAgICAgICBzdHJ1Y3QgdGFza19zdHJ1Y3QgKnNsZWVwaW5nX3Rhc2s7Cj4+IC0K Pj4gLSAgICAgICAvKiBUcmFuc2l0aW9ucyB0byB0cnVlIHdoZW4gdGhlIGV2ZW50IHRoaXMgYmVs b25ncyB0byBpcyBzaWduYWxlZC4gKi8KPj4gLSAgICAgICBib29sIGFjdGl2YXRlZDsKPj4gLQo+ PiAtICAgICAgIC8qIEV2ZW50ICovCj4+IC0gICAgICAgc3RydWN0IGtmZF9ldmVudCAqZXZlbnQ7 Cj4+ICsgICAgICAgd2FpdF9xdWV1ZV9lbnRyeV90IHdhaXQ7Cj4+ICsgICAgICAgc3RydWN0IGtm ZF9ldmVudCAqZXZlbnQ7IC8qIEV2ZW50IHRvIHdhaXQgZm9yICovCj4+ICsgICAgICAgYm9vbCBh Y3RpdmF0ZWQ7ICAgICAgICAgIC8qIEJlY29tZXMgdHJ1ZSB3aGVuIGV2ZW50IGlzIHNpZ25hbGVk ICovCj4+ICB9Owo+Pgo+PiAgLyoKPj4gQEAgLTM0NCwxNyArMzM0LDEyIEBAIHZvaWQga2ZkX2V2 ZW50X2luaXRfcHJvY2VzcyhzdHJ1Y3Qga2ZkX3Byb2Nlc3MgKnApCj4+Cj4+ICBzdGF0aWMgdm9p ZCBkZXN0cm95X2V2ZW50KHN0cnVjdCBrZmRfcHJvY2VzcyAqcCwgc3RydWN0IGtmZF9ldmVudCAq ZXYpCj4+ICB7Cj4+IC0gICAgICAgLyogV2FrZSB1cCBwZW5kaW5nIHdhaXRlcnMuIFRoZXkgd2ls bCByZXR1cm4gZmFpbHVyZSAqLwo+PiAtICAgICAgIHdoaWxlICghbGlzdF9lbXB0eSgmZXYtPndh aXRlcnMpKSB7Cj4+IC0gICAgICAgICAgICAgICBzdHJ1Y3Qga2ZkX2V2ZW50X3dhaXRlciAqd2Fp dGVyID0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgbGlzdF9maXJzdF9lbnRyeSgmZXYtPndh aXRlcnMsIHN0cnVjdCBrZmRfZXZlbnRfd2FpdGVyLAo+PiAtICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHdhaXRlcnMpOwo+PiArICAgICAgIHN0cnVjdCBrZmRfZXZlbnRf d2FpdGVyICp3YWl0ZXI7Cj4+Cj4+ICsgICAgICAgLyogV2FrZSB1cCBwZW5kaW5nIHdhaXRlcnMu IFRoZXkgd2lsbCByZXR1cm4gZmFpbHVyZSAqLwo+PiArICAgICAgIGxpc3RfZm9yX2VhY2hfZW50 cnkod2FpdGVyLCAmZXYtPndxLmhlYWQsIHdhaXQuZW50cnkpCj4+ICAgICAgICAgICAgICAgICB3 YWl0ZXItPmV2ZW50ID0gTlVMTDsKPj4gLSAgICAgICAgICAgICAgIC8qIF9pbml0IGJlY2F1c2Ug ZnJlZV93YWl0ZXJzIHdpbGwgY2FsbCBsaXN0X2RlbCAqLwo+PiAtICAgICAgICAgICAgICAgbGlz dF9kZWxfaW5pdCgmd2FpdGVyLT53YWl0ZXJzKTsKPj4gLSAgICAgICAgICAgICAgIHdha2VfdXBf cHJvY2Vzcyh3YWl0ZXItPnNsZWVwaW5nX3Rhc2spOwo+PiAtICAgICAgIH0KPj4gKyAgICAgICB3 YWtlX3VwX2FsbCgmZXYtPndxKTsKPj4KPj4gICAgICAgICBpZiAoZXYtPnNpZ25hbF9wYWdlKSB7 Cj4+ICAgICAgICAgICAgICAgICByZWxlYXNlX2V2ZW50X25vdGlmaWNhdGlvbl9zbG90KGV2LT5z aWduYWxfcGFnZSwKPj4gQEAgLTQyNCw3ICs0MDksNyBAQCBpbnQga2ZkX2V2ZW50X2NyZWF0ZShz dHJ1Y3QgZmlsZSAqZGV2a2ZkLCBzdHJ1Y3Qga2ZkX3Byb2Nlc3MgKnAsCj4+ICAgICAgICAgZXYt PmF1dG9fcmVzZXQgPSBhdXRvX3Jlc2V0Owo+PiAgICAgICAgIGV2LT5zaWduYWxlZCA9IGZhbHNl Owo+Pgo+PiAtICAgICAgIElOSVRfTElTVF9IRUFEKCZldi0+d2FpdGVycyk7Cj4+ICsgICAgICAg aW5pdF93YWl0cXVldWVfaGVhZCgmZXYtPndxKTsKPj4KPj4gICAgICAgICAqZXZlbnRfcGFnZV9v ZmZzZXQgPSAwOwo+Pgo+PiBAQCAtNDgyLDE5ICs0NjcsMTQgQEAgaW50IGtmZF9ldmVudF9kZXN0 cm95KHN0cnVjdCBrZmRfcHJvY2VzcyAqcCwgdWludDMyX3QgZXZlbnRfaWQpCj4+ICBzdGF0aWMg dm9pZCBzZXRfZXZlbnQoc3RydWN0IGtmZF9ldmVudCAqZXYpCj4+ICB7Cj4+ICAgICAgICAgc3Ry dWN0IGtmZF9ldmVudF93YWl0ZXIgKndhaXRlcjsKPj4gLSAgICAgICBzdHJ1Y3Qga2ZkX2V2ZW50 X3dhaXRlciAqbmV4dDsKPj4KPj4gICAgICAgICAvKiBBdXRvIHJlc2V0IGlmIHRoZSBsaXN0IGlz IG5vbi1lbXB0eSBhbmQgd2UncmUgd2FraW5nIHNvbWVvbmUuICovCj4+IC0gICAgICAgZXYtPnNp Z25hbGVkID0gIWV2LT5hdXRvX3Jlc2V0IHx8IGxpc3RfZW1wdHkoJmV2LT53YWl0ZXJzKTsKPj4g KyAgICAgICBldi0+c2lnbmFsZWQgPSAhZXYtPmF1dG9fcmVzZXQgfHwgIXdhaXRxdWV1ZV9hY3Rp dmUoJmV2LT53cSk7Cj4gVGhpcyBsaW5lIGdpdmVzIGEgd2FybmluZyBpbiB0aGUgY2hlY2twYXRj aCBzY3JpcHQuIFBlciBMaW51cydzIHBhdGNoCj4gKGh0dHA6Ly93d3cuc3Bpbmljcy5uZXQvbGlz dHMvbW0tY29tbWl0cy9tc2cxMTE2NjAuaHRtbCksIHBsZWFzZSBhZGQgYQo+IGNvbW1lbnQgZXhw bGFpbmluZyB0aGUgdXNlIG9mIHdhaXRxdWV1ZV9hY3RpdmUgYW5kIHdoeSBpdHMgbm90IHJhY3kK PiB3aXRoIHRoZSBjYWxsZXIuCgpUaGVyZSBpcyBhIGNvbW1lbnQsIGJ1dCBjaGVja3BhdGNoIHN0 aWxsIGNvbXBsYWlucy4gSSBjYW4gYWRkIG1vcmUgdG8KdGhlIGNvbW1lbnQsIGJ1dCBub3Qgc3Vy ZSB0aGF0IHdpbGwgZml4IHRoZSB3YXJuaW5nLgoKUmVnYXJkcywKwqAgRmVsaXgKCj4KPiBPZGVk Cj4KPj4gLSAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUod2FpdGVyLCBuZXh0LCAmZXYt PndhaXRlcnMsIHdhaXRlcnMpIHsKPj4gKyAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KHdhaXRl ciwgJmV2LT53cS5oZWFkLCB3YWl0LmVudHJ5KQo+PiAgICAgICAgICAgICAgICAgd2FpdGVyLT5h Y3RpdmF0ZWQgPSB0cnVlOwo+Pgo+PiAtICAgICAgICAgICAgICAgLyogX2luaXQgYmVjYXVzZSBm cmVlX3dhaXRlcnMgd2lsbCBjYWxsIGxpc3RfZGVsICovCj4+IC0gICAgICAgICAgICAgICBsaXN0 X2RlbF9pbml0KCZ3YWl0ZXItPndhaXRlcnMpOwo+PiAtCj4+IC0gICAgICAgICAgICAgICB3YWtl X3VwX3Byb2Nlc3Mod2FpdGVyLT5zbGVlcGluZ190YXNrKTsKPj4gLSAgICAgICB9Cj4+ICsgICAg ICAgd2FrZV91cF9hbGwoJmV2LT53cSk7Cj4+ICB9Cj4+Cj4+ICAvKiBBc3N1bWVzIHRoYXQgcCBp cyBjdXJyZW50LiAqLwo+PiBAQCAtNjE0LDggKzU5NCw3IEBAIHN0YXRpYyBzdHJ1Y3Qga2ZkX2V2 ZW50X3dhaXRlciAqYWxsb2NfZXZlbnRfd2FpdGVycyh1aW50MzJfdCBudW1fZXZlbnRzKQo+PiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0ZQX0tFUk5FTCk7Cj4+Cj4+ ICAgICAgICAgZm9yIChpID0gMDsgKGV2ZW50X3dhaXRlcnMpICYmIChpIDwgbnVtX2V2ZW50cykg OyBpKyspIHsKPj4gLSAgICAgICAgICAgICAgIElOSVRfTElTVF9IRUFEKCZldmVudF93YWl0ZXJz W2ldLndhaXRlcnMpOwo+PiAtICAgICAgICAgICAgICAgZXZlbnRfd2FpdGVyc1tpXS5zbGVlcGlu Z190YXNrID0gY3VycmVudDsKPj4gKyAgICAgICAgICAgICAgIGluaXRfd2FpdCgmZXZlbnRfd2Fp dGVyc1tpXS53YWl0KTsKPj4gICAgICAgICAgICAgICAgIGV2ZW50X3dhaXRlcnNbaV0uYWN0aXZh dGVkID0gZmFsc2U7Cj4+ICAgICAgICAgfQo+Pgo+PiBAQCAtNjQ2LDcgKzYyNSw3IEBAIHN0YXRp YyB2b2lkIGluaXRfZXZlbnRfd2FpdGVyX2FkZF90b193YWl0bGlzdChzdHJ1Y3Qga2ZkX2V2ZW50 X3dhaXRlciAqd2FpdGVyKQo+PiAgICAgICAgICAqIHdhaXQgb24gdGhpcyBldmVudC4KPj4gICAg ICAgICAgKi8KPj4gICAgICAgICBpZiAoIXdhaXRlci0+YWN0aXZhdGVkKQo+PiAtICAgICAgICAg ICAgICAgbGlzdF9hZGQoJndhaXRlci0+d2FpdGVycywgJmV2LT53YWl0ZXJzKTsKPj4gKyAgICAg ICAgICAgICAgIGFkZF93YWl0X3F1ZXVlKCZldi0+d3EsICZ3YWl0ZXItPndhaXQpOwo+PiAgfQo+ Pgo+PiAgLyogdGVzdF9ldmVudF9jb25kaXRpb24gLSBUZXN0IGNvbmRpdGlvbiBvZiBldmVudHMg YmVpbmcgd2FpdGVkIGZvcgo+PiBAQCAtNzM2LDcgKzcxNSw5IEBAIHN0YXRpYyB2b2lkIGZyZWVf d2FpdGVycyh1aW50MzJfdCBudW1fZXZlbnRzLCBzdHJ1Y3Qga2ZkX2V2ZW50X3dhaXRlciAqd2Fp dGVycykKPj4gICAgICAgICB1aW50MzJfdCBpOwo+Pgo+PiAgICAgICAgIGZvciAoaSA9IDA7IGkg PCBudW1fZXZlbnRzOyBpKyspCj4+IC0gICAgICAgICAgICAgICBsaXN0X2RlbCgmd2FpdGVyc1tp XS53YWl0ZXJzKTsKPj4gKyAgICAgICAgICAgICAgIGlmICh3YWl0ZXJzW2ldLmV2ZW50KQo+PiAr ICAgICAgICAgICAgICAgICAgICAgICByZW1vdmVfd2FpdF9xdWV1ZSgmd2FpdGVyc1tpXS5ldmVu dC0+d3EsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZ3YWl0 ZXJzW2ldLndhaXQpOwo+Pgo+PiAgICAgICAgIGtmcmVlKHdhaXRlcnMpOwo+PiAgfQo+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2V2ZW50cy5oIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2V2ZW50cy5oCj4+IGluZGV4IDI4ZjY4MzguLjk2Zjkx MjIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9ldmVudHMu aAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZXZlbnRzLmgKPj4gQEAg LTI3LDYgKzI3LDcgQEAKPj4gICNpbmNsdWRlIDxsaW51eC9oYXNodGFibGUuaD4KPj4gICNpbmNs dWRlIDxsaW51eC90eXBlcy5oPgo+PiAgI2luY2x1ZGUgPGxpbnV4L2xpc3QuaD4KPj4gKyNpbmNs dWRlIDxsaW51eC93YWl0Lmg+Cj4+ICAjaW5jbHVkZSAia2ZkX3ByaXYuaCIKPj4gICNpbmNsdWRl IDx1YXBpL2xpbnV4L2tmZF9pb2N0bC5oPgo+Pgo+PiBAQCAtNTYsNyArNTcsNyBAQCBzdHJ1Y3Qg a2ZkX2V2ZW50IHsKPj4KPj4gICAgICAgICBpbnQgdHlwZTsKPj4KPj4gLSAgICAgICBzdHJ1Y3Qg bGlzdF9oZWFkIHdhaXRlcnM7IC8qIExpc3Qgb2Yga2ZkX2V2ZW50X3dhaXRlciBieSB3YWl0ZXJz LiAqLwo+PiArICAgICAgIHdhaXRfcXVldWVfaGVhZF90IHdxOyAvKiBMaXN0IG9mIGV2ZW50IHdh aXRlcnMuICovCj4+Cj4+ICAgICAgICAgLyogT25seSBmb3Igc2lnbmFsIGV2ZW50cy4gKi8KPj4g ICAgICAgICBzdHJ1Y3Qgc2lnbmFsX3BhZ2UgKnNpZ25hbF9wYWdlOwo+PiAtLQo+PiAyLjcuNAo+ PgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdm eCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==