Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=quantatw.com (client-ip=220.128.79.91; helo=mx02.quantatw.com; envelope-from=prvs=144bab7d6=hank.liou@quantatw.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=quantatw.com Received: from mx02.quantatw.com (mx02.quantatw.com [220.128.79.91]) by lists.ozlabs.org (Postfix) with ESMTP id 46PBzl0rQSzDr1Q for ; Thu, 5 Sep 2019 17:25:18 +1000 (AEST) Received: from unknown (HELO mailbx09.quanta.corp) ([10.243.91.106]) by mx02.quantatw.com with ESMTP; 05 Sep 2019 15:25:15 +0800 Received: from mailbx09.quanta.corp (10.243.91.106) by mailbx09.quanta.corp (10.243.91.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Sep 2019 15:25:15 +0800 Received: from mailbx09.quanta.corp ([fe80::c501:1c2b:62fc:dd81]) by mailbx09.quanta.corp ([fe80::c501:1c2b:62fc:dd81%6]) with mapi id 15.01.1713.004; Thu, 5 Sep 2019 15:25:15 +0800 From: =?big5?B?SGFuayBMaW91ICi8Qq7Kv6sp?= To: Patrick Venture CC: James Feist , "openbmc@lists.ozlabs.org" Subject: Re: [phosphor-pid-control] scaling issue Thread-Topic: [phosphor-pid-control] scaling issue Thread-Index: AQHVV/XbtwEoqXVk+kGbiKtv2uj0UqcFJGgAgAE9VwCAC0qVsIAAQT+AgAYx+NeABJmE/A== Date: Thu, 5 Sep 2019 07:25:15 +0000 Message-ID: References: <369926533c3e448c9d1a0d28391fd688@quantatw.com> , , <02128993d3064b53ac289500746666ab@quantatw.com> In-Reply-To: <02128993d3064b53ac289500746666ab@quantatw.com> Accept-Language: en-US, zh-TW Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.243.91.252] Content-Type: multipart/alternative; boundary="_000_dbd75be40e2f4d41a5b621a5dc3b3df7quantatwcom_" MIME-Version: 1.0 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2019 07:25:24 -0000 --_000_dbd75be40e2f4d41a5b621a5dc3b3df7quantatwcom_ Content-Type: text/plain; charset="big5" Content-Transfer-Encoding: base64 SGkgUGF0cmljaywNCg0KDQpTb3JyeSBmb3Igbm90IGNsZWFybHkgc3RhdGluZyBvdXIgcHJvYmxl bS4gV2UgaGF2ZSB0aGUgZm9sbG93aW5nIGlzc3VlOg0KDQoNCnRlbXAgc2Vuc29yIGdldHMgMzEo QykgLT4gMzEgLyAwLjI1NSA9IDEyMS41NyAtPiBwaWQgdXNlcyAxMjcuNTcgYXMgaW5wdXQgZm9y IHRlbXAgc2Vuc29yIC0+DQoNCnN0ZXB3aXNlIGZhbiB0YWJsZSBvdXRwdXQgMTAwIGR1dHkgLT4g ZnVsbCBzcGVlZCBmYW4NCg0KDQpBcyBhIHJlc3VsdCwgZmFuIHdpbGwgYmUgYXQgZnVsbCBzcGVl ZCB3aGlsZSB0ZW1wIGlzIGxvdy4gQmVmb3JlIHRoZSBjb21taXQgZmMyZTgwMyBbMV0sIHRoaXMg d29uJ3QgaGFwcGVuLiBUaGUgcm9vdCBjYXVzZSBpcyB0aGF0LCBiZWZvcmUgZmMyZTgwMywgcGlk IHdpbGwgdXNlIGNvbmZpZyBtaW4vbWF4LCB3aGljaCBpcyAwIGluIG91ciBjYXNlLiBUaGlzIHdv dWxkIG5vdCB0cmlnZ2VyIHNjYWxpbmcgZnVuY3Rpb24sIG5hbWVseSBzY2FsZVNlbnNvclJlYWRp bmcsIGluIHV0aWwuY3BwLiBIb3dldmVyLCBhZnRlciBzdWNoIGNvbW1pdCwgbWluL21heCB3b3Vs ZCBiZSBub24temVybyAoLTEyOC8xMjcgZnJvbSBEQnVzKS4gVGhpcyB3aWxsIHRyaWdnZXIgc2Nh bGluZyBmdW5jdGlvbi4NCg0KDQpbMV0gaHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bo b3ItcGlkLWNvbnRyb2wvY29tbWl0L2ZjMmU4MDNmNWQ5MjU2OTQ0ZTE4YzdjODc4YTQ0MTYwNmIx ZjEyMWMNCg0KDQpIYW5rDQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQpGcm9t OiBIYW5rIExpb3UgKLxCrsq/qykNClNlbnQ6IE1vbmRheSwgU2VwdGVtYmVyIDIsIDIwMTkgNDo1 MiBQTQ0KVG86IFBhdHJpY2sgVmVudHVyZQ0KQ2M6IEphbWVzIEZlaXN0OyBvcGVuYm1jQGxpc3Rz Lm96bGFicy5vcmcNClN1YmplY3Q6IFJlOiBbcGhvc3Bob3ItcGlkLWNvbnRyb2xdIHNjYWxpbmcg aXNzdWUNCg0KDQpIaSBQYXRyaWNrLA0KDQoNClNpbmNlIHdlIHVzZSBwaG9zcGhvci1zZWwtbG9n Z2VyIFsxXSBhdCB0aGUgc2FtZSB0aW1lLCB3ZSBkbyBhc3NpZ24gbWluIGFuZCBtYXggb2YgdGVt cCBzZW5zb3JzIHRvIERidXMgKG1heDogMTI3LCBtaW46IC0xMjgpLiBTbyBpbiB0aGUgcHJlc2Vu dCBjYXNlLCBvdXIgdGVtcCB2YWx1ZSB3aWxsIGJlIGRpdmlkZWQgYnkgMC4yNTUgKGFsc28gZHVl IHRvIGV4cG9uZW50IGlzIC0zIGhlcmUpLiBUaGlzIHdpbGwgY2F1c2UgcmUtc2NhbGluZyBwcm9i bGVtLiBUaGVyZWZvcmUgdGhlcmUgc2hvdWxkIGJlIGFuIHN0YXRlbWVudCB0byBkaXN0aW5ndWlz aCBzZW5zb3IgdHlwZXMuIElmIGl0IGlzICJ0ZW1wIiwgdGhlbiBvbmUgYXNzaWducyAwIHRvIHRo ZSBtaW4gYW5kIG1heCBmcm9tIERidXMuDQoNCg0KWzFdIGh0dHBzOi8vZ2l0aHViLmNvbS9vcGVu Ym1jL3Bob3NwaG9yLXNlbC1sb2dnZXIvYmxvYi8zZDMwMGZjYTI0YjMwODY0YjNlOWE0ZjU3Njhj ZmU1ZTc2OTQ1OGFlL2luY2x1ZGUvc2Vuc29ydXRpbHMuaHBwI0w1OTxodHRwczovL2c+DQoNCg0K SGFuaw0KDQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQpGcm9tOiBQYXRyaWNr IFZlbnR1cmUgPHZlbnR1cmVAZ29vZ2xlLmNvbT4NClNlbnQ6IEZyaWRheSwgQXVndXN0IDMwLCAy MDE5IDE6NDcgQU0NClRvOiBIYW5rIExpb3UgKLxCrsq/qykNCkNjOiBKYW1lcyBGZWlzdDsgb3Bl bmJtY0BsaXN0cy5vemxhYnMub3JnDQpTdWJqZWN0OiBSZTogW3Bob3NwaG9yLXBpZC1jb250cm9s XSBzY2FsaW5nIGlzc3VlDQoNClBUQUwgLSBodHRwczovL2dlcnJpdC5vcGVuYm1jLXByb2plY3Qu eHl6LzI0ODI3IC0gdGhpcyBpcyBtZXJnZWQsIGFuZA0KdGhlIHNyY3JldiBidW1wIHNob3VsZCBw cm9wYWdhdGUgaW50byBvcGVuYm1jL29wZW5ibWMgaW4gYSBkYXkgb3IgdHdvLg0KDQpPbiBXZWQs IEF1ZyAyOCwgMjAxOSBhdCAxMTowMCBQTSBIYW5rIExpb3UgKLxCrsq/qykgPEhhbmsuTGlvdUBx dWFudGF0dy5jb20+IHdyb3RlOg0KPg0KPiBIaSBQYXRyaWNrLA0KPg0KPiBJIHRoaW5rIGl0J3Mg T0sgdG8gcGFyc2UgdGhlIGNvbmZpZyBtaW4mbWF4IGZvciB0ZW1wIHNlbnNvcnMuDQo+DQo+IEFu eSBzdWdnZXN0aW9uPw0KPg0KPiBUaGFua3MsDQo+IEhhbmsNCj4NCj4gPi0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tDQo+ID5Gcm9tOiBvcGVuYm1jIFttYWlsdG86b3BlbmJtYy0NCj4gPmJvdW5j ZXMraGFuay5saW91PXF1YW50YXR3LmNvbUBsaXN0cy5vemxhYnMub3JnXSBPbiBCZWhhbGYgT2Yg SGFuayBMaW91DQo+ID4ovEKuyr+rKQ0KPiA+U2VudDogRnJpZGF5LCBBdWd1c3QgMjMsIDIwMTkg NDozMSBQTQ0KPiA+VG86IFBhdHJpY2sgVmVudHVyZSA8dmVudHVyZUBnb29nbGUuY29tPjsgSmFt ZXMgRmVpc3QNCj4gPjxqYW1lcy5mZWlzdEBsaW51eC5pbnRlbC5jb20+DQo+ID5DYzogb3BlbmJt Y0BsaXN0cy5vemxhYnMub3JnDQo+ID5TdWJqZWN0OiBSRTogW3Bob3NwaG9yLXBpZC1jb250cm9s XSBzY2FsaW5nIGlzc3VlDQo+ID4NCj4gPkhpIFBhdHJpY2ssDQo+ID4NCj4gPj4tLS0tLU9yaWdp bmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PkZyb206IFBhdHJpY2sgVmVudHVyZSBbbWFpbHRvOnZlbnR1 cmVAZ29vZ2xlLmNvbV0NCj4gPj5TZW50OiBXZWRuZXNkYXksIEF1Z3VzdCAyMSwgMjAxOSAxMDoz MiBQTQ0KPiA+PlRvOiBIYW5rIExpb3UgKLxCrsq/qykgPEhhbmsuTGlvdUBxdWFudGF0dy5jb20+ OyBKYW1lcyBGZWlzdA0KPiA+PjxqYW1lcy5mZWlzdEBsaW51eC5pbnRlbC5jb20+DQo+ID4+Q2M6 IG9wZW5ibWNAbGlzdHMub3psYWJzLm9yZw0KPiA+PlN1YmplY3Q6IFJlOiBbcGhvc3Bob3ItcGlk LWNvbnRyb2xdIHNjYWxpbmcgaXNzdWUNCj4gPj4NCj4gPj5PbiBXZWQsIEF1ZyAyMSwgMjAxOSBh dCAxOjExIEFNIEhhbmsgTGlvdSAovEKuyr+rKQ0KPiA+PjxIYW5rLkxpb3VAcXVhbnRhdHcuY29t PiB3cm90ZToNCj4gPj4+DQo+ID4+PiBIaSBBbGwsDQo+ID4+Pg0KPiA+Pj4NCj4gPj4+IEFmdGVy IGNvbW1pdCBbMV0sIEkgZm91bmQgbXkgdGVtcCBzZW5zb3IgcmVhZGluZyB3b3VsZCBiZSByZS1z Y2FsZWQNCj4gPj4+IGJ5DQo+ID4+bXVsdGlwbHlpbmcgMSBvdmVyIDI1NSwgbWFraW5nIHRlbXBl cmF0dXJlIGludG8gdW5mYW1pbGlhciB1bml0LiBBbHNvDQo+ID4+dGhlIGZhbiBycG0gcmVhZGlu ZyB3b3VsZCBsaWUgaW4gWzAsMV0gaW50ZXJ2YWwsIGxldHRpbmcgdGhlIGZhbiBpbnB1dA0KPiA+ PnRvIGJlIDAgKHNpbmNlIHRoZSBpbnB1dCB2YWx1ZSBvZiBmYW4gaXMgZnJvbSBhbiBpbnRlZ2Vy IGFycmF5IFsyXSkuIEFyZSB0aGVzZQ0KPiA+bm9ybWFsIGJlaGF2aW9ycz8NCj4gPj5PciBkbyBJ IG1pc3Mgc29tZXRoaW5nPw0KPiA+Pg0KPiA+PkFyZSB5b3UgdXNpbmcgZGJ1cyBjb25maWd1cmF0 aW9uIG9yIGpzb24/ICBJZiBqc29uLCBjYW4geW91IGF0dGFjaCB5b3VyIGNvbmZpZy4NCj4gPj5T aW5jZSB5b3UncmUgc2F5aW5nIGl0IHdhcyB3b3JraW5nIGFuZCBub3cgaXNuJ3QsIEknbSBhc3N1 bWluZyB0aGVyZSdzDQo+ID4+c29tZXRoaW5nIGFib3V0IHRoZSBjb25maWcgYmVpbmcgdHJlYXRl ZCBkaWZmZXJlbnRseSB3aXRoIHRoZSBjb2RlDQo+ID4+Y2hhbmdlcyBpbiBhbiB1bmV4cGVjdGVk IHdheS4NCj4gPg0KPiA+SSBmb3VuZCBwaWQgY29udHJvbCB3aWxsIGZpcnN0IHJlYWQgbWluIGFu ZCBtYXggZnJvbSBkYnVzIGFuZCB0aGVuIChiZWZvcmUNCj4gPmNvbW1pdCBbMV0pIHJldmlzZSB0 aGVtIGlmDQo+ID4NCj4gPmluZm8tPm1pbiAhPSBjb25mOjppbmhlcml0VmFsdWVGcm9tRGJ1cyAo aW4gZGJ1cy9kYnVzcGFzc2l2ZS5jcHApDQo+ID4NCj4gPkFmdGVyIHZhbHVlIGluaXRpYWxpemF0 aW9uLCB0aGUgbWluIGFuZCBtYXggd291bGQgYmUgdGhlIG9uZXMgaW4ganNvbiBmaWxlIChKc29u DQo+ID5maWxlIFszXSkuIEhvd2V2ZXIsIGFmdGVyIGNvbW1pdCBbMV0gdGhlIG1pbiBhbmQgbWF4 IHZhbHVlcyBvZiBjb25maWcgd291bGQNCj4gPm5vdCBiZSBmZWQgaW50byB0aGUgZmFuIGNvbnRy b2wgcHJvY2Vzcy4gVGhlIHNjYWxpbmcgaXNzdWUgaXMgb3JpZ2luYXRlZCBmcm9tDQo+ID5jb21t aXQgWzRdIHdpdGggdGhlIGFpbSB0byB0cmVhdCBmYW4gcnBtIGFzIHBlcmNlbnRhZ2UuIEl0IHNl ZW1zIHRoYXQgY29tbWl0DQo+ID5bMV0gdW5leHBlY3RlZGx5IGFmZmVjdHMgdGVtcCBzZW5zb3Jz IGluIHRoZSBzZW5zZSB0aGF0IHRoZSB0ZW1wIGlzIHRoZQ0KPiA+aW50ZWdlciByZWFkaW5nIG5v dCBwZXJjZW50YWdlLiBCZWZvcmUgY29tbWl0IFsxXSwgaXQgd291bGQgbm90IHJlLXNjYWxlIHRo ZQ0KPiA+dGVtcCByZWFkaW5nIHNpbmNlIG15IG1pbiBhbmQgbWF4IGFyZSAwIFs2XS4NCj4gPg0K PiA+DQo+ID4NCj4gPlRoZXJlIGlzIGFub3RoZXIgaXNzdWUgd2l0aCBjb21taXQgWzFdLiBOb3cg dGhlIGZhbiBycG0gd291bGQgYmUgc29tZXRoaW5nDQo+ID5saWtlDQo+ID4NCj4gPjE1MDAgLyAy MDAwMCA9IDAuMDc1DQo+ID4NCj4gPndoZXJlIHJwbSBtYXggMjAwMDAgaXMgZnJvbSBkYnVzLiBI b3dldmVyIHRoZSBmYW4gaW5wdXQgZnVuY3Rpb24gd291bGQNCj4gPnRyYW5zZmVyIGRvdWJsZSBp bnRvIGludCwgd2hpY2ggaXMgMCBmb3IgMC4wNzUgKHNlZSBbNV0pLiBIZW5jZSB0aGUgZmFuIGlu cHV0IGlzIDANCj4gPm5vdCBwZXJjZW50YWdlLiBJcyB0aGVyZSBzb21ldGhpbmcgd3Jvbmc/DQo+ ID4NCj4gPlsxXSBodHRwczovL2dpdGh1Yi5jb20vb3BlbmJtYy9waG9zcGhvci1waWQtDQo+ID5j b250cm9sL2NvbW1pdC9mYzJlODAzZjVkOTI1Njk0NGUxOGM3Yzg3OGE0NDE2MDZiMWYxMjFjDQo+ ID5bMl0gaHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItcGlkLQ0KPiA+Y29udHJv bC9ibG9iL2E3ZWM4MzUwZDE3YjcwMTUzY2ViZTY2NmQzZmJlODhiZGRkMDJhMWEvcGlkL2ZhbmNv bnRyb2xsZQ0KPiA+ci5jcHAjTDg2DQo+ID5bM10NCj4gPiAgICAgICB7DQo+ID4gICAgICAgICAg ICAibmFtZSI6ICJmYW4xIiwNCj4gPiAgICAgICAgICAgICJ0eXBlIjogImZhbiIsDQo+ID4gICAg ICAgICAgICAicmVhZFBhdGgiOiAiL3N5cy9jbGFzcy9od21vbi9od21vbjEvZmFuMV9pbnB1dCIs DQo+ID4gICAgICAgICAgICAid3JpdGVQYXRoIjogIi9zeXMvY2xhc3MvaHdtb24vaHdtb24xL3B3 bTEiLA0KPiA+ICAgICAgICAgICAgIm1pbiI6IDAsDQo+ID4gICAgICAgICAgICAibWF4IjogMjU1 DQo+ID4gICAgICAgIH0sDQo+ID4gICAgICAgIHsNCj4gPiAgICAgICAgICAgICJuYW1lIjogInRl bXAxIiwNCj4gPiAgICAgICAgICAgICJ0eXBlIjogInRlbXAiLA0KPiA+ICAgICAgICAgICAgInJl YWRQYXRoIjogIi94eXovb3BlbmJtY19wcm9qZWN0L3NlbnNvcnMvdGVtcGVyYXR1cmUvdGVtcDEi LA0KPiA+ICAgICAgICAgICAgIndyaXRlUGF0aCI6ICIiLA0KPiA+ICAgICAgICAgICAgIm1pbiI6 IDAsDQo+ID4gICAgICAgICAgICAibWF4IjogMA0KPiA+ICAgICAgICB9DQo+ID5bNF0gaHR0cHM6 Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItcGlkLQ0KPiA+Y29udHJvbC9jb21taXQvNzVl Yjc2OWQzNTE0MzQ1NDc4OTkxODZmNzNmZjcwYWUwMGQ3OTM0YQ0KPiA+WzVdIGh0dHBzOi8vZ2l0 aHViLmNvbS9vcGVuYm1jL3Bob3NwaG9yLXBpZC0NCj4gPmNvbnRyb2wvYmxvYi9hN2VjODM1MGQx N2I3MDE1M2NlYmU2NjZkM2ZiZTg4YmRkZDAyYTFhL3BpZC9mYW5jb250cm9sbGUNCj4gPnIuY3Bw I0w2NA0KPiA+WzZdIGh0dHBzOi8vZ2l0aHViLmNvbS9vcGVuYm1jL3Bob3NwaG9yLXBpZC0NCj4g PmNvbnRyb2wvYmxvYi9hN2VjODM1MGQxN2I3MDE1M2NlYmU2NjZkM2ZiZTg4YmRkZDAyYTFhL2Ri dXMvZGJ1c3Bhc3NpDQo+ID52ZS5jcHAjTDE1OA0KPiA+DQo+ID4+DQo+ID4+Pg0KPiA+Pj4NCj4g Pj4+IFsxXQ0KPiA+Pj4gaHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItcGlkLQ0K PiA+PmNvbnRyb2wvY29tbWl0L2ZjMmU4MDNmNWQ5MjU2OQ0KPiA+Pj4gNDRlMThjN2M4NzhhNDQx NjA2YjFmMTIxYw0KPiA+Pj4NCj4gPj4+IFsyXQ0KPiA+Pj4gaHR0cHM6Ly9naXRodWIuY29tL29w ZW5ibWMvcGhvc3Bob3ItcGlkLQ0KPiA+PmNvbnRyb2wvYmxvYi9hN2VjODM1MGQxN2I3MDE1Mw0K PiA+Pj4gY2ViZTY2NmQzZmJlODhiZGRkMDJhMWEvcGlkL2ZhbmNvbnRyb2xsZXIuY3BwI0w4Ng0K PiA+Pj4NCj4gPj4+DQo+ID4+PiBUaGFua3MsDQo+ID4+Pg0KPiA+Pj4NCj4gPj4+IEhhbmsgTGlv dQ0KPiA+Pj4NCj4gPj4+IFF1YW50YSBDb21wdXRlciBJbmMuDQo+ID4+Pg0KPiA+Pj4NCj4gPg0K PiA+U2luY2VyZWx5LA0KPiA+SGFuaw0K --_000_dbd75be40e2f4d41a5b621a5dc3b3df7quantatwcom_ Content-Type: text/html; charset="big5" Content-Transfer-Encoding: quoted-printable

Hi Patrick,


Sorry for not clearly stating our problem. We have the following issue:


temp sensor gets 31(C) -> 31 / 0.255 =3D 121.57 -> pid uses 1= 27.57 as input for temp sensor ->

stepwise fan table output 100 duty -> full speed fan


As a result, fan will be at full speed while temp is low. Before the com= mit fc2e803 [1], this won't happen. The root cause is that, before fc2e803= , pid will use config min/max, which is 0 in our case. This would not trigg= er scaling function, namely scaleSensorReading, in util.c= pp. However, after such commit, min/max would be non-zero (-128/127 from DBus). This will trigger scaling function.


[1] https://github.com/openbmc/phosphor-pid-= control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c


Hank



From: Hank Liou (=BCB=AE=CA= =BF=AB)
Sent: Monday, September 2, 2019 4:52 PM
To: Patrick Venture
Cc: James Feist; openbmc@lists.ozlabs.org
Subject: Re: [phosphor-pid-control] scaling issue
 

Hi Patrick,


Since we use phosphor-sel-logger [1] at the same time, we do assign= min and max of temp sensors to Dbus (max: 127, min: -128). So i<= span style=3D"font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Appl= e Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe U= I Symbol","Android Emoji",EmojiSymbols; font-size:16px">n the present case, our temp value will be divided by 0.255 (also due to&nbs= p;exponent is -3 here). This will cause re-scaling problem. Therefore there should be an statement to distinguish sensor types. If it is "t= emp", then one assigns 0 to the min and max from Dbus.


[1] https://github.= com/openbmc/phosphor-sel-logger/blob/3d300fca24b30864b3e9a4f5768cfe5e769458= ae/include/sensorutils.hpp#L59


Hank



From: Patrick Venture <= ;venture@google.com>
Sent: Friday, August 30, 2019 1:47 AM
To: Hank Liou (=BCB=AE=CA=BF=AB)
Cc: James Feist; openbmc@lists.ozlabs.org
Subject: Re: [phosphor-pid-control] scaling issue
 
PTAL - https://gerrit.openbmc-project.xyz/24827 - this is merged, and
the srcrev bump should propagate into openbmc/openbmc in a day or two.

On Wed, Aug 28, 2019 at 11:00 PM Hank Liou (=BCB=AE=CA=BF=AB) <Hank.Liou= @quantatw.com> wrote:
>
> Hi Patrick,
>
> I think it's OK to parse the config min&max for temp sensors.
>
> Any suggestion?
>
> Thanks,
> Hank
>
> >-----Original Message-----
> >From: openbmc [mailto:openbmc-
> >bounces+hank.liou=3Dquantatw.com@lists.ozlabs.org] On Behalf O= f Hank Liou
> >(=BCB=AE=CA=BF=AB)
> >Sent: Friday, August 23, 2019 4:31 PM
> >To: Patrick Venture <venture@google.com>; James Feist
> ><james.feist@linux.intel.com>
> >Cc: openbmc@lists.ozlabs.org
> >Subject: RE: [phosphor-pid-control] scaling issue
> >
> >Hi Patrick,
> >
> >>-----Original Message-----
> >>From: Patrick Venture [m= ailto:venture@google.com]
> >>Sent: Wednesday, August 21, 2019 10:32 PM
> >>To: Hank Liou (=BCB=AE=CA=BF=AB) <Hank.Liou@quantatw.com>= ;; James Feist
> >><james.feist@linux.intel.com>
> >>Cc: openbmc@lists.ozlabs.org
> >>Subject: Re: [phosphor-pid-control] scaling issue
> >>
> >>On Wed, Aug 21, 2019 at 1:11 AM Hank Liou (=BCB=AE=CA=BF=AB) > >><Hank.Liou@quantatw.com> wrote:
> >>>
> >>> Hi All,
> >>>
> >>>
> >>> After commit [1], I found my temp sensor reading would be= re-scaled
> >>> by
> >>multiplying 1 over 255, making temperature into unfamiliar uni= t. Also
> >>the fan rpm reading would lie in [0,1] interval, letting the f= an input
> >>to be 0 (since the input value of fan is from an integer array= [2]). Are these
> >normal behaviors?
> >>Or do I miss something?
> >>
> >>Are you using dbus configuration or json?  If json, can y= ou attach your config.
> >>Since you're saying it was working and now isn't, I'm assuming= there's
> >>something about the config being treated differently with the = code
> >>changes in an unexpected way.
> >
> >I found pid control will first read min and max from dbus and then= (before
> >commit [1]) revise them if
> >
> >info->min !=3D conf::inheritValueFromDbus (in dbus/dbuspassive.= cpp)
> >
> >After value initialization, the min and max would be the ones in j= son file (Json
> >file [3]). However, after commit [1] the min and max values of con= fig would
> >not be fed into the fan control process. The scaling issue is orig= inated from
> >commit [4] with the aim to treat fan rpm as percentage. It seems t= hat commit
> >[1] unexpectedly affects temp sensors in the sense that the temp i= s the
> >integer reading not percentage. Before commit [1], it would not re= -scale the
> >temp reading since my min and max are 0 [6].
> >
> >
> >
> >There is another issue with commit [1]. Now the fan rpm would be s= omething
> >like
> >
> >1500 / 20000 =3D 0.075
> >
> >where rpm max 20000 is from dbus. However the fan input function w= ould
> >transfer double into int, which is 0 for 0.075 (see [5]). Hence th= e fan input is 0
> >not percentage. Is there something wrong?
> >
> >[1] https://g= ithub.com/openbmc/phosphor-pid-
> >control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c
> >[2] https://g= ithub.com/openbmc/phosphor-pid-
> >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontr= olle
> >r.cpp#L86
> >[3]
> >       {
> >           = "name": "fan1",
> >           = "type": "fan",
> >           = "readPath": "/sys/class/hwmon/hwmon1/fan1_input",
> >           = "writePath": "/sys/class/hwmon/hwmon1/pwm1",
> >           = "min": 0,
> >           = "max": 255
> >        },
> >        {
> >           = "name": "temp1",
> >           = "type": "temp",
> >           = "readPath": "/xyz/openbmc_project/sensors/temperature/temp1= ",
> >           = "writePath": "",
> >           = "min": 0,
> >           = "max": 0
> >        }
> >[4] https://g= ithub.com/openbmc/phosphor-pid-
> >control/commit/75eb769d351434547899186f73ff70ae00d7934a
> >[5] https://g= ithub.com/openbmc/phosphor-pid-
> >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontr= olle
> >r.cpp#L64
> >[6] https://g= ithub.com/openbmc/phosphor-pid-
> >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/dbus/dbuspas= si
> >ve.cpp#L158
> >
> >>
> >>>
> >>>
> >>> [1]
> >>> http= s://github.com/openbmc/phosphor-pid-
> >>control/commit/fc2e803f5d92569
> >>> 44e18c7c878a441606b1f121c
> >>>
> >>> [2]
> >>> http= s://github.com/openbmc/phosphor-pid-
> >>control/blob/a7ec8350d17b70153
> >>> cebe666d3fbe88bddd02a1a/pid/fancontroller.cpp#L86
> >>>
> >>>
> >>> Thanks,
> >>>
> >>>
> >>> Hank Liou
> >>>
> >>> Quanta Computer Inc.
> >>>
> >>>
> >
> >Sincerely,
> >Hank
--_000_dbd75be40e2f4d41a5b621a5dc3b3df7quantatwcom_--