Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F083C11F69 for ; Fri, 2 Jul 2021 10:50:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 698BF6141C for ; Fri, 2 Jul 2021 10:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231347AbhGBKx0 convert rfc822-to-8bit (ORCPT ); Fri, 2 Jul 2021 06:53:26 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.85.151]:50911 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231296AbhGBKxZ (ORCPT ); Fri, 2 Jul 2021 06:53:25 -0400 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-150-Bxw1W3zEMVaEw8DsBi7IuQ-1; Fri, 02 Jul 2021 11:50:43 +0100 X-MC-Unique: Bxw1W3zEMVaEw8DsBi7IuQ-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 2 Jul 2021 11:50:43 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.018; Fri, 2 Jul 2021 11:50:43 +0100 From: David Laight To: 'Martin KaFai Lau' , "bpf@vger.kernel.org" CC: Alexei Starovoitov , Daniel Borkmann , Eric Dumazet , "kernel-team@fb.com" , Neal Cardwell , "netdev@vger.kernel.org" , Yonghong Song , Yuchung Cheng Subject: RE: [PATCH v2 bpf-next 0/8] bpf: Allow bpf tcp iter to do bpf_(get|set)sockopt Thread-Topic: [PATCH v2 bpf-next 0/8] bpf: Allow bpf tcp iter to do bpf_(get|set)sockopt Thread-Index: AQHXbrR5lp8o74ToykatvjOHrXTIrKsvgj0w Date: Fri, 2 Jul 2021 10:50:43 +0000 Message-ID: References: <20210701200535.1033513-1-kafai@fb.com> In-Reply-To: <20210701200535.1033513-1-kafai@fb.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org From: Martin KaFai Lau > Sent: 01 July 2021 21:06 > > This set is to allow bpf tcp iter to call bpf_(get|set)sockopt. How does that work at all? IIRC only setsockopt() was converted so that it is callable with a kernel buffer. The corresponding change wasn't done to getsockopt(). David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)