Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B08CC00140 for ; Mon, 8 Aug 2022 07:55:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 08E9D849B8; Mon, 8 Aug 2022 09:55:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="gJG9TDkq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 33EFA849C5; Mon, 8 Aug 2022 09:55:12 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2043.outbound.protection.outlook.com [40.107.244.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AB44C849AE for ; Mon, 8 Aug 2022 09:55:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SEzE1PR/qE3MmTtifV135oo3+XHz5eTslTqvcEjXEz8P3W5EXmfj36gBMhsiR5hvtSqLjHzGzZoMldhLEDcMWvoA8VHdxnluS5wzVxXg7ogXBhEH6DECfdOqSlqNh4fvDrnqzPL3ItmUbg0v8bf3Rla/4kdeY40uW1BqGzbO07TtV1VpW+eZEJg3tmx8XtgtTkKOS0iwYAa9+ANqzYSKmN+ijwudTVwd97BBD5YLY2Xy0IZyDArMJekAbyl0YvlIlUNuJuoo2xSUQnN1ST8bX+k4VHNPOjnYrv4UP0PXDLAhzcj0rxBTkFWSSKO/8GZojm6Qwumy3h7zi1B2GpqC3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fhKk1HstxMzuFRhaQcWh30pIFHuChyDztANSSU6iH7c=; b=i7nk69gi6TyPQGbfcfhuwq6C8dBDLaQqakAXMMyvB6NepwjTETgBjvNZI3s9IG3trC21mCkV+bHoOKehbJHsU79IOQzYDcdF/KbBTObJParet2osQrYdPpI9ILV5zdAdHwC4twWMrIyMNNmQ1Ksgf6coRBebUqS/goP/UwErd1JXIQwTs+Ka5fr1qGVlehJErhGbJyAdHRD7QHEToSjL1vxNlBgGy8w53gqIpNKM0KN0JnoPc5TwxuY38nBH4O6+HtzR2b6gKG+/2VdLaWTcVkVLDgCrhTGFwEihIcz+mswJ6W07FTaojYSFJCCqTcWAfIJDq90mp2ZrtMG5VofzjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fhKk1HstxMzuFRhaQcWh30pIFHuChyDztANSSU6iH7c=; b=gJG9TDkqajBjIVQ4LsunLLRmk38VVTqigVtICCEgrt7TQYtjX7NTbAB0lwHfwQsJDpZ/iXC5C21k+Cnz+eTPX89J2ib/lCBfc+nsh3HYCPf5TnGZD8qr/WIhsTvQjJR02PNUtyrmL1D3QgFcr5AIBzwVwl3HSyTpteGwuwd5zVU= Received: from BN9PR03CA0155.namprd03.prod.outlook.com (2603:10b6:408:f4::10) by PH7PR12MB6490.namprd12.prod.outlook.com (2603:10b6:510:1f5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.19; Mon, 8 Aug 2022 07:55:05 +0000 Received: from BN8NAM11FT006.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f4:cafe::98) by BN9PR03CA0155.outlook.office365.com (2603:10b6:408:f4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16 via Frontend Transport; Mon, 8 Aug 2022 07:55:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT006.mail.protection.outlook.com (10.13.177.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5504.14 via Frontend Transport; Mon, 8 Aug 2022 07:55:05 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 02:55:02 -0500 Message-ID: Date: Mon, 8 Aug 2022 09:54:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 3/3] net: emaclite: fix handling for IP packets with specific lengths Content-Language: en-US To: Ramon Fried , Samuel Obuch CC: U-Boot Mailing List References: <20220713135204.233268-1-samuel.obuch@codasip.com> <20220713135204.233268-4-samuel.obuch@codasip.com> From: Michal Simek In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eedbf801-cd97-4de9-3f9f-08da79134e79 X-MS-TrafficTypeDiagnostic: PH7PR12MB6490:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CgkuSmb0bpE5qpKu476bidvXnEnroLTzsUkio/Sq2zFvdKTn4PPSdu1jvn5hZN4cu2Nkidmt6rilVRhP87FAxrJCrAQW9pqUZFfpawKOt7Aor4pKNK6hZBSsBKZ9IgNkm8dObo3Dy8nJIf6n3QuoahFdYWdjjFOnvDb8Y+VvfEYTkBdPzmyiAXdpwJgUeEifHrFHZ0+vreY1avewjLIl60uCu11PL6H1ARkAyOHOGbYFLWd+EG/rWI1ZngxCih4RK53Pshgy0kH2whqR93xyMfjlKxWOLh1ok+7ARc7Ddjb0Pb9dDOuLYusCY32734pfzQBkx9IThm77PrJta/JzzOrl3SlgTxMgQCqb1SYPQ3wpu5dBQpzGRUAcgTAAl8sgg2o119mXeS5kT4bbcN92/rG7a8EJhZpXaU2WZMyIOMvvsCqE1TRZijM3spUzBZu9xUwd2jPSN5cqvbEkSzrm/uwjCRrBLPaUzJrKb2DFOAoROICZF3WpF/8izpcvmCyIqS7eppNvk1X1HsYHG7YNwv13UQlTEOtJsS8k1d8Hv2RosrC5Pm1Jfci1Ht8KODCU6yN9TGwuZZXxg9y7ZH+WBaR2lhhzRBSwLR60Xd+I3Wkez42eJEoCvVSkqMqXJ9LvLFpAGjir7ogH7rHZ9T9Ja59KG3VeI24NepWQi33y6qxacI7BmO1cL1TmZZdkdSFrp5GFH3V37Vl3OKFlMJoVON8f+UjzSfyBAmtepeIk/Djsm7XUB6OQJdvaev8FAT/T4Ryqf1gLacEe5dx5ONU99fUP+zIOndRnrVqicgcRXFnnxAprO33dem79ILC521WucQxdUmCtxNDBH1cG0dnDaEXFxjZbPaXMalcUdsCsuHwv3ffIb/UeVED0UHXKRgKT X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(376002)(396003)(136003)(39860400002)(346002)(40470700004)(46966006)(36840700001)(110136005)(36756003)(70206006)(70586007)(40460700003)(31686004)(8676002)(4326008)(36860700001)(5660300002)(31696002)(8936002)(86362001)(478600001)(316002)(16576012)(40480700001)(83380400001)(6666004)(41300700001)(44832011)(53546011)(2906002)(81166007)(2616005)(26005)(82740400003)(356005)(47076005)(426003)(336012)(186003)(16526019)(82310400005)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2022 07:55:05.3630 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eedbf801-cd97-4de9-3f9f-08da79134e79 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT006.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6490 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/6/22 19:35, Ramon Fried wrote: > On Wed, Jul 13, 2022 at 5:02 PM Samuel Obuch wrote: >> >> The maximum length is capped similarly to the emaclite_send function. >> Avoid integer underflow for values of ip->ip_len < 30, the minimum >> length of an IP packet is 21 bytes. >> >> Signed-off-by: Samuel Obuch >> --- >> drivers/net/xilinx_emaclite.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/xilinx_emaclite.c b/drivers/net/xilinx_emaclite.c >> index de7a2dee0b..21c450ec46 100644 >> --- a/drivers/net/xilinx_emaclite.c >> +++ b/drivers/net/xilinx_emaclite.c >> @@ -518,6 +518,8 @@ try_again: >> length = ntohs(ip->ip_len); >> length += ETHER_HDR_SIZE + ETH_FCS_LEN; >> debug("IP Packet %x\n", length); >> + if (length > PKTSIZE) >> + length = PKTSIZE; >> break; >> default: >> debug("Other Packet\n"); >> @@ -526,7 +528,7 @@ try_again: >> } >> >> /* Read the rest of the packet which is longer then first read */ >> - if (length != first_read) >> + if (length > first_read) >> xemaclite_alignedread(addr + first_read, >> etherrxbuff + first_read, >> length - first_read); >> -- >> 2.31.1 >> > + Michal This looks good. Reviewed-by: Michal Simek Thanks, Michal