Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A2B033DF for ; Sun, 6 Apr 2025 14:01:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.72.192.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743948084; cv=none; b=MS2irwWFAYljgujSwsKGpnAy3f+EHMshFqbRZIqkMZ/+V7AEsDGqaXk4mVVaNB3JeRIjZjO1eHOQrqLTglVm/xYW8LMmB6FxpjDlXvkl6kv+pen52usT+ldNCDu4Z7/jARqTv1JmJxJIuMNJVsT9j5ukTnL7eg15QHRMGvvsAqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743948084; c=relaxed/simple; bh=Z8Vy+6JXx3sseukElHkekQhBnlw8RcltYkpRiFpQK8Q=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=q18WiguWBsL7smt0RMldMhMnbkXB5Dg32ZJBI9yJ0I66OIbGh60+DC78aZZ626yFQLBIs9X8mL21rSgUvkSNAzglUZdgcrduFC2lEAqKcnVACAZT+BNVN5t8VaP+3P7RJTwp3VGQR+5wsquDH1g17u5MS9qejeElD1ff8BeohGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=sT9XtKQi; arc=none smtp.client-ip=217.72.192.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="sT9XtKQi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1743948060; x=1744552860; i=markus.elfring@web.de; bh=uwigZTDyFPeJg69EKyvejZYzGKbaL4PcG9bMjbiL2Ik=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To: References:Cc:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=sT9XtKQiIV1vhLj28dY0pMC08gTrAWXktiIXgVC1cY2PhJq5QQGy7J5xuIDwsVCI 4LR4+MgqGphYOJLfLhM8KkqH/QNdjXznzr7rhhXYIk3bDUWSQtwoXQqJiEyvOItkq tT92qAujfkAL3YHIxYT1dOHWzriCoxgTTEdih3iPeIuzcniUICQWU52151GO9p3sB cu1n9ET3egOtFErsZb6RWD1cjeuxJzTgcRgRpE0vjerOYkY+UL8YsskPJVLv1SId4 /Ovav7ZAW8pb2HG1Jk0SI7SKowufAHmfvGl3RJtAGrLBXGd3TQy8EBs9nCIl2BUYm OGdKV422+pf0NuEclA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.29] ([94.31.93.38]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MWz8l-1tZDOf2lWD-00OJgW; Sun, 06 Apr 2025 16:01:00 +0200 Message-ID: Date: Sun, 6 Apr 2025 16:00:46 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [cocci] [PATCH kdevops] scripts/coccinelle/generation: add example generation script To: Luis Chamberlain , kdevops@lists.linux.dev References: <20250403020123.1806887-1-mcgrof@kernel.org> Content-Language: en-GB Cc: cocci@inria.fr, gost.dev@samsung.com, Davidlohr Bueso , Jan Kara , Julia Lawall From: Markus Elfring In-Reply-To: <20250403020123.1806887-1-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:PJO956NId/erXPMZxq+Yuk75Ty59yYDA+O+/XeoxSnDrNItySzp dgadlxGbPiWrI+0RvWUdmrTzNQmtrOMjhIG6En8gtI8ik0RFlNphK8epfEp0Yt4Toc95lt8 6SdIHjsDE1eUbrK5GEctmPmSYCbImegvLGl2fpXWO6PdYtl0DdyDjz2TJGC5thSj/mptpnd APVGV4qhAslLNsf2PfzDw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:4LClOEfa27U=;QB4JiBTZW7m7M/yIUqPIm8BmWM3 1wFg4nyKP/OEkRX93GplXfmpMddbXhhfOMFczs9H7w5/h300/dbOHXdNtUrn7yrrkLEJG8uP1 jAcScup13N91Ca7BrtQ3s77FTET1vg7Cp5qM/G+5WVD1qhOO8L2MI2aHYNfka60+82Hl40U68 3BifxA9t3gZYwfr30Dw+VyHL1lD5ImTFrDwoK7JRQFkoQb8sR4rLbFSD14gDVU2cNyWE+9Caf t3hfcS1U03dpE6Gel4PK+JGTmAsQFAIxBsb+jq3oX8pSbd1G1Omb0XjQhJGNi88vlEXclKGAQ sMrSoM4MK8rJzHO3RfTsPF8s6dhsRYk+BVbr6HqmW6DZgnSC5yV64m3CAU1yj4JP2mtdhlwdy RNQYVnrMh+aI5/l6BgskT8QpwwVy1DBJOtas59ZjiWyvqF5lny+xnbSacMGUk4CSJKZkIBUmz 5030vyaP4FK02R3Z2uJ2GK5Xs+tH24n6kcDgJP8p7QscXfOWFwDLwOfHhFEqr9m1384CTAgDv uCbbmNcJ3F77z1dXqeAvv5ZPlgnGDuWuamx5A8TAfDjDbbAlYQvHdc693ZYklMuZVN1rtM6M2 v9A9b376Vs2bFllBccD38DLRffuLbvYa5L8n6MCTs/kbflXUHnza/QNmF9AVq25AkQxhWZGIW X16flW0wMgQqnzivEW25qGY0uQwzGgpLZ5jsoPVvIsAG8w2sHQk8OX+CDA3+E2A0zjeLizAYQ 9j9W2FPCh9Vupbl8S2gKKsoi2WsvDGm2Ey5xukK3HBbJHdYS4ceC4sALsgkE+c8H7KZRlzHU5 dAyaq/q+83l2ZYQ0qFapWobk5t/rRMK3JWCP90OH8DS/YuuZ7VHQIKLcFSkcmot/oVRlcTO5m e/gpXj3T4m6/LPBPEVn8Qq+Eogqr17XN3r36Ypir/OP+eee1P5cjAAxzz3jlWS4XGUfZBmWdR IyhuQbFJqc2BRFWMw6D8D6rlhGZPAs/BdLI4XYlQS81BCz22cSJhNxjlOVOfV+R5wRr0Kb7zU D724Tk/AezV8JCJxiCkIF3grezyCrd9iEu7lcyborlr2zVqOevzv6rZeynDlaE1xW1tLHroBI 4mXMd/nw9Q0aqj4WG99cyV/Fr+EYMO6oZ4qX0bFUcNicI1b21jLntx4kkMWAR41fFMayptePI +Lc9rJoCAlj2JKDkjm5bfFlgszUve4J/vC53XEyIsmv9DyTHzQQbVeDhxjxBTRvnowpDj8+a3 IfyU/O0i7x8nvvTHbHM6cw7yYiILmfwIrckFBXq2HPBUQVirE2Zu+wEGaES8BvHcxwpmf6XtE jsQaEampdzg76OtAw8KRPdRpxO56frPa8UFS2BcUH/ZUXNeJ9R3LLWWtrj2m+rQmAmQt/CWQt qnyX1C7pUNQ/nF4aY10B4dVHZkxRobcDduL5OwNVgdgS7Dbt1dql/5t3Kl6/Dcug14v9TkMIE 07tSkGSnLzHHfjOi6H0tK2O41U8sYLflare9rSztvpZ4Q7a02lcXMRRfz/MkYQTgd0otOiYKc tRFt/lBI5V0yuMEv4bs= =E2=80=A6 > +++ b/scripts/coccinelle/generation/check_for_atomic_calls.py > @@ -0,0 +1,443 @@ =E2=80=A6 > +header =3D f"""// SPDX-License-Identifier: GPL-2.0 =E2=80=A6 > +/// Detect atomic context in ANY transitive caller (up to {max_depth} l= evels) =E2=80=A6 > +virtual after_start > +virtual report Can any code refinements trigger desirable effects? +virtual after_start, report =E2=80=A6 > +@irq_handler_def@ > +identifier fn; > +@@ > +( > +DEFINE_IRQ_HANDLER(fn, ...) > +| > +DECLARE_TASKLET(fn, ...) > +) +(DEFINE_IRQ_HANDLER +|DECLARE_TASKLET +)(fn, ...) =E2=80=A6 > +@irq_func_names@ > +identifier fn =3D~ "(_irq|_intr|_isr|_napi|_poll|_tasklet|_softirq|_bh)= $"; > +@@ +identifier fn =3D~ "_(?:i(?:rq|(?:nt|s)r)|napi|poll|tasklet|softirq|bh)$"= ; =E2=80=A6 > +@interrupt_prefixed@ > +identifier fn =3D~ "^(irq_|intr_|isr_|napi_|poll_|do_softirq|tasklet_)"= ; > +@@ +identifier fn =3D~ "^(?:i(?:rq|(?:nt|s)r)|napi|poll|tasklet)_|do_softirq)= "; =E2=80=A6 > +@atomic_name{level} depends on after_start exists@ > +identifier virtual.transitive_caller; > +identifier atomic_fn =3D~ "(_irq|_intr|_isr|_napi|_poll|_bh|_softirq|_t= asklet|_atomic)$"; +identifier virtual.transitive_caller, + atomic_fn =3D~ "_(?:i(?:rq|(?:nt|s)r)|napi|poll|bh|softirq|tas= klet|atomic)$"; =E2=80=A6 > +++ b/scripts/coccinelle/generation/check_for_sleepy_calls.py > @@ -0,0 +1,678 @@ =E2=80=A6 > + f.write(f"""// SPDX-License-Identifier: GPL-2.0 =E2=80=A6 > +def register_sleep_point(caller_func, sleep_func, file, line, reason=3D= ""): =E2=80=A6 > + if reason: > + message =3D f"{{symbol}} {'VERIFIED' if expected_to_sleep e= lse 'WARNING'}: {{caller_func}}() might sleep at {{file}}:{{line}} - {{rea= son}} (via {{sleep_func}})" > + path_message =3D f" Call path: {{path_str}} =E2=86=92 {{s= leep_func}}" > + print(message) > + print(path_message) > + else: > + message =3D f"{{symbol}} {'VERIFIED' if expected_to_sleep e= lse 'WARNING'}: {{caller_func}}() might sleep at {{file}}:{{line}} (via {{= sleep_func}})" > + path_message =3D f" Call path: {{path_str}} =E2=86=92 {{s= leep_func}}" > + print(message) > + print(path_message) + if reason: + message =3D f"{{symbol}} {'VERIFIED' if expected_to_sleep els= e 'WARNING'}: {{caller_func}}() might sleep at {{file}}:{{line}} - {{reaso= n}} (via {{sleep_func}})" + else: + message =3D f"{{symbol}} {'VERIFIED' if expected_to_sleep els= e 'WARNING'}: {{caller_func}}() might sleep at {{file}}:{{line}} (via {{sl= eep_func}})" + + print(message) + print(f" Call path: {{path_str}} =E2=86=92 {{sleep_func}}") > + # Store this for our final stats > + if path: > + path_value =3D path_str + " =E2=86=92 " + sleep_func > + else: > + path_value =3D caller_func + " =E2=86=92 " + sleep_func + path_value =3D " =E2=86=92 ".join(((path_str if path else caller_= func), sleep_func)) =E2=80=A6 > +@check_sleep_names@ > +position p; > +identifier fn; > +identifier sleep_fn =3D~ "(_sleep|_timeout|_wait|_block|_sync|_lock|cre= ate_|alloc_|_kmalloc|_mutex)"; +identifier fn, + sleep_fn =3D~ "(?:_(sleep|timeout|wait|block|sync|lock|kmalloc= |mutex)|(?:create|alloc)_)"; > +@@ > +fn(...) {{ > + <... > + sleep_fn@p(...) > + ...> May the search pattern be really optional here? https://gitlab.inria.fr/coccinelle/coccinelle/-/blob/fe67e5985c72582553ecd= e33cd7d6e6c2643ef00/docs/manual/cocci_syntax.tex#L802-806 https://github.com/coccinelle/coccinelle/blob/4093aad2da23ea5c86916de0a71f= 43032fc2bb2f/docs/manual/cocci_syntax.tex#L802-L806 =E2=80=A6 > + if sleepy_func: > + message =3D f"\n\n{{symbol}}: {{caller_func}}() can sleep at {{= file}}:{{line}} - {{reason}} (via {{sleep_func}})" > + print(message) > + else: > + message =3D f"\n\n{{symbol}}: {{caller_func}}() found to may sl= eep." > + print(message) + if sleepy_func: + message =3D f"\n\n{{symbol}}: {{caller_func}}() can sleep at {{fi= le}}:{{line}} - {{reason}} (via {{sleep_func}})" + else: + message =3D f"\n\n{{symbol}}: {{caller_func}}() found to may slee= p." + + print(message) =E2=80=A6 > +msg =3D f"=E2=9C=85 Generated {outfile} to check if '{target_func}' mig= ht sleep" > +if sleepy_func: > + msg =3D f"=E2=9C=85 Generated {outfile} to check if '{target_func}'= calls '{sleepy_func}'" > +print(msg) +if sleepy_func: + msg =3D f"=E2=9C=85 Generated {outfile} to check if '{target_func}' c= alls '{sleepy_func}'" +else: + msg =3D f"=E2=9C=85 Generated {outfile} to check if '{target_func}' m= ight sleep" + +print(msg) =E2=80=A6 Regards, Markus