From: "flichtenheld (Code Review)" Date: Sat, 28 Dec 2024 23:06:58 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="sPMAb3WULV0="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: plaisthos , openvpn-devel --sPMAb3WULV0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/837?usp=3Demail ) Change subject: win: implement --dns option support ...................................................................... Patch Set 5: Code-Review-1 (1 comment) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/837/comment/74358983_c1d55f71 : PS5, Line 2265: MsgToEventLog(M_SYSERR, TEXT("IsInterfaceConnected:= " This actually does not work correctly. You can't use multiple string litera= ls as argument to TEXT() -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc Gerrit-Change-Number: 837 Gerrit-PatchSet: 5 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: d12fk Gerrit-Comment-Date: Sat, 28 Dec 2024 23:06:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --sPMAb3WULV0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: d12fk, plaisthos.

Patch set 5:Code-Review -1=

Vi= ew Change

1 comment:

  • File src/openvpnserv/interactive= .c:

    • Patch Set #5, L= ine 2265: MsgTo= EventLog(M_SYSERR, TEXT("IsInterfaceConnected: "

      This actually does not= work correctly. You can't use multiple string literals as argument to = TEXT()

To view, visit change 837. To unsubscribe, or f= or help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5= adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 5
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: d12fk <heiko@...515...>= ;
Gerrit-Comment-Date: Sat, 28 Dec 2024 23:06:58= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--sPMAb3WULV0=--