References: <20200813072923.24385-1-eric@...1918...>
<1fb10dd1-8ddf-c467-21a5-a93e21e6a8ac@...1227...>
<0a634481-cf3b-de2f-5e34-8f5c5ef16fdc@...1918...>
Hi Selva,
my=C2=A0suggestion would be to make
Unfortunately this doesn't help. The mda_context flags are only
set when --management-client-auth is in use, meaning this patch
would not cover plugin or script authentication, which are the
more commonly used, and this patch set specifically addresses
plugin authentication.
Regards,
Eric
--- Eric Thorpe SparkLabs Developer https= ://www.sparklabs.com h= ttps://twitter.com/sparklabs su= pport@...1918...
Hi,
On Thu, Aug 13, 2020 at 4:37 AM Eric Thorpe <eric@...1918...> wrote:
Hi Arne,
The issue is your state is not accessible from where that boolean needs
to be used unless I am missing something? Please advise if I'm mistaken
or of another route.
I agree with Arne that duplicating a state machine variable is=C2=A0not a good approach. But we have to somehow get the REAUTH (reneg)=C2=A0info in here.
This has stalled for too long, so my=C2=A0suggestion would be to makethis conditional on MANAGEMNET_DEF_AUTH so that we canthen get it from=C2=A0 session->opt->mda_context just = as we do it when=C2=A0auth is=C2=A0done via the management. In practice, that would covermost builds where this is really useful.
In fact, I think we should always enable MANAGEMENT_DEF_AUTHwhen management is enabled. That also gets rid of a lot of IFDEFs andallow the use of useful bits like CID more widely in the code. I seeno compelling reason for such fine-grained build options.--------------277FF2AD10472E5598DC164D--
A marginal increase in code size is of little consequence all butembedded devices which can continue to cope without thisas they do now.
Selva