References: <20200813072923.24385-1-eric@...1918...> <1fb10dd1-8ddf-c467-21a5-a93e21e6a8ac@...1227...> <0a634481-cf3b-de2f-5e34-8f5c5ef16fdc@...1918...> From: Eric Thorpe Message-ID: Date: Mon, 24 Aug 2020 17:49:50 +1000 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------277FF2AD10472E5598DC164D" Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH 1/2] Send auth-fail messages to clients on renegotiation failures via auth-token or user-pass expiry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Selva Nair Cc: Arne Schwabe , openvpn-devel This is a multi-part message in MIME format. --------------277FF2AD10472E5598DC164D Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Hi Selva, > my=C2=A0suggestion would be to make > this conditional on MANAGEMNET_DEF_AUTH so that we can > then get it from=C2=A0 session->opt->mda_context just as we do it when > auth is=C2=A0done via the management. In practice, that would cover > most builds where this is really useful. Unfortunately this doesn't help. The mda_context flags are only set when=20 --management-client-auth is in use, meaning this patch would not cover=20 plugin or script authentication, which are the more commonly used, and=20 this patch set specifically addresses plugin authentication. Regards, Eric --- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs support@...1918... On 23/08/2020 12:13 pm, Selva Nair wrote: > Hi, > > On Thu, Aug 13, 2020 at 4:37 AM Eric Thorpe > wrote: > > Hi Arne, > > The issue is your state is not accessible from where that boolean > needs > to be used unless I am missing something? Please advise if I'm > mistaken > or of another route. > > > I agree with Arne that duplicating a state machine variable is > not a good approach. But we have to somehow get the REAUTH (reneg) > info in here. > > This has stalled for too long, so my=C2=A0suggestion would be to make > this conditional on MANAGEMNET_DEF_AUTH so that we can > then get it from=C2=A0 session->opt->mda_context just as we do it when > auth is=C2=A0done via the management. In practice, that would cover > most builds where this is really useful. > > In fact, I think we should always enable MANAGEMENT_DEF_AUTH > when management is enabled. That also gets rid of a lot of IFDEFs and > allow the use of useful bits like CID more widely in the code. I see > no compelling reason for such fine-grained build options. > > A marginal increase in code size is of little consequence all but > embedded devices which can continue to cope without this > as they do now. > > Selva --------------277FF2AD10472E5598DC164D Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Hi Selva,

my=C2=A0suggestion would be to make
this conditional on MANAGEMNET_DEF_AUTH so that we can
then get it from=C2=A0 session->opt->mda_context just as we do it when=C2=A0
auth is=C2=A0done via the management. In practice, that would cover
most builds where this is really useful.
Unfortunately this doesn't help. The mda_context flags are only set when --management-client-auth is in use, meaning this patch would not cover plugin or script authentication, which are the more commonly used, and this patch set specifically addresses plugin authentication.

Regards,
Eric

---
Eric Thorpe
SparkLabs Developer
https=
://www.sparklabs.com
h=
ttps://twitter.com/sparklabs
su=
pport@...1918...
On 23/08/2020 12:13 pm, Selva Nair wrote:
Hi,

On Thu, Aug 13, 2020 at 4:37 AM Eric Thorpe <eric@...1918...> wrote:
Hi Arne,

The issue is your state is not accessible from where that boolean needs
to be used unless I am missing something? Please advise if I'm mistaken
or of another route.

I agree with Arne that duplicating a state machine variable is=C2=A0
not a good approach. But we have to somehow get the REAUTH (reneg)=C2=A0
info in here.

This has stalled for too long, so my=C2=A0suggestion would be to make
this conditional on MANAGEMNET_DEF_AUTH so that we can
then get it from=C2=A0 session->opt->mda_context just = as we do it when=C2=A0
auth is=C2=A0done via the management. In practice, that would cover
most builds where this is really useful.

In fact, I think we should always enable MANAGEMENT_DEF_AUTH
when management is enabled. That also gets rid of a lot of IFDEFs and
allow the use of useful bits like CID more widely in the code. I see
no compelling reason for such fine-grained build options.

A marginal increase in code size is of little consequence all but
embedded devices which can continue to cope without this
as they do now.

Selva
--------------277FF2AD10472E5598DC164D--