Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A69FBC76196 for ; Thu, 6 Apr 2023 20:36:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB9D610ED0C; Thu, 6 Apr 2023 20:36:30 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0AA3910ED0C for ; Thu, 6 Apr 2023 20:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680813388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irbR4glmPEIfzFVDABEDFiMlvxyIKRZYDMi+bXbiU3E=; b=bFYpHCYqeTazo0T46ANHwVHvnggnjy+i8FrVfyD7C4Dk1GGCZaESDO/uf/UJ1edoH/wBOq 8Wi1egpTdZprIpUSqjGPP4mQdImPKtdSm2uftBpA42vrTQECLxCATFt4kMVmos6+iJxMHT f8yxGNPMyFp5PQ6EaOokwgtnphvExls= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-DDn8uBReOq-7CgJZShbpzw-1; Thu, 06 Apr 2023 16:36:27 -0400 X-MC-Unique: DDn8uBReOq-7CgJZShbpzw-1 Received: by mail-qt1-f198.google.com with SMTP id h6-20020ac85846000000b003e3c23d562aso27491240qth.1 for ; Thu, 06 Apr 2023 13:36:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680813386; x=1683405386; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6LXsKr+a/Z33uwWnUodThDv9wbW0mvJrlyH2U+mElvk=; b=n5dF4T9+M7ttE2FVSu0jRy+FddzUr0sgrDBAkGGOJxAtTTOs71RRjbuJCN5r2TWUge plOAhFmEH2o963GAiBt37tvLkBWKGdbpEkBcqvSCY10zUK9vmoQ9qpGHXAhtIhKesq9S 5S8iaXlg2VgNNpzPx5IccvU3ehNbz1aX0VQifGIV0xLvXtRq+Iwqs5AKy2V1qQqC7sDA 1vmywozq/VepZlv6IgQ8yETqJwmL272fxU7clItfaAVDKZBSRH+vHoT7MUt+uhBycvvP 1D8lW8bo3d4NBP7mMMC9bIYqqz0ZZtPpqFSDFCxv70oBfpC7/IFwoeP0i7iEJkybVt36 jRag== X-Gm-Message-State: AAQBX9d9s7zdllYauIyFyTHAQviqLaW9x7S+6kwENIFfIlxlvgy9f2iB EbNjsJ/d+jg4Pf5HZkSbCEr47jRUzqOyNucTGIEvujr7fPafNKfTgpMy84wVl7ZLXfyehkzfMmU x/c8Mg/XTMw0Bo/PYLQsZiGlgK3Hp X-Received: by 2002:a05:6214:5011:b0:5e0:2d2a:33c7 with SMTP id jo17-20020a056214501100b005e02d2a33c7mr1134139qvb.17.1680813386440; Thu, 06 Apr 2023 13:36:26 -0700 (PDT) X-Google-Smtp-Source: AKy350aMIlr6kOr7QlKmLXQ+/A47WKSK2XBUpbzukLONDGPnJm/66bMRzwwZPj9Vn6QKrcOYSdjPyw== X-Received: by 2002:a05:6214:5011:b0:5e0:2d2a:33c7 with SMTP id jo17-20020a056214501100b005e02d2a33c7mr1134098qvb.17.1680813386085; Thu, 06 Apr 2023 13:36:26 -0700 (PDT) Received: from ?IPv6:2600:4040:5c62:8200::feb? ([2600:4040:5c62:8200::feb]) by smtp.gmail.com with ESMTPSA id u12-20020a0ced2c000000b005dd8b934572sm784208qvq.10.2023.04.06.13.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 13:36:25 -0700 (PDT) Message-ID: Subject: (Attn. Skeggsb) Re: [PATCH] drm/nouveau/gr/tu102: remove unused tu102_gr_load function From: Lyude Paul To: Tom Rix , bskeggs@redhat.com, kherbst@redhat.com, airlied@gmail.com, daniel@ffwll.ch, gsamaiya@nvidia.com Date: Thu, 06 Apr 2023 16:36:24 -0400 In-Reply-To: <20230406125102.1952202-1-trix@redhat.com> References: <20230406125102.1952202-1-trix@redhat.com> Organization: Red Hat Inc. User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hey Ben - this patch looks fine to me but I figured I should check before giving it the OK: I assume we're not planning on using tu102_gr_load for anything in the future? (if we are, do we want to just #if 0 this for the t= ime being?) On Thu, 2023-04-06 at 08:51 -0400, Tom Rix wrote: > smatch reports > drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: symbol > 'tu102_gr_load' was not declared. Should it be static? >=20 > This function is not used so remove it. >=20 > Signed-off-by: Tom Rix > --- > drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c | 13 ------------- > 1 file changed, 13 deletions(-) >=20 > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c b/drivers/gpu= /drm/nouveau/nvkm/engine/gr/tu102.c > index 3b6c8100a242..a7775aa18541 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c > @@ -206,19 +206,6 @@ tu102_gr_av_to_init_veid(struct nvkm_blob *blob, str= uct gf100_gr_pack **ppack) > =09return gk20a_gr_av_to_init_(blob, 64, 0x00100000, ppack); > } > =20 > -int > -tu102_gr_load(struct gf100_gr *gr, int ver, const struct gf100_gr_fwif *= fwif) > -{ > -=09int ret; > - > -=09ret =3D gm200_gr_load(gr, ver, fwif); > -=09if (ret) > -=09=09return ret; > - > -=09return gk20a_gr_load_net(gr, "gr/", "sw_veid_bundle_init", ver, tu102= _gr_av_to_init_veid, > -=09=09=09=09 &gr->bundle_veid); > -} > - > static const struct gf100_gr_fwif > tu102_gr_fwif[] =3D { > =09{ 0, gm200_gr_load, &tu102_gr, &gp108_gr_fecs_acr, &gp108_gr_gpccs_a= cr }, --=20 Cheers, Lyude Paul (she/her) Software Engineer at Red Hat